Call SleepEx in a loop in the Thread.Sleep () icall, to avoid a race …

…when the sleep is interrupted. Fixes #683519.
mono · Mar 30, 2011 · 648880d · 648880d
1 parent c399647
commit 648880d
Showing 1 changed file with 14 additions and 6 deletions.
diff --git a/mono/metadata/threads.c b/mono/metadata/threads.c
@@ -1158,15 +1158,23 @@ void ves_icall_System_Threading_Thread_Sleep_internal(gint32 ms)
 
 	mono_thread_current_check_pending_interrupt ();
 
-	mono_thread_set_state (thread, ThreadState_WaitSleepJoin);
+	while (TRUE) {
+		mono_thread_set_state (thread, ThreadState_WaitSleepJoin);
 
-	res = SleepEx(ms,TRUE);
+		res = SleepEx(ms,TRUE);
 
-	mono_thread_clr_state (thread, ThreadState_WaitSleepJoin);
+		mono_thread_clr_state (thread, ThreadState_WaitSleepJoin);
 
-	if (res == WAIT_IO_COMPLETION) { /* we might have been interrupted */
+		if (res == WAIT_IO_COMPLETION) { /* we might have been interrupted */
-		MonoException* exc = mono_thread_execute_interruption (thread);
+			MonoException* exc = mono_thread_execute_interruption (thread);
-		if (exc) mono_raise_exception (exc);
+			if (exc) {
+				mono_raise_exception (exc);
+			} else {
+				// FIXME: !INFINITE
+				if (ms != INFINITE)
+					break;
+			}
+		}
 	}
 }