In supplement of the changes submitted in 09b97cb, there were some additional edge cases that were not originally considered, and so this patch resolves these additional issues. In particular, there was a bug in the `RemoveApiStyle` method that wasn't checking the value of the `apistyle` attribute before removing it. This caused members to be stripped of apistyle inadvertently. There was an issue in the type removal code that caused too many files to be removed. This patch adds additional checks to make sure that a file isn't going to be removed if it contains members in the other style that shoulnd't be removed Finally, there was an issue that arose after the aforementioned changes in the `OrderTypeAttributes` method. It was somewhat counterintuitive, but it wasn't allowing the reordering of attributes with the `.Remove` method (throwing an exception). Not entirely sure why this was happening, but using the `.RemoveNamedItem` method worked around the issue.
…ress is right after the end of the method. Fixes #32955.
… is not named 'value__'. Fixes #33591.
This test is very fragile as it depends on appdomain global state. In this case the current thread culture. The problem with CurrentCulture is it's behavior that once set, it can't be unset, IOW, revert to follow DefaultThreadCurrentCulture. This meant that test ordering played a huge deal here and it took a few tries to learn what was going on. The way to fix this is to run the test itself from a thread that we can ensure that won't have CurrentCulture set. This includes TP threads or new threads. I opted to use a TP thread as there probably is one available already when the test runs.
…e mode. Fixes bug #32725. https://bugzilla.xamarin.com/show_bug.cgi?id=32725
Linux code uses a netlink socket to be notified about network interface changes. The code is a bit racy and for that reson it can happen that the LinuxNetworkChange.OnDataAvailable handler is called after the socket is destroyed (from a timer event) and socket stored in an instance variable is already null. This is a race most probably introduced by the new threadpool or TPL code as it started to happen in several places (mostly BCL tests on Android, but it's *not* specific to Android). The workaround here serves as a quick band-aid to be able to move on, but a more thorough review of the socket code will be required.
… a check that disabled it everywhere. :(
… not available. Fixes #33600
…a from web server HttpWebRequest still works When HttpWebRequest is used to download infinite (ContentLength is not set) response from web server, we must be sure that after reading 2 GB (Int32.MaxValue) of data our internal classes are still working correctly This change is released under the MIT license.
…ion of the statement. Fixes #33341