Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=25086 Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=31875 Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=32171 Reverts and reworks commit bcfec74. The problem is that when Xamarin.Android is running mkbundle, dos2unix should NEVER be used, because the Android NDK NEVER wants Unix-like paths, which is what dos2unix creates. Commit bcfec74 attempted to fix this by removing dos2unix invocation from the Xamarin.Android codepath. The problem is that the logic was backwards: it removed dos2unix invocation when XAMARIN_ANDROID was NOT defined, and PRESERVED dos2unix invocation when XAMARIN_ANDROID WAS defined. Meaning commit bcfec74 broke normal/default mkbundle.exe use on Windows -- it would no longer probe for and use dos2unix if present -- and Xamarin.Android use of mkbundle continued to check for and use dos2unix if it was present, continuing the buggy behavior. Doh! Thus, a reworking: Add a `mkbundle --dos2unix` parameter. If `mkbundle --dos2unix=false` is specified, dos2unix will NOT be probed for, and will NOT be used. If `mkbundle --dos2unix` or `mkbundle --dos2unix=true` is used, then dos2unix WILL be used. This allows the caller to consistently, ahead of time, control mkbundle's behavior regarding dos2unix, which will e.g. allow Xamarin.Android to *always* specify --dos2unix=false, allowing things to build as desired there.
… Ignore attribute The TestFixtureSetUp would sometimes fail in CI, but none of the tests in this class are actually run since they are all either [Category("NotWorking")] or [Ignore]. Moving the one test from Ignore to NotWorking category allows NUnit to recognize there are no tests to run and skips the unnecessary TestFixtureSetUp completely.
…imit. Fixes #32487
…ypes. Fixes #32609
…che changes, two methods with the same signature might have different runtime invoke wrappers now, and the caching would break their lookup.
… trampoline code on winx64.
…eric trampoline code on winx64.
…e into the .debug_frame section.
This reverts commit d6553bc. Revert this as it breaks the build.