Permalink
Switch branches/tags
Commits on Aug 15, 2018
  1. Fix bug -- dupe and dup are quite different. (#10117)

    jaykrell authored and akoeplinger committed Aug 15, 2018
    https://jenkins.mono-project.com/job/x/12802/parsed_console/log.html
    
    ves_icall_System_Security_Principal_WindowsImpersonationContext_DuplicateToken(gpointer, MonoError*)':
    mono-security-windows.c:214:62: error: invalid conversion from 'int (*)(int)' to 'gpointer {aka void*}' [-fpermissive]
      return DuplicateToken (token, SecurityImpersonation, &dupe) ? dup : NULL;
                                                                  ^
    The code is confusing the local variable dupe with an 'e' at the end
    with the function dup.
  2. [System.Reflection] CoreFX import for ManifestResourceInfo and Resour…

    MaximLipnin authored and akoeplinger committed Aug 15, 2018
    …ceLocation types (#10098)
    
    * [System.Reflection] CoreFX import for ManifestResourceInfo and ResourceLocation types.
    
    Part of #9660.
    
    * Bump API snapshot submodule
    
    * [csproj] Update project files
  3. [cxx] One more MONO_API ahead of MONO_RT_EXTERNAL_ONLY. (#9964)

    jaykrell committed Aug 15, 2018
  4. Bump corlib version (#10122)

    jaykrell authored and akoeplinger committed Aug 15, 2018
    Missed in e26c958.
  5. Merge pull request #10068 from kumpera/wasm-target-cleanup

    akoeplinger committed Aug 15, 2018
    [wasm] Cleanup build system plus some required stubs.
  6. mono_thread_info_set_is_async_context assert that setting to false is…

    jaykrell committed Aug 15, 2018
    … correct, i.e. no nesting
    
    mono_thread_info_set_is_async_context assert that setting to false is correct, i.e. no nesting
    Possibly related to #9566
  7. [merp] Fix json formatting bug (symbolicator already has workaround) (#…

    alexanderkyte authored and luhenry committed Aug 15, 2018
  8. [reflection] Implement RuntimeType.IsSubclassOf in native (#10012)

    lambdageek authored and luhenry committed Aug 15, 2018
    * [reflection] Implement RuntimeType.IsSubclassOf in native
    
    Fixes a performance regression #10000
    
    * fixup - byref and reflexive IsSubclassOf
  9. [interp] Fix missing InvalidProgramException (#10095)

    BrzVlad authored and luhenry committed Aug 15, 2018
    * [interp] Throw proper exception instead of warning
    
    Fix code causing wrong stack state.
    
    * [interp] Compile method for errors when needed
    
    Delegate creation doesn't require compiling the method.
    
    * [interp] Enable System.Core xunit tests
  10. Use clonefile instead of copyfile on macOS. (#10020)

    filipnavara authored and luhenry committed Aug 15, 2018
    * Use clonefile instead of copyfile on macOS.
    
    * Address PR review comments.
    
    * Address PR review comments (if -> assert).
    
    * RTLD_DEFAULT - > libc_handle
Commits on Aug 14, 2018
  1. [bcl] Disable a test which fails with linking. (#10103)

    vargaz authored and akoeplinger committed Aug 14, 2018
  2. [cxx] Better types at the mono_gc_alloc layer per #6695 (diff). (#10042)

    jaykrell committed Aug 14, 2018
    This allows for fewer casts from void* to non-void* elsewehere.
  3. [cxx] Make gunichar2==wchar_t on Windows. (#10056)

    jaykrell committed Aug 14, 2018
  4. [cxx] CentOS 6/gcc 4.4 and Android stdint.h/inttypes.h do not give ev…

    jaykrell committed Aug 14, 2018
    …erything without asking. (#9802)
  5. Move icalls from utils to metadata. (#10052)

    jaykrell authored and luhenry committed Aug 14, 2018
    Functions added here 58efe94#diff-eba0fd0052bf3ec9dd60f2f3e90f19e1R8483
    but icall-def.h entries missed.
  6. [cxx] Types need to be unique in Wasm. (#10091)

    jaykrell committed Aug 14, 2018
    https://jenkins.mono-project.com/job/test-mono-pull-request-wasm/3652/parsed_console/log.html
    
    invalid enum type
    !19255 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, file: !7355, producer: "clang version 5.0.0  (emscripten 1.37.36 : 1.37.36)", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, enums: !19256, retainedTypes: !19257, imports: !19263)
    !19256 = !{!7363, !6973, !168}
    !7363 = distinct !DICompositeType(tag: DW_TAG_structure_type, file: !7364, line: 192, size: 128, elements: !7365, identifier: "_ZTS10ParseState")
    /mnt/jenkins/workspace/test-mono-pull-request-wasm/sdks/builds/toolchains/emsdk/clang/e1.37.36_64bit/llvm-link: error: linked module is broken!
  7. [aot] Emit ref instances of the InternalArray methods only in corlib. (

    vargaz authored and akoeplinger committed Aug 14, 2018
    …#10086)
    
    * [aot] Emit ref instances of the InternalArray methods only in corlib.
    
    * [aot] Use strncmp ().
  8. [cxx] Cast function pointers to gpointer esp. for thread create. (#9992)

    jaykrell committed Aug 14, 2018
    Longer term some functions accepting function pointers can/should take
    a stronger type, and the parameters match w/o casting.
    Also cast int to enum one same line.
    One of these is under if 0.
    
    Should fix the following:
    
    attach.c:494:13: error: no matching function for call to 'mono_thread_create_internal'
            internal = mono_thread_create_internal (mono_get_root_domain (), receiver_thread, NULL, MONO_THREAD_CREATE_FLAGS_NONE, error);
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../../mono/metadata/threads-types.h:82:1: note: candidate function not viable: no known conversion from 'gsize (void *)' (aka 'unsigned long (void *)') to 'gpointer' (aka 'void *') for 2nd argument
    mono_thread_create_internal (MonoDomain *domain, gpointer func, gpointer arg, MonoThreadCreateFlags flags, MonoError *error);
    ^
    
    threadpool-io.c:585:7: error: no matching function for call to 'mono_thread_create_internal'
            if (!mono_thread_create_internal (mono_get_root_domain (), selector_thread, NULL, MONO_THREAD_CREATE_FLAGS_THREADPOOL | MONO_THREAD_CREATE_FLAGS_SMALL_STACK, error))
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../../mono/metadata/threads-types.h:82:1: note: candidate function not viable: no known conversion from 'gsize (gpointer)' (aka 'unsigned long (void *)') to 'gpointer' (aka 'void *') for 2nd argument
    mono_thread_create_internal (MonoDomain *domain, gpointer func, gpointer arg, MonoThreadCreateFlags flags, MonoError *error);
    ^
    
    gc.c:957:14: error: no matching function for call to 'mono_thread_create_internal'
            gc_thread = mono_thread_create_internal (mono_domain_get (), finalizer_thread, NULL, MONO_THREAD_CREATE_FLAGS_NONE, error);
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../../mono/metadata/threads-types.h:82:1: note: candidate function not viable: no known conversion from 'gsize (gpointer)' (aka 'unsigned long (void *)') to 'gpointer' (aka 'void *') for 2nd argument
    mono_thread_create_internal (MonoDomain *domain, gpointer func, gpointer arg, MonoThreadCreateFlags flags, MonoError *error);
    ^
    
    attach.c:494:13: error: no matching function for call to 'mono_thread_create_internal'
            internal = mono_thread_create_internal (mono_get_root_domain (), receiver_thread, NULL, MONO_THREAD_CREATE_FLAGS_NONE, error);
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../../mono/metadata/threads-types.h:82:1: note: candidate function not viable: no known conversion from 'gsize (void *)' (aka 'unsigned long (void *)') to 'gpointer' (aka 'void *') for 2nd argument
    mono_thread_create_internal (MonoDomain *domain, gpointer func, gpointer arg, MonoThreadCreateFlags flags, MonoError *error);
    ^
    
    threadpool-io.c:585:7: error: no matching function for call to 'mono_thread_create_internal'
            if (!mono_thread_create_internal (mono_get_root_domain (), selector_thread, NULL, MONO_THREAD_CREATE_FLAGS_THREADPOOL | MONO_THREAD_CREATE_FLAGS_SMALL_STACK, error))
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../../mono/metadata/threads-types.h:82:1: note: candidate function not viable: no known conversion from 'gsize (gpointer)' (aka 'unsigned long (void *)') to 'gpointer' (aka 'void *') for 2nd argument
    mono_thread_create_internal (MonoDomain *domain, gpointer func, gpointer arg, MonoThreadCreateFlags flags, MonoError *error);
    ^
    
    :411:24: error: no matching function for call to 'mono_create_ftnptr'
                                    func = (TestMethod)mono_create_ftnptr (mono_get_root_domain (), func);
                                                       ^~~~~~~~~~~~~~~~~~
    ../../mono/mini/mini-runtime.h:432:11: note: candidate function not viable: no known conversion from 'TestMethod' (aka 'int (*)()') to 'gpointer' (aka 'void *') for 2nd argument; take the address of the argument with &
    gpointer  mono_create_ftnptr                (MonoDomain *domain, gpointer addr);
    
    driver.c:1170:2: error: no matching function for call to 'mono_thread_create_checked'
            mono_thread_create_checked (mono_domain_get (), compile_all_methods_thread_main, &args, error);
            ^~~~~~~~~~~~~~~~~~~~~~~~~~
    ../../mono/metadata/threads-types.h:441:1: note: candidate function not viable: no known conversion from 'void (CompileAllThreadArgs *)' to 'gpointer' (aka 'void *') for 2nd argument
    mono_thread_create_checked (MonoDomain *domain, gpointer func, gpointer arg, MonoError *error);
    ^
  9. [runtime] Make mini-llvm use only mono_aot_can_dedup (#10084)

    alexanderkyte authored and akoeplinger committed Aug 14, 2018
    LLVM was using the helper for the abandoned prototype linkonce work that
    much predated when I picked up the project.
    
    This is a problem because it can lead to aot-compiler thinking a method
    is dedupable, while llvm thinking it's not. When this happens, the
    symbol does not have the Assembly baked into it's name to ensure
    uniqueness.
  10. Add .gitignore for mono/tests/assembly-load-reference

    akoeplinger committed Aug 14, 2018
  11. Strengthen the type of mono_gc_get_range_copy_func -- return a typed …

    jaykrell committed Aug 14, 2018
    …function pointer (#10057)
    
    instead of a void*. And add const on the source of a memcpy.
  12. Fix mono_string_from_blob for big endian systems (#10072)

    NattyNarwhal authored and akoeplinger committed Aug 14, 2018
    (Commit attributed to @kumpera because he wrote this quick fix, thanks!)
    
    Fixes #10070
Commits on Aug 13, 2018
  1. Bump API snapshot submodule

    monojenkins authored and marek-safar committed Aug 13, 2018
  2. X509Certificate is now immutable.

    baulig authored and marek-safar committed Jul 24, 2018
    We now adopt CoreFX's behavior in `X509Certificate` regarding serialization and immutability.
    
    * All serialization APIs now throws `PlatformNotSupportedException`.
      (this was initially part of #9650, but had to be taken out due to problems with Xunit 2.4).
    
    * All `Import()` overloads now throw `PlatformNotSupportedException`.
    
    * The property setter of `X509Certificate2.PrivateKey` now also throws `PlatformNotSupportedException`.
  3. [bcl] Update BCL Linked Size

    monojenkins authored and marek-safar committed Aug 13, 2018
  4. [wasm] We can't build the debugger under the AOT compiler.

    kumpera committed Aug 13, 2018