Permalink
Commits on Aug 26, 2016
  1. @vargaz

    [runtime] Remove most of the contents of MonoDynamicGenericClass, the… (

    #3441)
    
    * [runtime] Remove most of the contents of MonoDynamicGenericClass, the elements of the 'fields' array are not used anywhere, making all the other fields unneccesary too.
    
    * [runtime] Remove the MonoDynamicGenericClass structure, merge it into MonoGenericClass. Add some comments.
    vargaz committed on GitHub Aug 26, 2016
  2. @vargaz

    [jit] Add an assert to the native types code to make sure we are usin…

    …g the matching managed assembly.
    vargaz committed Aug 26, 2016
Commits on Aug 25, 2016
  1. @vargaz

    [llvmonly] Initialize native-to-managed wrappers when they are loaded…

    … instead of on the first call, since the call might be made on a thread not attached to the runtime. Fixes #43357.
    vargaz committed Aug 25, 2016
  2. @vargaz

    [jit] Fix an assertion on amd64 when using fixed size buffers and pin…

    …voke. Fixes #33571.
    vargaz committed Aug 25, 2016
  3. @marek-safar

    [corcompare] Show extension argument changes. Make parameter name dif…

    …ference breaking change.
    marek-safar committed Aug 25, 2016
  4. @marek-safar

    [mcs] Don't crash when as operand cannot be resolved. Fixes #43718

    marek-safar committed Aug 25, 2016
  5. @marek-safar

    [mcs] Correctly detect catch resume point marker in scope of resume p…

    …oints. Fixes #43636
    marek-safar committed Aug 25, 2016
  6. @ludovic-henry

    Merge pull request #3447 from ludovic-henry/iolayer-extract-threading

    [threads] Get thread handle from MonoThreadInfo when attaching
    ludovic-henry committed on GitHub Aug 25, 2016
  7. @tritao

    Merge pull request #3449 from lateralusX/jlorenss/win-add-missing-sou…

    …rce-file
    
    Add missing source file, sgen-os-coop.c, to libmonoruntime Visual Studio project.
    tritao committed on GitHub Aug 25, 2016
  8. @lateralusX

    Add missing source file, sgen-os-coop.c, to libmonoruntime Visual Stu…

    …dio project.
    
    Add missing source file, sgen-os-coop.c to project.
    
    Add source files and headers into correct filters (Header/Source Files).
    
    Eliminated Visual Studio linker warning LNK4221 for libmonoruntime project generated
    by empty source files under certain configurations, boehm-gc.c, lock-tracer.c,
    null-gc.c and sgen-os-coop.c
    lateralusX committed Aug 25, 2016
Commits on Aug 24, 2016
  1. @akoeplinger

    Merge pull request #3437 from ntherning/fix-DirectoryNotFoundExceptio…

    …n-thrown-in-FileInfoTest.MoveTo_DestFileName_DirectoryDoesNotExist-on-windows
    
    FileInfo.MoveTo() throws DirectoryNotFoundException rather than FileNotFoundException on Windows when target doesn't exist
    akoeplinger committed on GitHub Aug 24, 2016
  2. @ludovic-henry

    [threads] Get thread handle from MonoThreadInfo when attaching

    ludovic-henry committed Jul 14, 2016
  3. @ludovic-henry

    Merge pull request #3439 from ludovic-henry/iolayer-extract-threading

    [mono-threads] Create Win32 handle when attaching the thread
    ludovic-henry committed on GitHub Aug 24, 2016
  4. @akoeplinger

    Merge pull request #3444 from akoeplinger/fix-netstandard-extensions

    [Facades] Implement methods for *Extensions types that are available on the extended type
    akoeplinger committed on GitHub Aug 24, 2016
  5. @akoeplinger

    [mini] Wrap error output for NUnit xml in CDATA section

    Makes sure that characters like <> (which appear in stack traces) don't confuse the XML parser.
    akoeplinger committed Aug 24, 2016
  6. @marek-safar

    [monosymbolicate] Add pdb detection

    marek-safar committed Aug 24, 2016
  7. @ludovic-henry

    [mono-threads-windows] Allocate ThreadStartInfo on the stack

    ludovic-henry committed Aug 23, 2016
  8. @ludovic-henry

    [mono-threads] Create Win32 handle when attaching the thread

    This guarantee that a MonoThreadInfo always has a handle.
    ludovic-henry committed Jul 13, 2016
  9. @ludovic-henry
  10. @ludovic-henry

    [w32handle] Initialize them earlier

    If we happen to have the debugger or the log profiler enabled, we would run into a use before initialization case for the w32handle. The debugger or profiler would call `mono_gc_base_init` which would attach the current thread, and that would crash in `mono_w32handle_new` at w32handle.c:437 with `scan_mutex` being an invalid value (EINVAL).
    ludovic-henry committed Aug 24, 2016
  11. @marek-safar

    Merge pull request #3445 from rolfbjarne/cecil-update

    [tuner/linker] Update code to fix build errors after cecil update.
    marek-safar committed on GitHub Aug 24, 2016
  12. @marek-safar

    Revert "[corcompare] Reflects cecil breaking changes"

    This reverts commit b0ec389.
    marek-safar committed Aug 24, 2016
  13. @rolfbjarne

    [tuner/linker] Update code to fix warnings after cecil update.

    rolfbjarne committed Aug 24, 2016
  14. @marek-safar

    [corcompare] Reflects cecil breaking changes

    marek-safar committed Aug 24, 2016
  15. @ntherning

    FileInfo.MoveTo() throws DirectoryNotFoundException rather than

    FileNotFoundException on Mono on Windows and on .NET when target doesn't exist
    
    FileInfoTest.MoveTo_DestFileName_DirectoryDoesNotExist() expects
    FileNotFoundException to be thrown but on Windows a DirectoryNotFoundException
    is thrown instead.
    
    This patch changes MoveFile() in mono/io-layer/io.c to set the last error to
    ERROR_PATH_NOT_FOUND rather than ERROR_FILE_NOT_FOUND when the destination
    path doesn't exist. This results in a DirectoryNotFoundException being thrown
    in managed code rather than FileNotFoundException. This is the behaviour
    observed in .NET.
    
    Also updated FileInfoTest.MoveTo_DestFileName_DirectoryDoesNotExist() to check
    for DirectoryNotFoundException rather than FileNotFoundException.
    ntherning committed Aug 23, 2016
  16. @ntherning

    Merge pull request #3443 from ntherning/do-not-pass-FILE_FLAG_OVERLAP…

    …PED-to-CreateFile
    
    Don't pass FILE_FLAG_OVERLAPPED to CreateFile()
    ntherning committed on GitHub Aug 24, 2016
  17. @akoeplinger

    [Facades] Add argument null validation for extension methods

    akoeplinger committed Aug 24, 2016
  18. @akoeplinger

    [Facades] Implement methods for *Extensions types that are available …

    …on the extended type
    
    The methods are already available in our implementations of those types so we can just forward the calls
    to the "real" types instead of throwing NotImplementedException.
    
    I audited all code in mcs/class/Facades and the only places where we still throw NotImplementedException
    are ones where we really need to add a custom implementation.
    
    Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=43695
    akoeplinger committed Aug 24, 2016
  19. @akoeplinger

    [Facades] Make sure "this" is added to the type extensions

    It was missing on a few methods.
    akoeplinger committed Aug 24, 2016
  20. @akoeplinger

    [Facades] Throw PlatformNotSupportedException instead of NotImplement…

    …edException for ServiceController on mobile
    
    It's unlikely the ServiceController APIs will be supported on mobile since they don't really make sense there,
    they were initially designed for controlling Windows Services.
    akoeplinger committed Aug 24, 2016
  21. @marek-safar

    Merge pull request #3436 from ntherning/fix-alt-dir-separator-not-rep…

    …laced-in-Path.CleanPath
    
    Path.CleanPath() does not always replace AltDirectorySeparatorChar
    marek-safar committed on GitHub Aug 24, 2016
  22. @rolfbjarne

    [linker] Mark declaring types of nested types resolved from xml descr…

    …iptors. Fixes #43658. (#3434)
    
    If the declaring type of a nested type marked by an xml descriptor
    is not otherwise marked, the members of the nested type will not
    be preserved, because the linker will not process the nested type
    (since the parent type isn't marked, MarkStep:InitializeAssembly
    will skip it, and thus skip akk its nested types as well).
    
    https://bugzilla.xamarin.com/show_bug.cgi?id=43658
    rolfbjarne committed on GitHub Aug 24, 2016
  23. @ntherning

    Path.CleanPath() does not always replace AltDirectorySeparatorChar

    If sub == 0, i.e. there are no repeated separators, this method just returns
    the input string. On Windows, where DirectorySeparatorChar (\) is different
    from AltDirectorySeparatorChar (/), this means that the call
    
        Path.GetDirectoryName ("foo/bar/dingus")
    
    won't return "foo\bar" as .NET would but rather returns "foo/bar".
    
    This patch makes sure the '/' -> '\' conversion is run when
    AltDirectorySeparatorChar characters have been seen in the input string, even
    if sub == 0.
    
    PathTest.GetDirectoryName() triggered this bug.
    ntherning committed Aug 23, 2016
  24. @ntherning

    Don't pass FILE_FLAG_OVERLAPPED to CreateFile()

    When a FileStream is opened with the FileOptions.Asynchronous flag set the
    code in file-io.c will pass FILE_FLAG_OVERLAPPED to the CreateFile() function.
    On Windows this means the file will be in asynchronous mode and when
    ReadFile()/WriteFile() are called an OVERLAPPED struct has to be passed. Mono
    doesn't do this which means that when reading/writing asynchronous FileStreams
    Windows returns an ERROR_INVALID_PARAMETER and an exception is raised in
    managed code.
    
    This patch simply removes the code which passes the FILE_FLAG_OVERLAPPED to
    CreateFile(). This will work since asynchronous I/O is handled in managed code
    anyway, using threads. On the OS level the I/O is still synchronous. The patch
    won't affect other platforms since the implementation of
    ReadFile()/WriteFile()/etc in mono/io-layer/, which is used on non-Windows, is
    always synchronous and ignores the FILE_FLAG_OVERLAPPED.
    
    This bug was triggered by the
    MonoTests.System.IO.BinaryWriterTest.AsynchronousModeWrites test.
    ntherning committed Aug 24, 2016
Commits on Aug 23, 2016
  1. @marek-safar

    [bcl] More netstandard api matching

    marek-safar committed Aug 23, 2016