Permalink
Commits on Jun 11, 2016
  1. @spouliot

    [System.Net.Http] Fix CFNetworkHandler.CookieContainer not to return …

    …null (#3141)
    
    * [System.Net.Http] Fix CFNetworkHandler.CookieContainer not to return null
    
    This aligns the handler with the managed HttpClientHandler [1] and make
    it easier to switch between them without additional or conditional code.
    
    [1] https://github.com/mono/mono/blob/14f8acced5bbb2f6d55fb3e7800382700bcc65eb/mcs/class/System.Net.Http/System.Net.Http/HttpClientHandler.cs#L97
    spouliot committed on GitHub Jun 11, 2016
Commits on May 25, 2016
  1. @spouliot

    Merge pull request #2996 from UCIS/patch-7

    Generate RSA keys using public exponent 65537 (was 17)
    spouliot committed May 25, 2016
Commits on May 11, 2016
  1. @spouliot

    [System][tests] Make sure Dns tests works in a mixed IPv4/IPv6 networ…

    …k too
    
    Previous tweak could disable some tests in a mixed network, e.g.
    if an IPv6 address was first but an IPv4 address was available.
    spouliot committed May 11, 2016
  2. @spouliot

    [System][tests] Tweak Dns unit tests so it does not fail on an IPv6 o…

    …nly network
    
    Some existing tests only works when IPv4 is available, which was fine as
    it match how we historically ran those tests.
    
    Apple has a new requirement [1] to test under an "IPv6 only network" and
    the change facilitate this.
    
    [1] https://developer.apple.com/news/?id=05042016a
    spouliot committed May 11, 2016
Commits on May 3, 2016
  1. @spouliot @marek-safar
  2. @spouliot @marek-safar
  3. @spouliot @marek-safar

    Use DISABLE_CAS_USE to remove the use of several *Permission calls (f…

    …orcibly removed by the linker on XI) [#36255]
    spouliot committed with marek-safar Nov 25, 2015
Commits on May 2, 2016
  1. @spouliot @marek-safar

    RsaOaepDecrypt needs to throw, not return null

    Mono's implementation of RSAOAEPKeyExchangeDeformatter did the throwing
    but we're now using MS implementation of it - so it make sense to move
    the throw (it's needed) in the utils.cs file
    spouliot committed with marek-safar May 29, 2015
  2. @spouliot @marek-safar

    Disable more CAS checks

    spouliot committed with marek-safar May 29, 2015
  3. @spouliot @marek-safar

    Fix RSA encryption/decryption with OAEP padding [#30572]

    MS implementation is incorrect and the .NET framework never hits this code
    path as it's RSA implementation calls CryptoAPI (bypassing those managed
    classes).
    
    mscorlib/system/security/cryptography/pkcs1maskgenerationmethod.cs
    -> use Mono MGF1 implementation
    
    mscorlib/system/security/cryptography/utils.cs
    -> remove duplicated code from Mono's PKCS1
    -> fix RsaOaepEncrypt and RsaOaepDecrypt to call Mono code
    spouliot committed with marek-safar May 29, 2015
  4. @spouliot @marek-safar
  5. @spouliot @marek-safar
  6. @spouliot @marek-safar
  7. @spouliot @marek-safar
  8. @spouliot @marek-safar
  9. @spouliot @marek-safar

    Restore Mono compatibility with UnmanagedType enum

    Some values, like CustomMarshaler, are used by XI unit tests.
    spouliot committed with marek-safar Apr 22, 2015
  10. @spouliot @marek-safar
  11. @spouliot @marek-safar
  12. @spouliot @marek-safar

    Remove unused System.Web namespace from source (it does not exists in…

    … the mobile profile).
    spouliot committed with marek-safar Nov 26, 2014
Commits on Apr 23, 2016
  1. @spouliot

    [linker] Method decorated with System.Runtime.Serialization.*Attribut…

    …e must be marked, Fixes #40574
    
    Some serialization attributes are unlikely to have direct reference,
    from IL, but will be needed at runtime to correctly serialize (or
    deserialize) objects.
    
    * OnDeserializedAttribute
    * OnDeserializingAttribute
    * OnSerializedAttribute
    * OnSerializingAttribute
    
    This, along with aad627c, fixed bug
    40574. The later part will have new unit tests in XI.
    
    references:
    https://bugzilla.xamarin.com/show_bug.cgi?id=40574
    spouliot committed Apr 23, 2016
Commits on Apr 22, 2016
  1. @spouliot

    [System.Core] Add back AesManaged to tvOS and watchOS profiles

    Switching maccore to use mono-4.5.0-branch introduced this bug where
    AesManaged is not available in System.Core for both tvOS and watchOS
    profiles (iOS is fine).
    
    This results in unit tests failures on bots building maccore/master.
    
    This fix the problem by importing the "main" monotouch_System.Core.
    dll.sources into the other profiles - since they all share the same
    feature set (in this case) and make it less likely to forget something
    else in the future.
    
    reference:
    https://bugzilla.xamarin.com/show_bug.cgi?id=40570
    spouliot committed Apr 22, 2016
Commits on Jan 28, 2016
  1. @spouliot

    [System] Move HttpListenerResponse.GetStatusDescription to ease linking

    The use of HttpResponseMessage.ReasonPhrase means:
    
    * marking the HttpListenerResponse.GetStatusDescription method;
    * marking the HttpListenerResponse type;
    * which implements IDisposable, so it's Dispose method is marked
    * marking the Close method...
    
    from there a metric ton of code gets recursively marked to the point
    where the whole SSL/TLS server code gets inside the app.
    
    To avoid this we move the GetStatusDescription to a different
    type that won't bring the end of the civilized world so fast.
    spouliot committed Jan 28, 2016
Commits on Jan 26, 2016
  1. @spouliot

    [System] Make SmtpClient fallback to it's old behaviour if the hostna…

    …me cannot be resolved. Fix #37246
    
    Warning: System.Net.Mail is broken by design and sends incorrect emails.
    
    This is not to fix SmtpClient itself but to ensure it remains compatible
    (even if incorrect/broken) with older Mono releases.
    
    The commit associated with bug# 33551 [1] can cause issues on computer
    and devices that cannot resolve their hostname using the Dns API (which
    have their own issues).
    
    This commit catch the exception that occurs when resolution fails and
    continue to send an email without a fully qualified domain name - just
    like earlier Mono versions did in the past.
    
    This solve bug #32746 [2] where some, but not all, AppleTV devices fails
    to execute some of the System.dll unit tests.
    
    Note: Whenever possible stay clear of SmtpClient (and friends) and use
    something else like MimeKit/MailKit for your email needs
    
    [1] https://bugzilla.xamarin.com/show_bug.cgi?id=33551
    [2] https://bugzilla.xamarin.com/show_bug.cgi?id=37246
    spouliot committed Jan 26, 2016
Commits on Jan 25, 2016
  1. @spouliot

    [tests][System][ios] Avoid reflection usage when testing for Xamarin.…

    …iOS. Fixes #34133
    
    When the linker is enabled (default for device builds) unused methods
    are removed and cannot be reflected.
    
    In this case we do not need reflection as the answer to port reuse is
    always true.
    
    https://bugzilla.xamarin.com/show_bug.cgi?id=34133
    spouliot committed Jan 25, 2016
Commits on Jan 22, 2016
  1. @spouliot

    [system] Avoid reflection use to create NtlmSession. Fixes #37732

    commit d2325f1 (only since 4.3.2, not
    4.3.1) caused the failure when an application is linked.
    
    The use of `GetOrCreateValue` uses reflection to create an `NtlmSession`
    instance so the linker won't see it as used anymore (and removes it).
    
    Fixed by avoiding reflection (which will also perform better).
    
    https://bugzilla.xamarin.com/show_bug.cgi?id=37732
    spouliot committed Jan 22, 2016
Commits on Dec 17, 2015
  1. @spouliot

    [test][System.Runtime.Serialization] Ensure test compile on XI (avoid…

    … more than one Main method)
    spouliot committed Dec 17, 2015
Commits on Dec 5, 2015
  1. @spouliot

    [corlib][tests] Disable tests that requires Windows (dllimport) on mo…

    …bile profile
    
    This enables building the tests w/bitcode enabled on AppleTV (and they
    were already excluded from the results anyway).
    
    Part of the fix for
    https://bugzilla.xamarin.com/show_bug.cgi?id=36569
    spouliot committed Dec 5, 2015
Commits on Nov 30, 2015
  1. @spouliot

    Bump external/referencesource to get mobile fixes

    spouliot committed Nov 30, 2015
Commits on Nov 27, 2015
  1. @spouliot

    [System.Data] Remove unneeded files that includes win32 specific p/in…

    …vokes in the mobile profile
    spouliot committed Nov 27, 2015
  2. @spouliot

    [System.Xml] Do not build MS RS Win8Helpers.cs file (which includes w…

    …in32-specific pinvokes) as it is unneeded for building the mobile profile
    spouliot committed Nov 27, 2015
Commits on Nov 26, 2015
  1. @spouliot

    [System][ios] Disable non-working Ping code (and non-existing DllImport)

    * capget is not part of libc (libSystem.dylib) on iOS (or OSX); and
    * There's no working Process class to invoke `ping` by itself leading to
    
    [FAIL] DllImportTest.LackOfCapget : System.InvalidOperationException : Process has not been started.
     		  at System.Diagnostics.Process.get_HasExited () [0x00039] in /Users/poupou/git/xamarin/maccore/_build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/src/mono/mcs/class/System/System.Diagnostics/Process.cs:184
    
    It's technically possible to implement ping on iOS [1] so the code is
    not totally removed from the build (API remains identical to existing).
    
    [1] https://bugzilla.xamarin.com/show_bug.cgi?id=964
    spouliot committed Nov 26, 2015
  2. @spouliot

    [Mono.Data.Sqlite] Remove p/invokes to symbols that are not available…

    … on iOS version of libsqlite3
    
    /usr/lib/libsqlite3.dylib: 77 symbols
    	[NOT FOUND] sqlite3_column_database_name
    	[NOT FOUND] sqlite3_column_database_name16
    	[NOT FOUND] sqlite3_column_origin_name
    	[NOT FOUND] sqlite3_column_origin_name16
    	[NOT FOUND] sqlite3_column_table_name
    	[NOT FOUND] sqlite3_column_table_name16
    	[NOT FOUND] sqlite3_key
    	[NOT FOUND] sqlite3_rekey
    
    note: XI has unit tests that will detect if those symbols are added in a
    future version of iOS.
    spouliot committed Nov 26, 2015
  3. @spouliot

    [mscorlib] Do not include several win32-p/invoke calls (AccessControl…

    …) for the mobile profile
    spouliot committed Nov 26, 2015
  4. @spouliot

    [mscorlib] Do not include a win32-p/invoke call (GetFullPathName) for…

    … the mobile profile
    spouliot committed Nov 26, 2015
Commits on Nov 24, 2015
  1. @spouliot

    [system][monodroid] Remove reference to Win32NetworkInterfaceAPI (as …

    …the type was removed from the profile earlier)
    spouliot committed Nov 24, 2015