Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Make test.js use generated driver and bindings. #10244

Closed
kumpera opened this issue Aug 22, 2018 · 0 comments · Fixed by #10558
Labels

Comments

@kumpera
Copy link
Member

@kumpera kumpera commented Aug 22, 2018

Right now sdks/wasm/test.js uses custom code to deal with loading mono. We should replace this with using a generated runtime.js.

Plus, deployment shouldn't depend on us cp'ing test.js to the packaged directory. packager should suppport a --assets option that takes non-dotnet deps.

kjpou1 added a commit to kjpou1/mono that referenced this issue Sep 12, 2018
- bindings_tests.dll uses the generated bindings.dll.
- Modify packager to accept a template parameter that overrides the default `runtime.g.js`.
- Modify the tests to call runtime.js in the test-suite directory
- The runtime.js is automatically created in the test-suite library so no need to do extra copies.
- resolves mono#10244
alexischr added a commit that referenced this issue Sep 13, 2018
* Make test.js use generated driver and bindings.

- bindings_tests.dll uses the generated bindings.dll.
- Modify packager to accept a template parameter that overrides the default `runtime.g.js`.
- Modify the tests to call runtime.js in the test-suite directory
- The runtime.js is automatically created in the test-suite library so no need to do extra copies.
- resolves #10244

* Add -template option to packager

- Part of merge conflict resolution

* Add -asset option that allows an extra asset to be copied to the output directory.

-   --asset=x       Add specified asset 'x' to list of assets to be copied
- An asset option needs to be specified for each asset to be copied.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.