Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Stop using mmap for loading assemblies #10603

Closed
kumpera opened this issue Sep 13, 2018 · 2 comments
Assignees
Labels

Comments

@kumpera
Copy link
Member

@kumpera kumpera commented Sep 13, 2018

loading assemblies can hit this issue: emscripten-core/emscripten#7118

Additionally, the way this is done will cause assemblies to be held in memory twice, in the wasm heap and as a TypedArray.

Move away from using the emcc file system and use the mkbundle setup of providing a list of assemblies.

@kumpera kumpera self-assigned this Sep 13, 2018
@alexanderkyte

This comment has been minimized.

Copy link
Member

@alexanderkyte alexanderkyte commented Sep 13, 2018

This will make us much less dependent on the correctness and layout of the filesystem as a whole. I think this is an important, beneficial change if we want to avoid bitrot.

@kumpera

This comment has been minimized.

Copy link
Member Author

@kumpera kumpera commented Sep 14, 2018

@kumpera kumpera closed this in 1dcdbee Sep 17, 2018
kumpera added a commit that referenced this issue Sep 17, 2018
[wasm] Switch to mkbundle style mono_register_bundled_assemblies instead of relying on emcc filesystem emulation. Fixes #10603.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.