Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Rename sdks WebAssembly framework libraries #10620

Closed
kjpou1 opened this issue Sep 14, 2018 · 0 comments · Fixed by #10639

Comments

@kjpou1
Copy link
Member

@kjpou1 kjpou1 commented Sep 14, 2018

Right now there are two framework libraries being generated in the wasm build.

Proposed rename:

  • bindings.dll -> WebAssembly.Bindings.dll

    • The bindings library contains the WebAssembly runtime and JavaScript object bindings.
  • wasmhttp.dll -> WebAssembly.Net.Http.dll

    • The http library contains the HttpMessageHandler that works with WebAssembly using the bindings library above.
kjpou1 added a commit to kjpou1/mono that referenced this issue Sep 17, 2018
Rename:

- bindings.dll -> WebAssembly.Bindings.dll
- wasmhttp.dll -> WebAssembly.Net.Http.dll

resolves: mono#10620
luhenry added a commit that referenced this issue Sep 19, 2018
* Rename sdks WebAssembly framework libraries.

Rename:

- bindings.dll -> WebAssembly.Bindings.dll
- wasmhttp.dll -> WebAssembly.Net.Http.dll

resolves: #10620

* Fix package step

* Fix package step for WebAssembly.Net.Http.

 Fixed the package step that was failing due trying to include wasmhttp.pdb instead of WebAssembly.Net.Http.pdb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.