Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8 update broke mini/System.Core tests on WebAssembly #11908

Closed
akoeplinger opened this issue Dec 3, 2018 · 2 comments

Comments

@akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Dec 3, 2018

Steps to Reproduce

  1. Run mini or System.Core tests in the WebAssembly configuration
  2. They fail with the below error.

Current Behavior

See e.g. https://jenkins.mono-project.com/job/test-mono-mainline-wasm/1561

...
Loaded: wasm_System.Core_test.dll
initializing mono runtime
Stacktrace: 

Error
    at Array.<anonymous> (mono.js:1:22998)
    at _emscripten_asm_const_i (mono.js:1:23533)
    at wasm-function[6045]:18
    at wasm-function[3872]:47
    at wasm-function[3746]:55
    at wasm-function[2164]:44
    at wasm-function[147]:33
    at wasm-function[2273]:100
    at wasm-function[3814]:179
    at wasm-function[4692]:4
ABORT: undefined
Stacktrace: 

Error
    at Object.onAbort (runtime.js:100:13)
    at Object.abort (mono.js:1:206501)
    at _abort (mono.js:1:140391)
    at wasm-function[6045]:32
    at wasm-function[3872]:47
    at wasm-function[3746]:55
    at wasm-function[2164]:44
    at wasm-function[147]:33
    at wasm-function[2273]:100
    at wasm-function[3814]:179
Makefile:218: recipe for target 'run-v8-mini' failed

Expected Behavior

No error.

On which platforms did you notice this

[ ] macOS
[ X ] Linux
[ ] Windows

Version Used: master


Nothing changed in the code that causes this, it's apparently broken by a V8 upgrade which was automatically fetched by jsvu.

Last working build:
✔ Found latest V8 version: v7.2.505.

First failing build:
✔ Found latest V8 version: v7.3.2.

@akoeplinger

This comment has been minimized.

Copy link
Member Author

@akoeplinger akoeplinger commented Dec 3, 2018

I disabled these tests for now to unblock the PR builds.

akoeplinger added a commit that referenced this issue Dec 3, 2018
See #11908
@kjpou1

This comment has been minimized.

Copy link
Member

@kjpou1 kjpou1 commented Dec 4, 2018

This seems to be fixed in the latest v8 update:

✔ Found latest V8 version: v7.3.16.
✔ URL: https://storage.googleapis.com/chromium-v8/official/canary/v8-mac64-rel-7.3.16.zip

akoeplinger added a commit that referenced this issue Dec 4, 2018
-  Found latest V8 version: v7.3.16.  Works

Resolves: #11908
akoeplinger added a commit that referenced this issue Dec 4, 2018
-  Found latest V8 version: v7.3.16.  Works

Resolves: #11908
(cherry picked from commit 8c32d10)
alexischr added a commit to alexischr/mono that referenced this issue Dec 5, 2018
alexischr added a commit to alexischr/mono that referenced this issue Dec 5, 2018
-  Found latest V8 version: v7.3.16.  Works

Resolves: mono#11908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.