Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixme about icall-decl.h and dlopen and boehm #11936

Closed
jaykrell opened this issue Dec 4, 2018 · 1 comment
Assignees

Comments

@jaykrell
Copy link
Collaborator

@jaykrell jaykrell commented Dec 4, 2018

https://github.com/mono/mono/pull/11853/files#r238861650

asks for a new GH issue.

Specifically, we cannot include icall-decl.h without getting additional warnings or errors related to gc_dlopen.

The proposed fix is to change dlopen in win32file-unix.c to mono_dlopen, and then "undo" the FIXME. Without a call to dlopen, neither a warning about lack of declaration, nor a link error if the delcaration is provided, should occur.

@jaykrell jaykrell self-assigned this Dec 4, 2018
@jaykrell jaykrell referenced this issue Dec 4, 2018
jaykrell added a commit to jaykrell/mono that referenced this issue Dec 5, 2018
lambdageek added a commit that referenced this issue Dec 6, 2018
* Cleanup boehm/dlopen per #11853 (comment).
#11936

* s/mono_dlopen/mono_dl_open s/dlsym/mono_dl_symbol

* s/dlclose/mono_dl_close

* Fix mono_dl_symbol use.

* Fix mono_dl_open call.

* Fix type of libc_handle for mono_dl vs. regular dl.
@jaykrell

This comment has been minimized.

Copy link
Collaborator Author

@jaykrell jaykrell commented Dec 10, 2018

Fixed.

@jaykrell jaykrell closed this Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.