Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Generic sharing with long float arguments list #12831

Closed
lewurm opened this issue Feb 6, 2019 · 2 comments · Fixed by #12867 or xamarin/xamarin-android#2729

Comments

@lewurm
Copy link
Member

@lewurm lewurm commented Feb 6, 2019

Steps to Reproduce

Either current master on xamarin-macios or mono iOS SDK. Started to fail with 2018-08.

Current Behavior

test_0_arm64_small_stack_args failed: got 7, expected 0
@lewurm

This comment has been minimized.

Copy link
Member Author

@lewurm lewurm commented Feb 6, 2019

FYI result of that computation is res7 = 71:

mono/mono/mini/gshared.cs

Lines 1774 to 1776 in b4c66a1

int res7 = o.Floats (new EmptyStruct (), 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 10.0, 20.0, 30.0f, 40.0f);
if (res7 != 100)
return 7;

looks light there is a shift by one in the args.

@marek-safar

This comment has been minimized.

Copy link
Member

@marek-safar marek-safar commented Feb 6, 2019

@vargaz @lewurm can we get this fixed quickly if it's 2018-08 regression?

@akoeplinger akoeplinger added this to the 2018-10 (5.20.xx) milestone Feb 7, 2019
@lewurm lewurm self-assigned this Feb 7, 2019
lewurm added a commit to lewurm/mono that referenced this issue Feb 7, 2019
monojenkins added a commit to monojenkins/mono that referenced this issue Feb 8, 2019
monojenkins added a commit to monojenkins/mono that referenced this issue Feb 8, 2019
monojenkins added a commit to monojenkins/mono that referenced this issue Feb 8, 2019
monojenkins added a commit to monojenkins/mono that referenced this issue Feb 8, 2019
monojenkins added a commit that referenced this issue Feb 8, 2019
#12886)

[2018-10] [arm64] encode offset within stack slot for r4 in gsharedvt descriptor

Follow up fix for #11741

Fixes #12831


Backport of #12867.

/cc @lewurm
akoeplinger added a commit that referenced this issue Feb 8, 2019
… descriptor (#12884)

Follow up fix for #11741

Fixes #12831


Backport of #12867.
akoeplinger added a commit that referenced this issue Feb 8, 2019
akoeplinger added a commit that referenced this issue Feb 8, 2019
… descriptor (#12887)

Follow up fix for #11741

Fixes #12831


Backport of #12867.
luhenry added a commit that referenced this issue Feb 8, 2019
jonpryor added a commit to jonpryor/xamarin-android that referenced this issue Feb 12, 2019
jonpryor added a commit to jonpryor/xamarin-android that referenced this issue Feb 13, 2019
Fixes: mono/mono#11965
Fixes: mono/mono#12831
Fixes: xamarin/xamarin-macios#5363
Fixes: xamarin/xamarin-macios#5381

Bumps to mono/corert@e229c94

Add back missing stack frames in MERP reports.

Fix building older runtimes with newer system Mono.
(Perhaps this will fix our Linux builds?)
jonpryor added a commit to xamarin/xamarin-android that referenced this issue Feb 13, 2019
Fixes: mono/mono#11965
Fixes: mono/mono#12831
Fixes: xamarin/xamarin-macios#5363
Fixes: xamarin/xamarin-macios#5381

Bumps to mono/corert@e229c94

Add back missing stack frames in MERP reports.

Fix building older runtimes with newer system Mono.
(Perhaps this will fix our Linux builds?)
@marek-safar marek-safar changed the title [iOS] JitTests.GShared fails on devices [iOS] Generic sharing with long float arguments list Feb 18, 2019
jonpryor added a commit to xamarin/xamarin-android that referenced this issue Apr 24, 2019
Bumps to mono/api-snapshot@ae01378
Bumps to mono/reference-assemblies@e5173a5
Bumps to mono/bockbuild@d30329d
Bumps to mono/boringssl@3d87996
Bumps to mono/corefx@72f7d76
Bumps to mono/corert@1b7d4a1
Bumps to mono/helix-binaries@7e893ea
Bumps to mono/illinker-test-assets@f21ff68
Bumps to mono/linker@13d864e
Bumps to mono/llvm@1aaaaa5 [mono]
Bumps to mono/llvm@2c2cffe [xamarin-android]
Bumps to mono/NUnitLite@0029561
Bumps to mono/roslyn-binaries@0bbc9b4
Bumps to mono/xunit-binaries@8f6e62e

	$ git diff --shortstat 886c4901..e66c7667      # mono
        3597 files changed, 350850 insertions(+), 91128 deletions(-)
	$ git diff --shortstat 349752c464c5fc93b32e7d45825f2890c85c8b7d..2c2cffedf01e0fe266b9aaad2c2563e05b750ff4
	 240 files changed, 18562 insertions(+), 6581 deletions(-)

Context: dotnet/coreclr#22046

Fixes: CVE 2018-8292 on macOS
Fixes: http://work.devdiv.io/737323
Fixes: dotnet/corefx#33965
Fixes: dotnet/standard#642
Fixes: mono/mono#6997
Fixes: mono/mono#7326
Fixes: mono/mono#7517
Fixes: mono/mono#7750
Fixes: mono/mono#7859
Fixes: mono/mono#8360
Fixes: mono/mono#8460
Fixes: mono/mono#8766
Fixes: mono/mono#8922
Fixes: mono/mono#9418
Fixes: mono/mono#9507
Fixes: mono/mono#9951
Fixes: mono/mono#10024
Fixes: mono/mono#10030
Fixes: mono/mono#10038
Fixes: mono/mono#10448
Fixes: mono/mono#10735
Fixes: mono/mono#10735
Fixes: mono/mono#10737
Fixes: mono/mono#10743
Fixes: mono/mono#10834
Fixes: mono/mono#10837
Fixes: mono/mono#10838
Fixes: mono/mono#10863
Fixes: mono/mono#10945
Fixes: mono/mono#11020
Fixes: mono/mono#11021
Fixes: mono/mono#11021
Fixes: mono/mono#11049
Fixes: mono/mono#11091
Fixes: mono/mono#11095
Fixes: mono/mono#11123
Fixes: mono/mono#11138
Fixes: mono/mono#11146
Fixes: mono/mono#11202
Fixes: mono/mono#11214
Fixes: mono/mono#11317
Fixes: mono/mono#11326
Fixes: mono/mono#11378
Fixes: mono/mono#11385
Fixes: mono/mono#11478
Fixes: mono/mono#11479
Fixes: mono/mono#11488
Fixes: mono/mono#11489
Fixes: mono/mono#11527
Fixes: mono/mono#11529
Fixes: mono/mono#11596
Fixes: mono/mono#11603
Fixes: mono/mono#11613
Fixes: mono/mono#11623
Fixes: mono/mono#11663
Fixes: mono/mono#11681
Fixes: mono/mono#11684
Fixes: mono/mono#11693
Fixes: mono/mono#11697
Fixes: mono/mono#11779
Fixes: mono/mono#11809
Fixes: mono/mono#11858
Fixes: mono/mono#11895
Fixes: mono/mono#11898
Fixes: mono/mono#11898
Fixes: mono/mono#11965
Fixes: mono/mono#12182
Fixes: mono/mono#12193
Fixes: mono/mono#12218
Fixes: mono/mono#12235
Fixes: mono/mono#12263
Fixes: mono/mono#12307
Fixes: mono/mono#12331
Fixes: mono/mono#12362
Fixes: mono/mono#12374
Fixes: mono/mono#12402
Fixes: mono/mono#12421
Fixes: mono/mono#12461
Fixes: mono/mono#12479
Fixes: mono/mono#12479
Fixes: mono/mono#12552
Fixes: mono/mono#12603
Fixes: mono/mono#12747
Fixes: mono/mono#12831
Fixes: mono/mono#12843
Fixes: mono/mono#12881
Fixes: mono/mono#13030
Fixes: mono/mono#13284
Fixes: mono/mono#13297
Fixes: mono/mono#13455
Fixes: mono/mono#13460
Fixes: mono/mono#13478
Fixes: mono/mono#13479
Fixes: mono/mono#13522
Fixes: mono/mono#13607
Fixes: mono/mono#13610
Fixes: mono/mono#13610
Fixes: mono/mono#13639
Fixes: mono/mono#13672
Fixes: mono/mono#13834
Fixes: mono/mono#13878
Fixes: mono/mono#6352
Fixes: mono/monodevelop#6898
Fixes: xamarin/maccore#1069
Fixes: xamarin/maccore#1407
Fixes: xamarin/maccore#604
Fixes: xamarin/xamarin-macios#4984
Fixes: xamarin/xamarin-macios#5289
Fixes: xamarin/xamarin-macios#5363
Fixes: xamarin/xamarin-macios#5381
Fixes: https://issuetracker.unity3d.com/issues/editor-crashes-with-g-logv-when-entering-play-mode-with-active-flowcanvas-script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.