Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MonoDevelop SDB regressions #12881

Closed
kg opened this issue Feb 8, 2019 · 3 comments
Assignees

Comments

@kg
Copy link
Member

@kg kg commented Feb 8, 2019

Multiple monodevelop sdb debugging tests are failing when we move them to a newer version of mono:

2019-02-07T05:54:34.2755470Z Target Runtime: Mono 6.0.0.6 64bit
2019-02-07T05:54:34.7608230Z SDB protocol version:2.50
2019-02-07T05:54:34.7860620Z Target Runtime: Mono 6.0.0.6 64bit
2019-02-07T05:54:35.2834260Z SDB protocol version:2.50
2019-02-07T05:54:35.5290590Z Tests run: 158, Passed: 135, Errors: 0, Failures: 3, Inconclusive: 0
2019-02-07T05:54:35.5291540Z   Not run: 20, Invalid: 0, Ignored: 13, Skipped: 7
2019-02-07T05:54:35.5332410Z Elapsed time: 00:00:31.9350000
2019-02-07T05:54:35.5335100Z 
2019-02-07T05:54:35.5335550Z Errors and Failures:
2019-02-07T05:54:35.5340120Z 
2019-02-07T05:54:35.5346670Z 1) BreakpointsAndSteppingTests.Bug13640 (Mono.Debugging.Tests.Soft.SdbBreakpointsAndSteppingTests.BreakpointsAndSteppingTests.Bug13640)
2019-02-07T05:54:35.5347220Z      String lengths are both 2. Strings differ at index 0.
2019-02-07T05:54:35.5347470Z   Expected: "in"
2019-02-07T05:54:35.5347710Z   But was:  "l)"
2019-02-07T05:54:35.5348760Z   -----------^
2019-02-07T05:54:35.5349350Z 
2019-02-07T05:54:35.5351400Z   at Mono.Debugging.Tests.DebugTests.CheckPosition (System.String guid, System.Int32 offset, System.String statement, System.Boolean silent, Mono.Debugging.Tests.ITextFile file) [0x00148] in /Users/vsts/agent/2.146.0/work/1/s/monodevelop/main/external/debugger-libs/UnitTests/Mono.Debugging.Tests/Shared/DebugTests.cs:321 
2019-02-07T05:54:35.5353110Z   at Mono.Debugging.Tests.DebugTests.StepIn (System.String guid, System.Int32 offset, System.String statement) [0x00017] in monodevelop/main/external/debugger-libs/UnitTests/Mono.Debugging.Tests/Shared/DebugTests.cs:342 
2019-02-07T05:54:35.5354910Z   at Mono.Debugging.Tests.BreakpointsAndSteppingTests.Bug13640 () [0x00052] in monodevelop/main/external/debugger-libs/UnitTests/Mono.Debugging.Tests/Shared/BreakpointsAndSteppingTests.cs:812 
2019-02-07T05:54:35.5356470Z   at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
2019-02-07T05:54:35.5358720Z   at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in mono-x64/mcs/class/corlib/System.Reflection/RuntimeMethodInfo.cs:391 
2019-02-07T05:54:35.5359160Z 
2019-02-07T05:54:35.5359280Z 
2019-02-07T05:54:35.5359440Z 2) BreakpointsAndSteppingTests.Bug7901 (Mono.Debugging.Tests.Soft.SdbBreakpointsAndSteppingTests.BreakpointsAndSteppingTests.Bug7901)
2019-02-07T05:54:35.5359890Z    CheckPosition failure: Wrong line Expected:669 Actual:665 in tests/DebuggerTestProjects/MonoDevelop.Debugger.Tests.TestApp/BreakpointsAndStepping.cs
2019-02-07T05:54:35.5361820Z   at Mono.Debugging.Tests.DebugTests.CheckPosition (System.String guid, System.Int32 offset, System.String statement, System.Boolean silent, Mono.Debugging.Tests.ITextFile file) [0x000b0] in monodevelop/main/external/debugger-libs/UnitTests/Mono.Debugging.Tests/Shared/DebugTests.cs:313 
2019-02-07T05:54:35.5363540Z   at Mono.Debugging.Tests.DebugTests.StepIn (System.String guid, System.Int32 offset, System.String statement) [0x00017] in monodevelop/main/external/debugger-libs/UnitTests/Mono.Debugging.Tests/Shared/DebugTests.cs:342 
2019-02-07T05:54:35.5365190Z   at Mono.Debugging.Tests.BreakpointsAndSteppingTests.Bug7901 () [0x00030] in monodevelop/main/external/debugger-libs/UnitTests/Mono.Debugging.Tests/Shared/BreakpointsAndSteppingTests.cs:738 
2019-02-07T05:54:35.5366700Z   at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
2019-02-07T05:54:35.5368480Z   at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in mono-x64/mcs/class/corlib/System.Reflection/RuntimeMethodInfo.cs:391 
2019-02-07T05:54:35.5369250Z 
2019-02-07T05:54:35.5369370Z 
2019-02-07T05:54:35.5369550Z 3) BreakpointsAndSteppingTests.IfPropertyStepping (Mono.Debugging.Tests.Soft.SdbBreakpointsAndSteppingTests.BreakpointsAndSteppingTests.IfPropertyStepping)
2019-02-07T05:54:35.5369980Z    CheckPosition failure: Wrong line Expected:95 Actual:93 in tests/DebuggerTestProjects/MonoDevelop.Debugger.Tests.TestApp/BreakpointsAndStepping.cs
2019-02-07T05:54:35.5371830Z   at Mono.Debugging.Tests.DebugTests.CheckPosition (System.String guid, System.Int32 offset, System.String statement, System.Boolean silent, Mono.Debugging.Tests.ITextFile file) [0x000b0] in monodevelop/main/external/debugger-libs/UnitTests/Mono.Debugging.Tests/Shared/DebugTests.cs:313 
2019-02-07T05:54:35.5373730Z   at Mono.Debugging.Tests.DebugTests.StepIn (System.String guid, System.Int32 offset, System.String statement) [0x00017] in monodevelop/main/external/debugger-libs/UnitTests/Mono.Debugging.Tests/Shared/DebugTests.cs:342 
2019-02-07T05:54:35.5375290Z   at Mono.Debugging.Tests.BreakpointsAndSteppingTests.IfPropertyStepping () [0x00041] in monodevelop/main/external/debugger-libs/UnitTests/Mono.Debugging.Tests/Shared/BreakpointsAndSteppingTests.cs:187 
2019-02-07T05:54:35.5376890Z   at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
2019-02-07T05:54:35.5378670Z   at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in mono-x64/mcs/class/corlib/System.Reflection/RuntimeMethodInfo.cs:391 

https://devdiv.visualstudio.com/DevDiv/_releaseProgress?releaseId=252152&_a=release-environment-logs&environmentId=1090307

The test case and test app both haven't been changed in a while and when I examined the assertions they looked valid, so I think we regressed SDB here

@kg

This comment has been minimized.

Copy link
Member Author

@kg kg commented Feb 8, 2019

@marek-safar

This comment has been minimized.

Copy link
Member

@marek-safar marek-safar commented Feb 8, 2019

@thaystg could you please investigate these regressions

@thaystg

This comment has been minimized.

Copy link
Contributor

@thaystg thaystg commented Feb 8, 2019

Yes, of course.

thaystg added a commit to thaystg/mono that referenced this issue Feb 12, 2019
…rt the test ShouldCorrectlyStepOverOnExitFromArgsAfterStepInMethodParameter continues working and solve the regressions of 12881.

Inserted a new test that reproduces the regression.
Fixes mono#12881
thaystg added a commit that referenced this issue Feb 12, 2019
* [debugger] Reverting part of this commit #12114, removing this part the test ShouldCorrectlyStepOverOnExitFromArgsAfterStepInMethodParameter continues working and solve the regressions of 12881.
Inserted a new test that reproduces the regression.
Fixes #12881
monojenkins added a commit to monojenkins/mono that referenced this issue Feb 12, 2019
…rt the test ShouldCorrectlyStepOverOnExitFromArgsAfterStepInMethodParameter continues working and solve the regressions of 12881. Inserted a new test that reproduces the regression. Fixes mono#12881
monojenkins added a commit to monojenkins/mono that referenced this issue Feb 12, 2019
…rt the test ShouldCorrectlyStepOverOnExitFromArgsAfterStepInMethodParameter continues working and solve the regressions of 12881. Inserted a new test that reproduces the regression. Fixes mono#12881
thaystg added a commit to thaystg/mono that referenced this issue Feb 12, 2019
Reverting part of this commit mono#12114, removing this part the test ShouldCorrectlyStepOverOnExitFromArgsAfterStepInMethodParameter continues working and solve the regressions of 12881.

Inserted a new test that reproduces the regression.
Fixes mono#12881

Backport of mono#12950.

/cc @thaystg
luhenry added a commit that referenced this issue Feb 13, 2019
* [debugger] Reverting part of this commit #12114, removing this part the test ShouldCorrectlyStepOverOnExitFromArgsAfterStepInMethodParameter continues working and solve the regressions of 12881. Inserted a new test that reproduces the regression. Fixes #12881

* Changing {

* Changing {

* The interpreted version works different, because of that we can accept this 2 results in this test.
luhenry added a commit that referenced this issue Feb 13, 2019
Reverting part of this commit #12114, removing this part the test ShouldCorrectlyStepOverOnExitFromArgsAfterStepInMethodParameter continues working and solve the regressions of 12881.

Inserted a new test that reproduces the regression.
Fixes #12881

Backport of #12950.

/cc @thaystg
luhenry added a commit that referenced this issue Feb 13, 2019
* [debugger] Reverting part of this commit #12114, removing this part the test ShouldCorrectlyStepOverOnExitFromArgsAfterStepInMethodParameter continues working and solve the regressions of 12881. Inserted a new test that reproduces the regression. Fixes #12881

* Changing {

* Changing {

* The interpreted version works different, because of that we can accept this 2 results in this test.
jonpryor added a commit to xamarin/xamarin-android that referenced this issue Apr 24, 2019
Bumps to mono/api-snapshot@ae01378
Bumps to mono/reference-assemblies@e5173a5
Bumps to mono/bockbuild@d30329d
Bumps to mono/boringssl@3d87996
Bumps to mono/corefx@72f7d76
Bumps to mono/corert@1b7d4a1
Bumps to mono/helix-binaries@7e893ea
Bumps to mono/illinker-test-assets@f21ff68
Bumps to mono/linker@13d864e
Bumps to mono/llvm@1aaaaa5 [mono]
Bumps to mono/llvm@2c2cffe [xamarin-android]
Bumps to mono/NUnitLite@0029561
Bumps to mono/roslyn-binaries@0bbc9b4
Bumps to mono/xunit-binaries@8f6e62e

	$ git diff --shortstat 886c4901..e66c7667      # mono
        3597 files changed, 350850 insertions(+), 91128 deletions(-)
	$ git diff --shortstat 349752c464c5fc93b32e7d45825f2890c85c8b7d..2c2cffedf01e0fe266b9aaad2c2563e05b750ff4
	 240 files changed, 18562 insertions(+), 6581 deletions(-)

Context: dotnet/coreclr#22046

Fixes: CVE 2018-8292 on macOS
Fixes: http://work.devdiv.io/737323
Fixes: dotnet/corefx#33965
Fixes: dotnet/standard#642
Fixes: mono/mono#6997
Fixes: mono/mono#7326
Fixes: mono/mono#7517
Fixes: mono/mono#7750
Fixes: mono/mono#7859
Fixes: mono/mono#8360
Fixes: mono/mono#8460
Fixes: mono/mono#8766
Fixes: mono/mono#8922
Fixes: mono/mono#9418
Fixes: mono/mono#9507
Fixes: mono/mono#9951
Fixes: mono/mono#10024
Fixes: mono/mono#10030
Fixes: mono/mono#10038
Fixes: mono/mono#10448
Fixes: mono/mono#10735
Fixes: mono/mono#10735
Fixes: mono/mono#10737
Fixes: mono/mono#10743
Fixes: mono/mono#10834
Fixes: mono/mono#10837
Fixes: mono/mono#10838
Fixes: mono/mono#10863
Fixes: mono/mono#10945
Fixes: mono/mono#11020
Fixes: mono/mono#11021
Fixes: mono/mono#11021
Fixes: mono/mono#11049
Fixes: mono/mono#11091
Fixes: mono/mono#11095
Fixes: mono/mono#11123
Fixes: mono/mono#11138
Fixes: mono/mono#11146
Fixes: mono/mono#11202
Fixes: mono/mono#11214
Fixes: mono/mono#11317
Fixes: mono/mono#11326
Fixes: mono/mono#11378
Fixes: mono/mono#11385
Fixes: mono/mono#11478
Fixes: mono/mono#11479
Fixes: mono/mono#11488
Fixes: mono/mono#11489
Fixes: mono/mono#11527
Fixes: mono/mono#11529
Fixes: mono/mono#11596
Fixes: mono/mono#11603
Fixes: mono/mono#11613
Fixes: mono/mono#11623
Fixes: mono/mono#11663
Fixes: mono/mono#11681
Fixes: mono/mono#11684
Fixes: mono/mono#11693
Fixes: mono/mono#11697
Fixes: mono/mono#11779
Fixes: mono/mono#11809
Fixes: mono/mono#11858
Fixes: mono/mono#11895
Fixes: mono/mono#11898
Fixes: mono/mono#11898
Fixes: mono/mono#11965
Fixes: mono/mono#12182
Fixes: mono/mono#12193
Fixes: mono/mono#12218
Fixes: mono/mono#12235
Fixes: mono/mono#12263
Fixes: mono/mono#12307
Fixes: mono/mono#12331
Fixes: mono/mono#12362
Fixes: mono/mono#12374
Fixes: mono/mono#12402
Fixes: mono/mono#12421
Fixes: mono/mono#12461
Fixes: mono/mono#12479
Fixes: mono/mono#12479
Fixes: mono/mono#12552
Fixes: mono/mono#12603
Fixes: mono/mono#12747
Fixes: mono/mono#12831
Fixes: mono/mono#12843
Fixes: mono/mono#12881
Fixes: mono/mono#13030
Fixes: mono/mono#13284
Fixes: mono/mono#13297
Fixes: mono/mono#13455
Fixes: mono/mono#13460
Fixes: mono/mono#13478
Fixes: mono/mono#13479
Fixes: mono/mono#13522
Fixes: mono/mono#13607
Fixes: mono/mono#13610
Fixes: mono/mono#13610
Fixes: mono/mono#13639
Fixes: mono/mono#13672
Fixes: mono/mono#13834
Fixes: mono/mono#13878
Fixes: mono/mono#6352
Fixes: mono/monodevelop#6898
Fixes: xamarin/maccore#1069
Fixes: xamarin/maccore#1407
Fixes: xamarin/maccore#604
Fixes: xamarin/xamarin-macios#4984
Fixes: xamarin/xamarin-macios#5289
Fixes: xamarin/xamarin-macios#5363
Fixes: xamarin/xamarin-macios#5381
Fixes: https://issuetracker.unity3d.com/issues/editor-crashes-with-g-logv-when-entering-play-mode-with-active-flowcanvas-script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.