Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FullAOT) Ran out of trampolines of type 3 #13888

Open
lambdageek opened this issue Apr 5, 2019 · 2 comments

Comments

@lambdageek
Copy link
Member

@lambdageek lambdageek commented Apr 5, 2019

Seeing this in some tests on the 2018-08 branch

Examples

@marek-safar

This comment has been minimized.

Copy link
Member

@marek-safar marek-safar commented Apr 11, 2019

@vargaz what does this mean?

@vargaz

This comment has been minimized.

Copy link
Member

@vargaz vargaz commented Apr 11, 2019

The solution would be to increase the number of trampolines in INVARIANT_AOT_OPTIONS in configure.ac, since this is just a testing lane.

jaykrell pushed a commit to jaykrell/mono that referenced this issue Apr 11, 2019
Eventually this stuff should be fully dynamic, but where it
really counts -- iOS -- it already is. Otherwise is testing only,
i.e. FullAOT on platforms that allow JIT.

There are many minor arguments here.

Arguably we should JIT these.
Either w/o a fixed pool, or when the pool is depleted.
But that defeats the test coverage.

The test coverage is partial in any case, but the current
approach probably best approximates iOS.

Mitigates mono#13888.
jaykrell pushed a commit to jaykrell/mono that referenced this issue Apr 11, 2019
Eventually this stuff should be fully dynamic, but where it
really counts -- iOS -- it already is. Otherwise is testing only,
i.e. FullAOT on platforms that allow JIT.

There are many minor arguments here.

Arguably we should JIT these.
Either w/o a fixed pool, or when the pool is depleted.
But that defeats the test coverage.

The test coverage is partial in any case, but the current
approach probably best approximates iOS.

Mitigates mono#13888.
If this feels too tenative, go bigger.
jaykrell pushed a commit to jaykrell/mono that referenced this issue Apr 11, 2019
There are many minor arguments here.

Where this matters most -- iOS -- the pool is already dynamic.

Other platforms could use a dynamic pool or JIT (despite FullAOT).
Using JIT would defeat the test coverage.

Mitigates mono#13888.
If this feels too tenative, go bigger.
marek-safar added a commit that referenced this issue Apr 12, 2019
There are many minor arguments here.

Where this matters most -- iOS -- the pool is already dynamic.

Other platforms could use a dynamic pool or JIT (despite FullAOT).
Using JIT would defeat the test coverage.

Mitigates #13888.
If this feels too tenative, go bigger.
monojenkins added a commit to monojenkins/mono that referenced this issue Apr 16, 2019
There are many minor arguments here.

Where this matters most -- iOS -- the pool is already dynamic.

Other platforms could use a dynamic pool or JIT (despite FullAOT).
Using JIT would defeat the test coverage.

Mitigates mono#13888.
If this feels too tenative, go bigger.
monojenkins added a commit to monojenkins/mono that referenced this issue Apr 16, 2019
There are many minor arguments here.

Where this matters most -- iOS -- the pool is already dynamic.

Other platforms could use a dynamic pool or JIT (despite FullAOT).
Using JIT would defeat the test coverage.

Mitigates mono#13888.
If this feels too tenative, go bigger.
marek-safar added a commit that referenced this issue Apr 18, 2019
There are many minor arguments here.

Where this matters most -- iOS -- the pool is already dynamic.

Other platforms could use a dynamic pool or JIT (despite FullAOT).
Using JIT would defeat the test coverage.

Mitigates #13888.
If this feels too tenative, go bigger.
marek-safar added a commit that referenced this issue Apr 18, 2019
There are many minor arguments here.

Where this matters most -- iOS -- the pool is already dynamic.

Other platforms could use a dynamic pool or JIT (despite FullAOT).
Using JIT would defeat the test coverage.

Mitigates #13888.
If this feels too tenative, go bigger.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.