Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Don't send HTTP requests to Google #14585

Closed
lambdageek opened this issue May 22, 2019 · 1 comment · Fixed by #14586

Comments

@lambdageek
Copy link
Member

@lambdageek lambdageek commented May 22, 2019

See for example #14541 (comment)

The tests HttpWebRequestTest.Sync and WebClientTest.DownloadTwice send requests to google.com and if we run enough tests simultaneously, Google starts responding with (429) Too Many Requests.

It would be better if we could identify some friendly site for testing (or startup a local server) so that we can rely on a predictable response.

@baulig

This comment has been minimized.

Copy link
Member

@baulig baulig commented May 22, 2019

The same pattern probably exists in far more tests. We could for instance block all outgoing network traffic on one bot then run the tests to see which.

akoeplinger added a commit to akoeplinger/mono that referenced this issue May 23, 2019
Use example.com and example.org instead.

Fixes mono#14585

Note that not all of the things I replaced make an actual network request but I thought it'd be nice to be consistent.
akoeplinger added a commit to akoeplinger/mono that referenced this issue May 23, 2019
Use example.com and example.org instead.

Fixes mono#14585

Note that not all of the things I replaced make an actual network request but I thought it'd be nice to be consistent.
akoeplinger added a commit that referenced this issue May 23, 2019
…ts (#14586)

Use example.com and example.org instead.

Fixes #14585

Note that not all of the things I replaced make an actual network request but I thought it'd be nice to be consistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.