Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on GetParameters() with UnmanagedType.LPArray in dynamic assembly #16570

Closed
mcpiroman opened this issue Aug 29, 2019 · 4 comments · Fixed by #17175
Closed

Crash on GetParameters() with UnmanagedType.LPArray in dynamic assembly #16570

mcpiroman opened this issue Aug 29, 2019 · 4 comments · Fixed by #17175
Assignees

Comments

@mcpiroman
Copy link

@mcpiroman mcpiroman commented Aug 29, 2019

using System;
using System.Reflection;
using System.Reflection.Emit;
using System.Runtime.InteropServices;

public class Program {
	public static void Main ()
	{
		var aName = new AssemblyName("TestAssembly");
		var testAssembly = AppDomain.CurrentDomain.DefineDynamicAssembly(aName, AssemblyBuilderAccess.RunAndSave);
		var testModule = testAssembly.DefineDynamicModule(aName.Name, aName.Name + ".dll");

		var typeBuilder = testModule.DefineType("TestType");

		var ctorBuilder = typeBuilder.DefineConstructor(MethodAttributes.Public, CallingConventions.Standard, Type.EmptyTypes);

		var ctorIl = ctorBuilder.GetILGenerator();
		ctorIl.Emit(OpCodes.Ret);

		var methodBuilder = typeBuilder.DefineMethod("TestMethod", MethodAttributes.Public, typeof(void), new[] { typeof(int[]) });
		methodBuilder.DefineParameter(0, ParameterAttributes.Retval, null);
		var paramBuilder = methodBuilder.DefineParameter(1, ParameterAttributes.None, null);

		var attrCtor = typeof(MarshalAsAttribute).GetConstructor(new[] { typeof(UnmanagedType) });
		object[] ctorArgs = { UnmanagedType.LPArray }; // every other value works fine
		var attr = new CustomAttributeBuilder(attrCtor, ctorArgs);
		paramBuilder.SetCustomAttribute(attr);

		var methodIl = methodBuilder.GetILGenerator();
		methodIl.Emit(OpCodes.Ret);

		var createdType = typeBuilder.CreateType();

		var methodInfo = createdType.GetMethod("TestMethod", BindingFlags.Instance | BindingFlags.Public);
		methodInfo.GetParameters(); // crash!

		Console.WriteLine("Done"); // not going here
		Console.ReadKey();
	}
}

Current Behavior

The most interesting part is the crash only occures when I use UnmanagedType.LPArray in MarshalAs. I've tried most other values from UnmanagedType and their work fine in this example (even though the parameter is int[], actually, the type of parameter doesn't seem to matter here).

This looks similar to #10201 but repro is different.

On which platforms did you notice this

[ ] macOS
[ ] Linux
[X] Windows

Version Used:

Mono JIT compiler version 5.18.0 (Visual Studio built mono)
Copyright (C) 2002-2014 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com
        TLS:           __thread
        SIGSEGV:       normal
        Notification:  Thread + polling
        Architecture:  amd64
        Disabled:      none
        Misc:          softdebug
        Interpreter:   yes
        LLVM:          supported, not enabled.
        Suspend:       preemptive
        GC:            sgen (concurrent by default)

Stacktrace

(taken from Unity crash log)

(mono-2.0-bdwgc) mono_method_get_marshal_info
(mono-2.0-bdwgc) mono_type_get_object
(mono-2.0-bdwgc) mono_verify_corlib
(mono-2.0-bdwgc) mono_param_get_objects
(mscorlib) System.Reflection.MonoMethodInfo.get_parameter_info()
(mscorlib) System.Reflection.MonoMethodInfo.GetParametersInfo()
(mscorlib) System.Reflection.MonoMethod.GetParameters()
@lambdageek

This comment has been minimized.

Copy link
Member

@lambdageek lambdageek commented Aug 29, 2019

Crashes on OSX with Mono 6.0.0.327 (2019-02/f8ea05bddcb), too

=================================================================
	Native Crash Reporting
=================================================================
Got a SIGSEGV while executing native code. This usually indicates
a fatal error in the mono runtime or one of the native libraries 
used by your application.
=================================================================

=================================================================
	Basic Fault Adddress Reporting
=================================================================
Memory around native instruction pointer (0x7fff6b7886f2):0x7fff6b7886e2  89 e5 48 89 f9 48 89 fa 48 83 e7 f0 66 0f ef c0  ..H..H..H...f...
0x7fff6b7886f2  66 0f 74 07 66 0f d7 f0 48 83 e1 0f 48 83 c8 ff  f.t.f...H...H...
0x7fff6b788702  48 d3 e0 21 c6 74 17 0f bc c6 48 29 d7 48 01 f8  H..!.t....H).H..
0x7fff6b788712  5d c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 83  ].f.........f.H.

=================================================================
	Native stacktrace:
=================================================================
	 (No frames) 


=================================================================
	Telemetry Dumper:
=================================================================
Pkilling 0x70000aef2000 from 0x11d7fb5c0
Entering thread summarizer pause from 0x11d7fb5c0
Finished thread summarizer pause from 0x11d7fb5c0.

Waiting for dumping threads to resume

=================================================================
	External Debugger Dump:
=================================================================
(lldb) command source -s 0 '/tmp/mono-gdb-commands.45713'
Executing commands in '/tmp/mono-gdb-commands.45713'.
(lldb) process attach --pid 45713
Traceback (most recent call last):
  File "<input>", line 1, in <module>
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/copy.py", line 52, in <module>
    import weakref
  File "/usr/local/Cellar/python@2/2.7.16/Frameworks/Python.framework/Versions/2.7/lib/python2.7/weakref.py", line 14, in <module>
    from _weakref import (
ImportError: cannot import name _remove_dead_weakref
warning: (x86_64) /Library/Frameworks/Mono.framework/Versions/6.0.0/lib/mono/4.5/mscorlib.dll.dylib empty dSYM file detected, dSYM was created with an executable with no debug info.
Process 45713 stopped
* thread #1, name = 'tid_307', queue = 'com.apple.main-thread', stop reason = signal SIGSTOP
    frame #0: 0x00007fff6b6da356 libsystem_kernel.dylib`__wait4 + 10
libsystem_kernel.dylib`__wait4:
->  0x7fff6b6da356 <+10>: jae    0x7fff6b6da360            ; <+20>
    0x7fff6b6da358 <+12>: movq   %rax, %rdi
    0x7fff6b6da35b <+15>: jmp    0x7fff6b6d5421            ; cerror
    0x7fff6b6da360 <+20>: retq   
Target 0: (mono) stopped.

Executable module set to "/Library/Frameworks/Mono.framework/Versions/Current/Commands/mono".
Architecture set to: x86_64h-apple-macosx-.
(lldb) thread list
Process 45713 stopped
* thread #1: tid = 0x1320cbc, 0x00007fff6b6da356 libsystem_kernel.dylib`__wait4 + 10, name = 'tid_307', queue = 'com.apple.main-thread', stop reason = signal SIGSTOP
  thread #2: tid = 0x1320cbd, 0x00007fff6b6d886a libsystem_kernel.dylib`__psynch_cvwait + 10, name = 'SGen worker'
  thread #3: tid = 0x1320cbe, 0x00007fff6b6d5266 libsystem_kernel.dylib`semaphore_wait_trap + 10, name = 'Finalizer'
  thread #4: tid = 0x1320cbf, 0x00007fff6b6d6bfe libsystem_kernel.dylib`__workq_kernreturn + 10
  thread #5: tid = 0x1320cc0, 0x00007fff6b6d6bfe libsystem_kernel.dylib`__workq_kernreturn + 10
(lldb) thread backtrace all
* thread #1, name = 'tid_307', queue = 'com.apple.main-thread', stop reason = signal SIGSTOP
  * frame #0: 0x00007fff6b6da356 libsystem_kernel.dylib`__wait4 + 10
    frame #1: 0x000000010fbfd3d0 mono`mono_dump_native_crash_info at mini-posix.c:1115:3 [opt]
    frame #2: 0x000000010fbfd134 mono`mono_dump_native_crash_info(signal=<unavailable>, ctx=<unavailable>, info=<unavailable>) at mini-posix.c:1159 [opt]
    frame #3: 0x000000010fb979b5 mono`mono_handle_native_crash(signal="SIGSEGV", ctx=0x00000001100ecf48, info=0x00000001100ecee0) at mini-exceptions.c:3340:2 [opt]
    frame #4: 0x000000010faf1d58 mono`mono_sigsegv_signal_handler_debug(_dummy=11, _info=0x00000001100ecee0, context=0x00000001100ecf48, debug_fault_addr=0xffffffff00000050) at mini-runtime.c:3403:4 [opt]
    frame #5: 0x00007fff6b78bb5d libsystem_platform.dylib`_sigtramp + 29
    frame #6: 0x00007fff6b7886f3 libsystem_platform.dylib`_platform_strlen + 19
    frame #7: 0x000000010fcd461b mono`mono_method_get_marshal_info [inlined] monoeg_strdup(str="") at glib.h:300:103 [opt]
    frame #8: 0x000000010fcd460e mono`mono_method_get_marshal_info(method=<unavailable>, mspecs=0x00007f80760288e0) at loader.c:2177 [opt]
    frame #9: 0x000000010fd584ea mono`param_objects_construct(domain=0x00007f8074c04450, refclass=<unavailable>, addr_of_sig=<unavailable>, user_data=0x00007f8076803028, error=0x00007ffee011dfe0) at reflection.c:1038:2 [opt]
    frame #10: 0x000000010fd56a01 mono`check_or_construct_handle(domain=0x00007f8074c04450, klass=0x00007f807601e7a0, item=0x00007f8076803038, user_data=0x00007f8076803028, error=0x00007ffee011dfe0, construct=(mono`param_objects_construct at reflection.c:1020)) at reflection-cache.h:123:2 [opt]
    frame #11: 0x000000010fd58314 mono`mono_param_get_objects_internal(domain=0x00007f8074c04450, method=0x00007f8076803028, refclass=0x00007f807601e7a0, error=0x00007ffee011dfe0) at reflection.c:1114:9 [opt]
    frame #12: 0x000000010fcc1476 mono`ves_icall_System_Reflection_MonoMethodInfo_get_parameter_info_raw [inlined] ves_icall_System_Reflection_MonoMethodInfo_get_parameter_info(error=<unavailable>) at icall.c:1948:9 [opt]
    frame #13: 0x000000010fcc1421 mono`ves_icall_System_Reflection_MonoMethodInfo_get_parameter_info_raw(a0=0x00007f8076803028, a1=0x00007ffee011e068, error=0x00007ffee011dfe0) at icall-def.h:687 [opt]
    frame #14: 0x0000000110058c7d
    frame #15: 0x000000010faf5129 mono`mono_jit_runtime_invoke(method=<unavailable>, obj=<unavailable>, params=0x00007ffee011e3d8, exc=0x00007f8076803028, error=<unavailable>) at mini-runtime.c:3225:12 [opt]
    frame #16: 0x000000010fd10184 mono`do_runtime_invoke(method=0x00007f8074c05af8, obj=0x0000000000000000, params=0x00007ffee011e3d8, exc=0x0000000000000000, error=0x00007ffee011e418) at object.c:3009:11 [opt]
    frame #17: 0x000000010fd13e5c mono`do_exec_main_checked [inlined] mono_runtime_invoke_checked(method=<unavailable>, obj=<unavailable>, params=<unavailable>, error=0x00007ffee011e418) at object.c:3177:9 [opt]
    frame #18: 0x000000010fd13e4d mono`do_exec_main_checked(method=0x00007f8074c05af8, args=<unavailable>, error=0x00007ffee011e418) at object.c:5072 [opt]
    frame #19: 0x000000010fb5605d mono`mono_jit_exec at driver.g.c:1321:13 [opt]
    frame #20: 0x000000010fb5604f mono`mono_jit_exec(domain=<unavailable>, assembly=<unavailable>, argc=1, argv=0x00007ffee011e790) at driver.g.c:1266 [opt]
    frame #21: 0x000000010fb59198 mono`mono_main [inlined] main_thread_handler at driver.g.c:1398:3 [opt]
    frame #22: 0x000000010fb59163 mono`mono_main(argc=2, argv=<unavailable>) at driver.g.c:2655 [opt]
    frame #23: 0x000000010fae3ff8 mono`main [inlined] mono_main_with_options(argc=<unavailable>, argv=<unavailable>) at main.c:50:9 [opt]
    frame #24: 0x000000010fae3fe4 mono`main(argc=2, argv=<unavailable>) at main.c:408 [opt]
    frame #25: 0x00007fff6b5a03d5 libdyld.dylib`start + 1
    frame #26: 0x00007fff6b5a03d5 libdyld.dylib`start + 1
  thread #2, name = 'SGen worker'
    frame #0: 0x00007fff6b6d886a libsystem_kernel.dylib`__psynch_cvwait + 10
    frame #1: 0x00007fff6b79756e libsystem_pthread.dylib`_pthread_cond_wait + 722
    frame #2: 0x000000010fddd4ee mono`thread_func [inlined] mono_os_cond_wait(mutex=<unavailable>) at mono-os-mutex.h:168:8 [opt]
    frame #3: 0x000000010fddd4db mono`thread_func at sgen-thread-pool.c:165 [opt]
    frame #4: 0x000000010fddd4cd mono`thread_func(data=0x0000000000000000) at sgen-thread-pool.c:196 [opt]
    frame #5: 0x00007fff6b7942eb libsystem_pthread.dylib`_pthread_body + 126
    frame #6: 0x00007fff6b797249 libsystem_pthread.dylib`_pthread_start + 66
    frame #7: 0x00007fff6b79340d libsystem_pthread.dylib`thread_start + 13
  thread #3, name = 'Finalizer'
    frame #0: 0x00007fff6b6d5266 libsystem_kernel.dylib`semaphore_wait_trap + 10
    frame #1: 0x000000010fd8b30a mono`finalizer_thread [inlined] mono_os_sem_wait(flags=MONO_SEM_FLAGS_ALERTABLE) at mono-os-semaphore.h:84:8 [opt]
    frame #2: 0x000000010fd8b2ff mono`finalizer_thread at mono-coop-semaphore.h:41 [opt]
    frame #3: 0x000000010fd8b2e5 mono`finalizer_thread(unused=<unavailable>) at gc.c:920 [opt]
    frame #4: 0x000000010fd36d93 mono`start_wrapper [inlined] start_wrapper_internal at threads.c:1178:3 [opt]
    frame #5: 0x000000010fd36d03 mono`start_wrapper(data=0x00007f8074c15920) at threads.c:1238 [opt]
    frame #6: 0x00007fff6b7942eb libsystem_pthread.dylib`_pthread_body + 126
    frame #7: 0x00007fff6b797249 libsystem_pthread.dylib`_pthread_start + 66
    frame #8: 0x00007fff6b79340d libsystem_pthread.dylib`thread_start + 13
  thread #4
    frame #0: 0x00007fff6b6d6bfe libsystem_kernel.dylib`__workq_kernreturn + 10
    frame #1: 0x00007fff6b793636 libsystem_pthread.dylib`_pthread_wqthread + 458
    frame #2: 0x00007fff6b7933fd libsystem_pthread.dylib`start_wqthread + 13
  thread #5
    frame #0: 0x00007fff6b6d6bfe libsystem_kernel.dylib`__workq_kernreturn + 10
    frame #1: 0x00007fff6b793636 libsystem_pthread.dylib`_pthread_wqthread + 458
    frame #2: 0x00007fff6b7933fd libsystem_pthread.dylib`start_wqthread + 13
(lldb) detach

=================================================================
	Managed Stacktrace:
=================================================================
Process 45713 detached
	  at <unknown> <0xffffffff>
(lldb) quit
	  at System.Reflection.MonoMethodInfo:get_parameter_info <0x000ac>
	  at System.Reflection.MonoMethodInfo:GetParametersInfo <0x0002e>
	  at System.Reflection.RuntimeMethodInfo:GetParameters <0x0002f>
	  at Program:Main <0x004fe>
	  at System.Object:runtime_invoke_void <0x000a5>
=================================================================
Abort trap: 6

@mcpiroman

This comment has been minimized.

Copy link
Author

@mcpiroman mcpiroman commented Aug 30, 2019

So it seems like I've got another entry point for this bug, using Marshal.GetDelegateForFunctionPointer. The code is complicated, but also involves dynamic assembly and only triggers on UnmanagedType.LPArray. Stacktrace:

(mono-2.0-bdwgc) mono_method_get_marshal_info
(mono-2.0-bdwgc) mono_stack_walk_no_il
(mscorlib) System.Runtime.InteropServices.Marshal.GetDelegateForFunctionPointerInternal()
(mscorlib) System.Runtime.InteropServices.Marshal.GetDelegateForFunctionPointer()

As you can see, mono_method_get_marshal_info also is the top most frame here.

@marek-safar

This comment has been minimized.

Copy link
Member

@marek-safar marek-safar commented Sep 9, 2019

@CoffeeFlux could you look at this issue?

@CoffeeFlux CoffeeFlux self-assigned this Sep 9, 2019
@CoffeeFlux

This comment has been minimized.

Copy link
Member

@CoffeeFlux CoffeeFlux commented Sep 9, 2019

dyn_specs[1]->data.custom_data.custom_name appears to be 0xffffffff00000050 in mono_method_get_marshal_info, which is presumably the source of the crash. Will investigate fully next sprint.

monojenkins added a commit that referenced this issue Oct 4, 2019
…tom types (#17189)

[2019-08] [reflection] Only duplicate MonoMarshalSpec strings for custom types

Fixes #16570

We were treating the union as though it was a different type than it really is, and so we got junk data for the pointers and attempting to access them caused a crash.

Also fixed a typo seen along the way.

Backport of #17175.

/cc @lambdageek @CoffeeFlux
jonpryor added a commit to jonpryor/xamarin-android that referenced this issue Oct 10, 2019
Changes: mono/mono@5281037...7dbad3c

Context: mono/mono#7377
Context: mono/mono#16570
Context: mono/mono#17004
Context: mono/mono#17151
Context: mono/mono#17180

  * mono/mono@7dbad3c: [arm] Fix fetching of method addresses (#17253)
  * mono/mono@9a88a36: [sgen] Fix invalid value passed to write barrier (#17247)
  * mono/mono@0f241c9: [2019-08] Add drawing type converters to mobile profiles (#17240)
  * mono/mono@7ebe1a1: Update Roslyn to 3.4.0-beta2-19477-01
  * mono/mono@b759449: Bump msbuild to track mono-2019-08
  * mono/mono@617f399: [IO] Remove read-only logic in mono_w32_get_disk_free_space (#17211)
  * mono/mono@77258ea: [2019-08] [debugger][exception] Debugger breaks on handled exceptions (#17202)
  * mono/mono@f83c321: Bump msbuild to track mono-2019-08 (#17193)
  * mono/mono@1ecd094: [2019-08] [Mono.Debugger.Soft] Fix VirtualMachine detaching (#17077)
  * mono/mono@54a33be: [merp] Put thread into async context before running summarizer (#17197)
  * mono/mono@72128bb: Bump libgdiplus to 6.0.4
  * mono/mono@65a972c: Always do copy_stack_data on entering GC safe/unsafe mode. (#17184)
  * mono/mono@9e6def1: [merp] exit_status is 0 if we ran the uploader successfully (#17187)
  * mono/mono@8a707cc: [2019-08] [reflection] Only duplicate MonoMarshalSpec strings for custom types (#17189)
  * mono/mono@bd72952: [2019-08] [merp] Don't overrun buffer in copy_summary_string_safe … (#17178)
  * mono/mono@b6efc0c: Bump msbuild to track xplat-master (#17132)
  * mono/mono@2869cd5: Bump ikvm to get mono/ikvm-fork#13 (#17170)
  * mono/mono@a64a256: [2019-08] [merp] Use macOS version not Darwin version in MERP reports (#17147)
  * mono/mono@57f0684: [2019-08] [merp] Add API method that whitelists all native libraries (#17128)
jonpryor added a commit to jonpryor/xamarin-android that referenced this issue Oct 11, 2019
Changes: mono/mono@5281037...df5e13f

Context: mono/mono#7377
Context: mono/mono#16570
Context: mono/mono#17004
Context: mono/mono#17151
Context: mono/mono#17180

  * mono/mono@df5e13f: [tests] Bump corefx to get Azure testhost change (#17275)
  * mono/mono@11e1499: [2019-08] [merp] Print missing status marker file for stage 1 (setup) (#17220)
  * mono/mono@7dbad3c: [arm] Fix fetching of method addresses (#17253)
  * mono/mono@9a88a36: [sgen] Fix invalid value passed to write barrier (#17247)
  * mono/mono@0f241c9: [2019-08] Add drawing type converters to mobile profiles (#17240)
  * mono/mono@7ebe1a1: Update Roslyn to 3.4.0-beta2-19477-01
  * mono/mono@b759449: Bump msbuild to track mono-2019-08
  * mono/mono@617f399: [IO] Remove read-only logic in mono_w32_get_disk_free_space (#17211)
  * mono/mono@77258ea: [2019-08] [debugger][exception] Debugger breaks on handled exceptions (#17202)
  * mono/mono@f83c321: Bump msbuild to track mono-2019-08 (#17193)
  * mono/mono@1ecd094: [2019-08] [Mono.Debugger.Soft] Fix VirtualMachine detaching (#17077)
  * mono/mono@54a33be: [merp] Put thread into async context before running summarizer (#17197)
  * mono/mono@72128bb: Bump libgdiplus to 6.0.4
  * mono/mono@65a972c: Always do copy_stack_data on entering GC safe/unsafe mode. (#17184)
  * mono/mono@9e6def1: [merp] exit_status is 0 if we ran the uploader successfully (#17187)
  * mono/mono@8a707cc: [2019-08] [reflection] Only duplicate MonoMarshalSpec strings for custom types (#17189)
  * mono/mono@bd72952: [2019-08] [merp] Don't overrun buffer in copy_summary_string_safe … (#17178)
  * mono/mono@b6efc0c: Bump msbuild to track xplat-master (#17132)
  * mono/mono@2869cd5: Bump ikvm to get mono/ikvm-fork#13 (#17170)
  * mono/mono@a64a256: [2019-08] [merp] Use macOS version not Darwin version in MERP reports (#17147)
  * mono/mono@57f0684: [2019-08] [merp] Add API method that whitelists all native libraries (#17128)
jonpryor added a commit to jonpryor/xamarin-android that referenced this issue Oct 16, 2019
Changes: mono/mono@5281037...df5e13f

Context: mono/mono#7377
Context: mono/mono#16570
Context: mono/mono#17004
Context: mono/mono#17151
Context: mono/mono#17180

  * mono/mono@df5e13f: [tests] Bump corefx to get Azure testhost change (#17275)
  * mono/mono@11e1499: [2019-08] [merp] Print missing status marker file for stage 1 (setup) (#17220)
  * mono/mono@7dbad3c: [arm] Fix fetching of method addresses (#17253)
  * mono/mono@9a88a36: [sgen] Fix invalid value passed to write barrier (#17247)
  * mono/mono@0f241c9: [2019-08] Add drawing type converters to mobile profiles (#17240)
  * mono/mono@7ebe1a1: Update Roslyn to 3.4.0-beta2-19477-01
  * mono/mono@b759449: Bump msbuild to track mono-2019-08
  * mono/mono@617f399: [IO] Remove read-only logic in mono_w32_get_disk_free_space (#17211)
  * mono/mono@77258ea: [2019-08] [debugger][exception] Debugger breaks on handled exceptions (#17202)
  * mono/mono@f83c321: Bump msbuild to track mono-2019-08 (#17193)
  * mono/mono@1ecd094: [2019-08] [Mono.Debugger.Soft] Fix VirtualMachine detaching (#17077)
  * mono/mono@54a33be: [merp] Put thread into async context before running summarizer (#17197)
  * mono/mono@72128bb: Bump libgdiplus to 6.0.4
  * mono/mono@65a972c: Always do copy_stack_data on entering GC safe/unsafe mode. (#17184)
  * mono/mono@9e6def1: [merp] exit_status is 0 if we ran the uploader successfully (#17187)
  * mono/mono@8a707cc: [2019-08] [reflection] Only duplicate MonoMarshalSpec strings for custom types (#17189)
  * mono/mono@bd72952: [2019-08] [merp] Don't overrun buffer in copy_summary_string_safe … (#17178)
  * mono/mono@b6efc0c: Bump msbuild to track xplat-master (#17132)
  * mono/mono@2869cd5: Bump ikvm to get mono/ikvm-fork#13 (#17170)
  * mono/mono@a64a256: [2019-08] [merp] Use macOS version not Darwin version in MERP reports (#17147)
  * mono/mono@57f0684: [2019-08] [merp] Add API method that whitelists all native libraries (#17128)
jonpryor added a commit to jonpryor/xamarin-android that referenced this issue Oct 16, 2019
Changes: mono/mono@5281037...3eb5f34

Fixes: xamarin#3726

Context: mono/mono@0f241c9
Context: mono/mono#7377
Context: mono/mono#16570
Context: mono/mono#17004
Context: mono/mono#17151
Context: mono/mono#17180

  * mono/mono@3eb5f34: [GTK] Bump bockbuild for GtkViewport autoscrolling patch. (#17321)
  * mono/mono@b601371: Update MERP event type to MonoAppCrash
  * mono/mono@6184ff0: [2019-08][ci] Use Xcode11.1 and 11.2beta2 for XI/XM Mono SDK builds (#17324)
  * mono/mono@8969f2c: [2019-08] [merp] Include any managed methods in the 'unmanaged_frames' portion (#17316)
  * mono/mono@3009440: [2019-08][merp] Don't install SIGTERM handler in EnableMicrosoftTelemetry (#17308)
  * mono/mono@df5e13f: [tests] Bump corefx to get Azure testhost change (#17275)
  * mono/mono@11e1499: [2019-08] [merp] Print missing status marker file for stage 1 (setup) (#17220)
  * mono/mono@7dbad3c: [arm] Fix fetching of method addresses (#17253)
  * mono/mono@9a88a36: [sgen] Fix invalid value passed to write barrier (#17247)
  * mono/mono@0f241c9: [2019-08] Add drawing type converters to mobile profiles (#17240)
  * mono/mono@7ebe1a1: Update Roslyn to 3.4.0-beta2-19477-01
  * mono/mono@b759449: Bump msbuild to track mono-2019-08
  * mono/mono@617f399: [IO] Remove read-only logic in mono_w32_get_disk_free_space (#17211)
  * mono/mono@77258ea: [2019-08] [debugger][exception] Debugger breaks on handled exceptions (#17202)
  * mono/mono@f83c321: Bump msbuild to track mono-2019-08 (#17193)
  * mono/mono@1ecd094: [2019-08] [Mono.Debugger.Soft] Fix VirtualMachine detaching (#17077)
  * mono/mono@54a33be: [merp] Put thread into async context before running summarizer (#17197)
  * mono/mono@72128bb: Bump libgdiplus to 6.0.4
  * mono/mono@65a972c: Always do copy_stack_data on entering GC safe/unsafe mode. (#17184)
  * mono/mono@9e6def1: [merp] exit_status is 0 if we ran the uploader successfully (#17187)
  * mono/mono@8a707cc: [2019-08] [reflection] Only duplicate MonoMarshalSpec strings for custom types (#17189)
  * mono/mono@bd72952: [2019-08] [merp] Don't overrun buffer in copy_summary_string_safe … (#17178)
  * mono/mono@b6efc0c: Bump msbuild to track xplat-master (#17132)
  * mono/mono@2869cd5: Bump ikvm to get mono/ikvm-fork#13 (#17170)
  * mono/mono@a64a256: [2019-08] [merp] Use macOS version not Darwin version in MERP reports (#17147)
  * mono/mono@57f0684: [2019-08] [merp] Add API method that whitelists all native libraries (#17128)
jonpryor added a commit to xamarin/xamarin-android that referenced this issue Oct 16, 2019
Changes: https://github.com/mono/mono/compare/528103728fc2aedb7b6062e11255d39a0ed3f31c... df5e13f95df7a2d11d86904e74b1bd8950c9d43b

Fixes: #3726

Context: mono/mono@0f241c9
Context: mono/mono#7377
Context: mono/mono#16570
Context: mono/mono#17004
Context: mono/mono#17151
Context: mono/mono#17180

  * mono/mono@df5e13f: [tests] Bump corefx to get Azure testhost change (#17275)
  * mono/mono@11e1499: [2019-08] [merp] Print missing status marker file for stage 1 (setup) (#17220)
  * mono/mono@7dbad3c: [arm] Fix fetching of method addresses (#17253)
  * mono/mono@9a88a36: [sgen] Fix invalid value passed to write barrier (#17247)
  * mono/mono@0f241c9: [2019-08] Add drawing type converters to mobile profiles (#17240)
  * mono/mono@7ebe1a1: Update Roslyn to 3.4.0-beta2-19477-01
  * mono/mono@b759449: Bump msbuild to track mono-2019-08
  * mono/mono@617f399: [IO] Remove read-only logic in mono_w32_get_disk_free_space (#17211)
  * mono/mono@77258ea: [2019-08] [debugger][exception] Debugger breaks on handled exceptions (#17202)
  * mono/mono@f83c321: Bump msbuild to track mono-2019-08 (#17193)
  * mono/mono@1ecd094: [2019-08] [Mono.Debugger.Soft] Fix VirtualMachine detaching (#17077)
  * mono/mono@54a33be: [merp] Put thread into async context before running summarizer (#17197)
  * mono/mono@72128bb: Bump libgdiplus to 6.0.4
  * mono/mono@65a972c: Always do copy_stack_data on entering GC safe/unsafe mode. (#17184)
  * mono/mono@9e6def1: [merp] exit_status is 0 if we ran the uploader successfully (#17187)
  * mono/mono@8a707cc: [2019-08] [reflection] Only duplicate MonoMarshalSpec strings for custom types (#17189)
  * mono/mono@bd72952: [2019-08] [merp] Don't overrun buffer in copy_summary_string_safe … (#17178)
  * mono/mono@b6efc0c: Bump msbuild to track xplat-master (#17132)
  * mono/mono@2869cd5: Bump ikvm to get mono/ikvm-fork#13 (#17170)
  * mono/mono@a64a256: [2019-08] [merp] Use macOS version not Darwin version in MERP reports (#17147)
  * mono/mono@57f0684: [2019-08] [merp] Add API method that whitelists all native libraries (#17128)
jonpryor added a commit to xamarin/xamarin-android that referenced this issue Oct 17, 2019
Changes: mono/mono@5281037...3eb5f34

Fixes: #3726

Context: mono/mono@0f241c9
Context: mono/mono#7377
Context: mono/mono#16570
Context: mono/mono#17004
Context: mono/mono#17151
Context: mono/mono#17180

  * mono/mono@3eb5f34: [GTK] Bump bockbuild for GtkViewport autoscrolling patch. (#17321)
  * mono/mono@b601371: Update MERP event type to MonoAppCrash
  * mono/mono@6184ff0: [2019-08][ci] Use Xcode11.1 and 11.2beta2 for XI/XM Mono SDK builds (#17324)
  * mono/mono@8969f2c: [2019-08] [merp] Include any managed methods in the 'unmanaged_frames' portion (#17316)
  * mono/mono@3009440: [2019-08][merp] Don't install SIGTERM handler in EnableMicrosoftTelemetry (#17308)
  * mono/mono@df5e13f: [tests] Bump corefx to get Azure testhost change (#17275)
  * mono/mono@11e1499: [2019-08] [merp] Print missing status marker file for stage 1 (setup) (#17220)
  * mono/mono@7dbad3c: [arm] Fix fetching of method addresses (#17253)
  * mono/mono@9a88a36: [sgen] Fix invalid value passed to write barrier (#17247)
  * mono/mono@0f241c9: [2019-08] Add drawing type converters to mobile profiles (#17240)
  * mono/mono@7ebe1a1: Update Roslyn to 3.4.0-beta2-19477-01
  * mono/mono@b759449: Bump msbuild to track mono-2019-08
  * mono/mono@617f399: [IO] Remove read-only logic in mono_w32_get_disk_free_space (#17211)
  * mono/mono@77258ea: [2019-08] [debugger][exception] Debugger breaks on handled exceptions (#17202)
  * mono/mono@f83c321: Bump msbuild to track mono-2019-08 (#17193)
  * mono/mono@1ecd094: [2019-08] [Mono.Debugger.Soft] Fix VirtualMachine detaching (#17077)
  * mono/mono@54a33be: [merp] Put thread into async context before running summarizer (#17197)
  * mono/mono@72128bb: Bump libgdiplus to 6.0.4
  * mono/mono@65a972c: Always do copy_stack_data on entering GC safe/unsafe mode. (#17184)
  * mono/mono@9e6def1: [merp] exit_status is 0 if we ran the uploader successfully (#17187)
  * mono/mono@8a707cc: [2019-08] [reflection] Only duplicate MonoMarshalSpec strings for custom types (#17189)
  * mono/mono@bd72952: [2019-08] [merp] Don't overrun buffer in copy_summary_string_safe … (#17178)
  * mono/mono@b6efc0c: Bump msbuild to track xplat-master (#17132)
  * mono/mono@2869cd5: Bump ikvm to get mono/ikvm-fork#13 (#17170)
  * mono/mono@a64a256: [2019-08] [merp] Use macOS version not Darwin version in MERP reports (#17147)
  * mono/mono@57f0684: [2019-08] [merp] Add API method that whitelists all native libraries (#17128)
jonpryor added a commit to xamarin/xamarin-android that referenced this issue Dec 3, 2019
Changes: mono/api-snapshot@fc50bc4...45a61d9

        $ git diff --shortstat fc50bc4f...45a61d93
         22 files changed, 775 insertions(+), 474 deletions(-)

Changes: mono/cecil@a6c8f5e...a6a7f5c

        $ git diff --shortstat a6c8f5e1...a6a7f5c0
         55 files changed, 818 insertions(+), 530 deletions(-)

Changes: mono/corefx@1f87de3...49f1c45

        $ git diff --shortstat e4f7102b...49f1c453
         38 files changed, 1171 insertions(+), 419 deletions(-)

Changes: mono/linker@ebe2a1f...e8d054b

        $ git diff --shortstat ebe2a1f4...e8d054bf
         137 files changed, 5360 insertions(+), 1781 deletions(-)

Changes: mono/mono@8946e49...18920a8

        $ git diff --shortstat 8946e49a...18920a83
         1811 files changed, 47240 insertions(+), 48331 deletions(-)

Changes: xamarin/xamarin-android-api-compatibility@a61271e...50a3c52

        $ git diff --shortstat a61271e0...50a3c52d
         1 file changed, 2 insertions(+), 791 deletions(-)

Fixes: #3619

Context: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1005448
Context: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/967582
Context: dotnet/coreclr#26370
Context: dotnet/coreclr#26479
Context: dotnet/corefx#40455
Context: dotnet/corefx#40578
Context: mono/mono#7377
Context: mono/mono#12421
Context: mono/mono#12586
Context: mono/mono#14080
Context: mono/mono#14725
Context: mono/mono#14772
Context: mono/mono#15261
Context: mono/mono#15262
Context: mono/mono#15263
Context: mono/mono#15307
Context: mono/mono#15308
Context: mono/mono#15310
Context: mono/mono#15646
Context: mono/mono#15687
Context: mono/mono#15805
Context: mono/mono#15992
Context: mono/mono#15994
Context: mono/mono#15999
Context: mono/mono#16032
Context: mono/mono#16034
Context: mono/mono#16046
Context: mono/mono#16192
Context: mono/mono#16308
Context: mono/mono#16310
Context: mono/mono#16369
Context: mono/mono#16380
Context: mono/mono#16381
Context: mono/mono#16395
Context: mono/mono#16411
Context: mono/mono#16415
Context: mono/mono#16486
Context: mono/mono#16570
Context: mono/mono#16605
Context: mono/mono#16616
Context: mono/mono#16689
Context: mono/mono#16701
Context: mono/mono#16712
Context: mono/mono#16742
Context: mono/mono#16759
Context: mono/mono#16803
Context: mono/mono#16808
Context: mono/mono#16824
Context: mono/mono#16876
Context: mono/mono#16879
Context: mono/mono#16918
Context: mono/mono#16943
Context: mono/mono#16950
Context: mono/mono#16974
Context: mono/mono#17004
Context: mono/mono#17017
Context: mono/mono#17038
Context: mono/mono#17040
Context: mono/mono#17083
Context: mono/mono#17084
Context: mono/mono#17133
Context: mono/mono#17139
Context: mono/mono#17151
Context: mono/mono#17180
Context: mono/mono#17278
Context: mono/mono#17549
Context: mono/mono#17569
Context: mono/mono#17665
Context: mono/mono#17687
Context: mono/mono#17737
Context: mono/mono#17790
Context: mono/mono#17924
Context: mono/mono#17931
Context: https://github.com/mono/mono/issues/26758
Context: https://github.com/mono/mono/issues/37913
Context: xamarin/xamarin-macios#7005
jonpryor added a commit to xamarin/xamarin-android that referenced this issue Dec 3, 2019
Changes: mono/api-snapshot@fc50bc4...45a61d9

        $ git diff --shortstat fc50bc4f...45a61d93
         22 files changed, 775 insertions(+), 474 deletions(-)

Changes: mono/cecil@a6c8f5e...a6a7f5c

        $ git diff --shortstat a6c8f5e1...a6a7f5c0
         55 files changed, 818 insertions(+), 530 deletions(-)

Changes: mono/corefx@1f87de3...49f1c45

        $ git diff --shortstat e4f7102b...49f1c453
         38 files changed, 1171 insertions(+), 419 deletions(-)

Changes: mono/linker@ebe2a1f...e8d054b

        $ git diff --shortstat ebe2a1f4...e8d054bf
         137 files changed, 5360 insertions(+), 1781 deletions(-)

Changes: mono/mono@8946e49...18920a8

        $ git diff --shortstat 8946e49a...18920a83
         1811 files changed, 47240 insertions(+), 48331 deletions(-)

Changes: xamarin/xamarin-android-api-compatibility@a61271e...50a3c52

        $ git diff --shortstat a61271e0...50a3c52d
         1 file changed, 2 insertions(+), 791 deletions(-)

Fixes: #3619

Context: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1005448
Context: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/967582
Context: dotnet/coreclr#26370
Context: dotnet/coreclr#26479
Context: dotnet/corefx#40455
Context: dotnet/corefx#40578
Context: mono/mono#7377
Context: mono/mono#12421
Context: mono/mono#12586
Context: mono/mono#14080
Context: mono/mono#14725
Context: mono/mono#14772
Context: mono/mono#15261
Context: mono/mono#15262
Context: mono/mono#15263
Context: mono/mono#15307
Context: mono/mono#15308
Context: mono/mono#15310
Context: mono/mono#15646
Context: mono/mono#15687
Context: mono/mono#15805
Context: mono/mono#15992
Context: mono/mono#15994
Context: mono/mono#15999
Context: mono/mono#16032
Context: mono/mono#16034
Context: mono/mono#16046
Context: mono/mono#16192
Context: mono/mono#16308
Context: mono/mono#16310
Context: mono/mono#16369
Context: mono/mono#16380
Context: mono/mono#16381
Context: mono/mono#16395
Context: mono/mono#16411
Context: mono/mono#16415
Context: mono/mono#16486
Context: mono/mono#16570
Context: mono/mono#16605
Context: mono/mono#16616
Context: mono/mono#16689
Context: mono/mono#16701
Context: mono/mono#16712
Context: mono/mono#16742
Context: mono/mono#16759
Context: mono/mono#16803
Context: mono/mono#16808
Context: mono/mono#16824
Context: mono/mono#16876
Context: mono/mono#16879
Context: mono/mono#16918
Context: mono/mono#16943
Context: mono/mono#16950
Context: mono/mono#16974
Context: mono/mono#17004
Context: mono/mono#17017
Context: mono/mono#17038
Context: mono/mono#17040
Context: mono/mono#17083
Context: mono/mono#17084
Context: mono/mono#17133
Context: mono/mono#17139
Context: mono/mono#17151
Context: mono/mono#17180
Context: mono/mono#17278
Context: mono/mono#17549
Context: mono/mono#17569
Context: mono/mono#17665
Context: mono/mono#17687
Context: mono/mono#17737
Context: mono/mono#17790
Context: mono/mono#17924
Context: mono/mono#17931
Context: https://github.com/mono/mono/issues/26758
Context: https://github.com/mono/mono/issues/37913
Context: xamarin/xamarin-macios#7005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.