[netcore] Improve Jitdiff tool #17960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorBo
requested review from
akoeplinger,
marek-safar,
steveisok and
vargaz
as code owners
akoeplinger
approved these changes
Nov 29, 2019
jaykrell
reviewed
Nov 29, 2019
| @@ -116,7 +117,7 @@ static bool TryParseFunctionName (string str, out string name) | |||
| // depends on objdump, let's use the whole line as a name if it ends with `:` | |||
| if (str.EndsWith (':')) | |||
| { | |||
| name = str; | |||
| name = Regex.Replace(str, @"(?i)\b([a-f0-9]+){8,16}\b", m => "0xD1FFAB1E"); | |||
There was a problem hiding this comment.
Maybe just replace with empty?
There was a problem hiding this comment.
Yeah we can, I just copied the coreclr's jitutills behavior (they replace all addresses with this const)
ManickaP
pushed a commit
to ManickaP/runtime
that referenced
this pull request
Jan 20, 2020
use `objdump` arguments to reduce verbosity (no raw bytes, etc) and make the dasm more diff-friendly. On Linux all functions have a random prefix (address) - replace it with `0xD1FFAB1E` constant). On macOS it's fine by default. Also, allow to generate diffs for a single assembly via `dump-asm-lib` rule. Commit migrated from mono/mono@9a18b6f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
objdumparguments to reduce verbosity (no raw bytes, etc) and make the dasm more diff-friendly.On Linux all functions have a random prefix (address) - replace it with
0xD1FFAB1Econstant). On macOS it's fine by default.Also, allow to generate diffs for a single assembly via
dump-asm-librule.