/mono

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread objects are being leaked #6169

Closed
Therzok opened this Issue Dec 6, 2017 · 4 comments

Comments

Assignees

@luhenry luhenry

Labels
Projects
None yet
Milestone
No milestone
3 participants
@Therzok @luhenry @alexrp
@Therzok
Member

Therzok commented Dec 6, 2017

Starting a bg thread with new Thread() and starting it with either a parameter or not causes the code to leak the start method (and, if applicable, the start arguments).

The retention path for the parametrized start is GCHandle -> InternalThread -> Thread -> ParametrizedThreadStart -> ThreadHelper -> <thread start parameter object> .

The threads are definitely collectible and leaking, as Thread.Join() successfully passes.
@Therzok

This comment has been minimized.

Sign in to view
Member

Therzok commented Dec 6, 2017 •
edited

Sample app:
https://gist.github.com/Therzok/ce0dc57b27343019a7b3782ed0cbf9b1

Results on platforms (note the different on where Program Termination is written):
https://gist.github.com/Therzok/1f03a14ea0641485e4b108253f7fb334

Seems like mono finalizes my object on program termination, rather than thread termination.

@marek-safar marek-safar assigned luhenry Dec 6, 2017

@Therzok

This comment has been minimized.

Sign in to view
Member

Therzok commented Dec 6, 2017

Reproduced in:
Mono JIT compiler version 5.9.0.578 (pull-request-6144/0dd90205c29 Sat Dec 2 10:51:55 EST 2017)
Mono JIT compiler version 5.8.0.89 (2017-10/b3b0613ad38 Tue Nov 28 12:18:29 EST 2017)

@alexrp alexrp added the area-Runtime: Threading label Dec 6, 2017

luhenry added a commit to luhenry/mono that referenced this issue Dec 8, 2017

@luhenry
[threads] Fix leak of gchandle to MonoInternalThread 
Fixes mono#6169
fb679cd

@luhenry luhenry referenced this issue Dec 8, 2017

Merged

[threads] Fix leak of gchandle to MonoInternalThread #6203

luhenry added a commit to luhenry/mono that referenced this issue Dec 8, 2017

@luhenry
[threads] Fix leak of gchandle to MonoInternalThread 
Fixes mono#6169
5021bee
@Therzok

This comment has been minimized.

Sign in to view
Member

Therzok commented Dec 9, 2017 •
edited

This works fine on stable (5.4).

luhenry added a commit to luhenry/mono that referenced this issue Dec 11, 2017

@luhenry
[threads] Fix leak of gchandle to MonoInternalThread 
Fixes mono#6169
d3f3dd1
@luhenry

This comment has been minimized.

Sign in to view
Member

luhenry commented Dec 11, 2017

The regression has been introduced with a08574b

luhenry added a commit to luhenry/mono that referenced this issue Dec 12, 2017

@luhenry
[threads] Fix leak of gchandle to MonoInternalThread 
Fixes mono#6169
1e3fb99

@kumpera kumpera closed this in #6203 Dec 13, 2017

luhenry added a commit to luhenry/mono that referenced this issue Dec 15, 2017

@luhenry
[threads] Fix leak of gchandle to MonoInternalThread 
Fixes mono#6169
ece9c4f

@luhenry luhenry referenced this issue Dec 15, 2017

Merged

[threads] Fix leak of gchandle to MonoInternalThread #6258

luhenry added a commit to luhenry/mono that referenced this issue Dec 17, 2017

@luhenry
[threads] Fix leak of gchandle to MonoInternalThread 
Fixes mono#6169
8635284

luhenry added a commit to luhenry/mono that referenced this issue Dec 17, 2017

@luhenry
[threads] Fix leak of gchandle to MonoInternalThread 
Fixes mono#6169
9224a18

@luhenry luhenry referenced this issue Dec 17, 2017

Merged

[threads] Fix leak of gchandle to MonoInternalThread #6269

luhenry added a commit that referenced this issue Dec 17, 2017

@luhenry
[threads] Fix leak of gchandle to MonoInternalThread (#6258) 
Fixes #6169
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
ce89e4c

marek-safar added a commit that referenced this issue Dec 18, 2017

@luhenry @marek-safar
[threads] Fix leak of gchandle to MonoInternalThread 
Fixes #6169
17f4b42

jonpryor added a commit to jonpryor/xamarin-android that referenced this issue Dec 18, 2017

@jonpryor
Bump to mono/2017-10/ce89e4c5 
Context: mono/mono#6169
8f0eb4d

@jonpryor jonpryor referenced this issue Dec 18, 2017

Merged

Bump to mono/2017-10/ce89e4c5 #1124

jonpryor added a commit to xamarin/xamarin-android that referenced this issue Dec 18, 2017

@jonpryor
Bump to mono/2017-10/ce89e4c5 (#1124) 
Context: mono/mono#6169
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ff71803

luhenry added a commit to luhenry/mono that referenced this issue Apr 3, 2018

@luhenry
[threads] Fix leak of gchandle to MonoInternalThread 
Fixes mono#6169
d2f5139

jonpryor added a commit to xamarin/xamarin-android that referenced this issue Apr 25, 2018

@baulig @jonpryor
Bump to mono/2018-02/0c5a524e (#1289) 
Bumps to Java.Interop/master/0afb2b0f
Bumps to llvm/master/a9cfb50e.

Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=11771
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=15051
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=19436
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=45901
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=56071
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=58413
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=58413
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=58413
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=59184
fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=60065
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=60225
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=60298
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=60359
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=60568
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=60756
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=60848
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=60862
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=60900
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=60904
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=60986
Fixes: https://github.com/mono/mono/issues/59400
Fixes: mono/mono#6169
Fixes: mono/mono#6187
Fixes: mono/mono#6192
Fixes: mono/mono#6255
Fixes: mono/mono#6264
Fixes: mono/mono#6266
Fixes: mono/mono#6281
Fixes: mono/mono#6283
Fixes: mono/mono#6320
Fixes: mono/mono#6339
Fixes: mono/mono#6343
Fixes: mono/mono#6349
Fixes: mono/mono#6379
Fixes: mono/mono#6383
Fixes: mono/mono#6401.
Fixes: mono/mono#6411
Fixes: mono/mono#6414
Fixes: mono/mono#6490
Fixes: mono/mono#6721
Fixes: mono/mono#6767
Fixes: mono/mono#6777
Fixes: mono/mono#6848
Fixes: mono/mono#6940
Fixes: mono/mono#6948
Fixes: mono/mono#6998
Fixes: mono/mono#7016
Fixes: mono/mono#7085
Fixes: mono/mono#7086
Fixes: mono/mono#7095
Fixes: mono/mono#7137
Fixes: mono/mono#7184
Fixes: mono/mono#7240
Fixes: mono/mono#7262
Fixes: mono/mono#7289
Fixes: mono/mono#7338
Fixes: mono/mono#7356
Fixes: mono/mono#7364
Fixes: mono/mono#7378
Fixes: mono/mono#7389
Fixes: mono/mono#7460
Fixes: mono/mono#7535
Fixes: mono/mono#7536
Fixes: mono/mono#7610
Fixes: mono/mono#7624
Fixes: mono/mono#7637
Fixes: mono/mono#7655
Fixes: mono/mono#7657
Fixes: mono/mono#7685
Fixes: mono/mono#7786
Fixes: mono/mono#7792
Fixes: mono/mono#7822
Fixes: mono/mono#7860
Fixes: mono/mono#8089
Fixes: mono/mono#8267
Fixes: mono/mono#8409
Fixes: xamarin/maccore#628
Fixes: xamarin/maccore#629
Fixes: xamarin/maccore#673
Fixes: xamarin/maccore#673
Fixes: #1561
Loading status checks…
166e7d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment