Reenable weak-fields.exe test #6490

luhenry · 2018-01-12T10:09:42Z

Extracted from https://bugzilla.xamarin.com/show_bug.cgi?id=60973

It fails with the following output

Finalized. 0
Finalized. 0
Finalized. 0
Finalized. 16946264

@vargaz noted that it's the test that seems flaky since it doesn't expect the object to be randomly retained.

It was disabled with #6191

The text was updated successfully, but these errors were encountered:

vargaz · 2018-01-12T14:47:31Z

It also fails on osx with aot:
mono --aot weak-fields.exe
mono weak-fields.exe

…_object_alive (), the latter doesn't work for oldspace objects, causing the gc handle to be freed even through the object is still alive. Fixes mono#6490.

vargaz · 2018-01-12T20:05:45Z

This looks like a real bug and not a test failure.

…_object_alive (), the latter doesn't work for oldspace objects, causing the gc handle to be freed even through the object is still alive. Fixes mono#6490.

…_object_alive (), the latter doesn't work for oldspace objects, causing the gc handle to be freed even through the object is still alive. Fixes #6490. (#6501)

…_alive (), the latter doesn't work for oldspace objects, causing the gc handle to be freed even through the object is still alive. Fixes mono#6490.

…_alive (), the latter doesn't work for oldspace objects, causing the gc handle to be freed even through the object is still alive. Fixes #6490.

…_object_alive (), the latter doesn't work for oldspace objects, causing the gc handle to be freed even through the object is still alive. Fixes mono#6490. (mono#6501)

luhenry added disabled-test area-Runtime labels Jan 12, 2018

vargaz mentioned this issue Jan 12, 2018

[sgen] Use sgen_is_object_alive_for_current_gen () instead of sgen_is_object_alive (), the latter doesn't work for oldspace objects, causing the gc handle to be freed even through the object is still alive. #6501

Merged

marek-safar added this to the 2017-12 milestone Jan 15, 2018

vargaz closed this in #6501 Jan 23, 2018

mono / mono

Reenable weak-fields.exe test #6490

Reenable weak-fields.exe test #6490

luhenry commented Jan 12, 2018 •

edited

vargaz commented Jan 12, 2018

vargaz commented Jan 12, 2018

mono / mono

Reenable weak-fields.exe test #6490

Reenable weak-fields.exe test #6490

Comments

luhenry commented Jan 12, 2018 • edited

vargaz commented Jan 12, 2018

vargaz commented Jan 12, 2018

luhenry commented Jan 12, 2018 •

edited