Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make float32 the default setting #6985

Closed
marek-safar opened this Issue Feb 13, 2018 · 2 comments

Comments

@marek-safar
Copy link
Member

marek-safar commented Feb 13, 2018

We think float32 got enough exposure and it’s a better default due to being faster and being more compatible with .NET

It also makes sense to do so as iOS already defaults to it while Android doesn’t.

The x86 port is needed for both since ios and android use it for simulators, and Android uses it for devices as well.

Requires

  • Figure out the breakages with corefx test suite.
  • Introduce float64 to enable the current behavior.

@marek-safar marek-safar added the task label Feb 13, 2018

@marek-safar marek-safar added this to New Issues in Short Term Projects via automation Feb 13, 2018

@marek-safar marek-safar moved this from New Issues to Backlog in Short Term Projects Feb 13, 2018

@luhenry luhenry moved this from Backlog to Icebox in Short Term Projects Feb 15, 2018

@luhenry luhenry assigned vargaz and alexanderkyte and unassigned luhenry Feb 26, 2018

@luhenry luhenry moved this from Icebox to Backlog in Short Term Projects Feb 26, 2018

@migueldeicaza

This comment has been minimized.

Copy link
Member

migueldeicaza commented Apr 4, 2018

Given that the simulators are not supposed to be exact replicas of the hardware, I do not think that we need to complete x86 support for us to proceed with this change.

@vargaz

This comment has been minimized.

Copy link
Member

vargaz commented Apr 15, 2018

Fixed in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.