Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isinst for unused array type fails #9507

Closed
vargaz opened this issue Jul 12, 2018 · 0 comments
Assignees
Projects

Comments

@vargaz
Copy link
Member

@vargaz vargaz commented Jul 12, 2018

Steps to Reproduce

Run this:

using System;

public struct TestTableScalarSse2<T>
{
        public T[] inArray1;

        public TestTableScalarSse2(int i) {
            inArray1 = new T[16];

			if (inArray1 is double[])
				Console.WriteLine ("OK.");
		}
}

public class Tests
{
	public static void Main () {
		var table = new TestTableScalarSse2<ulong> (1);
	}
}

Current Behavior

Unhandled Exception:
System.NullReferenceException: Object reference not set to an instance of an object
  at TestTableScalarSse2`1[T]..ctor (System.Int32 i) [0x0000e] in <0d150afdf55c4bb6b6168c448b599f2c>:0 
  at Tests.Main () [0x00001] in <0d150afdf55c4bb6b6168c448b599f2c>:0 

Expected Behavior

On which platforms did you notice this

[x ] macOS
[ ] Linux
[ ] Windows

Version Used:
Master/5.12

This seems to happen because using the double[] type in code doesn't seem to initialize the Double class anymore, i.e. mono_class_init () is not called on it.

@vargaz vargaz added the area-Runtime label Jul 12, 2018
@marek-safar marek-safar added this to Bugs Pool in Bugs Week via automation Jul 12, 2018
@alexischr alexischr self-assigned this Sep 13, 2018
@alexischr alexischr moved this from Bugs Pool to In Progress in Bugs Week Sep 13, 2018
alexischr added a commit to alexischr/mono that referenced this issue Sep 18, 2018
…that uses it. Fixes mono#9507. Credit to @vargaz for both bug reproduction and the fix.
alexischr added a commit to alexischr/mono that referenced this issue Sep 18, 2018
…that uses it. Fixes mono#9507. Credit to @vargaz for both bug reproduction and the fix.
alexischr added a commit to alexischr/mono that referenced this issue Sep 18, 2018
…that uses it. Fixes mono#9507. Credit to @vargaz for both bug reproduction and the fix.
alexischr added a commit to alexischr/mono that referenced this issue Oct 17, 2018
…that uses it. Fixes mono#9507. Credit to @vargaz for both bug reproduction and the fix.
alexischr added a commit to alexischr/mono that referenced this issue Oct 17, 2018
…that uses it. Fixes mono#9507. Credit to @vargaz for both bug reproduction and the fix.
alexischr added a commit to alexischr/mono that referenced this issue Oct 17, 2018
alexischr added a commit to alexischr/mono that referenced this issue Oct 17, 2018
alexischr added a commit to alexischr/mono that referenced this issue Oct 17, 2018
alexischr added a commit to alexischr/mono that referenced this issue Oct 17, 2018
alexischr added a commit to alexischr/mono that referenced this issue Oct 17, 2018
alexischr added a commit to alexischr/mono that referenced this issue Oct 17, 2018
alexischr added a commit to alexischr/mono that referenced this issue Oct 19, 2018
alexischr added a commit to alexischr/mono that referenced this issue Oct 19, 2018
… a generic class.

Fixes mono#9507

Background: Monoclass:cast_class is used internally to allow for some interfaces to be assignable to each other if they share a "storage class" instead of the class's element class. This is used to i.e. implement IList<ulong> being assignable from IList<long> (IList<ulong> has cast_class=long)

Consider a GenericClass<T> with a T[] field. On instantiation with e.g. GenericClass<ulong> , the ulong[] array class will be generated. As above, ulong[] has cast_class=long
When mono_class_init() is called on an array class, its element_class is also initialized.
If GenericClass<T>:Method() uses any type/subtype checking (e.g. if (field is double[]) ), those may attempt to use cast_class, which is not ensured as initialized.
alexischr added a commit that referenced this issue Oct 19, 2018
Fixes #9507

Background: Monoclass:cast_class is used internally to allow for some interfaces to be assignable to each other if they share a "storage class" instead of the class's element class. This is used to i.e. implement IList<ulong> being assignable from IList<long> (IList<ulong> has cast_class=long)

Consider a GenericClass<T> with a T[] field. On instantiation with e.g. GenericClass<ulong> , the ulong[] array class will be generated. As above, ulong[] has cast_class=long
When mono_class_init() is called on an array class, its element_class is also initialized.
If GenericClass<T>:Method() uses any type/subtype checking (e.g. if (field is double[]) ), those may attempt to use cast_class, which is not ensured as initialized.
Bugs Week automation moved this from In Progress to Done Oct 22, 2018
alexischr added a commit that referenced this issue Oct 22, 2018
…11268)

* [class] Ensure 'cast_class' is initialized for array type classes.

Fixes #9507

Background: Monoclass:cast_class is used internally to allow for some interfaces to be assignable to each other if they share a "storage class" instead of the class's element class. This is used to i.e. implement IList<ulong> being assignable from IList<long> (IList<ulong> has cast_class=long)

Consider a GenericClass<T> with a T[] field. On instantiation with e.g. GenericClass<ulong> , the ulong[] array class will be generated. As above, ulong[] has cast_class=long
When mono_class_init() is called on an array class, its element_class is also initialized.
If GenericClass<T>:Method() uses any type/subtype checking (e.g. if (field is double[]) ), those may attempt to use cast_class, which is not ensured as initialized.

* Fix typo

Co-Authored-By: alexischr <alexis@thenull.net>
kg added a commit to kg/mono that referenced this issue Oct 23, 2018
…ono#11268)

* [class] Ensure 'cast_class' is initialized for array type classes.

Fixes mono#9507

Background: Monoclass:cast_class is used internally to allow for some interfaces to be assignable to each other if they share a "storage class" instead of the class's element class. This is used to i.e. implement IList<ulong> being assignable from IList<long> (IList<ulong> has cast_class=long)

Consider a GenericClass<T> with a T[] field. On instantiation with e.g. GenericClass<ulong> , the ulong[] array class will be generated. As above, ulong[] has cast_class=long
When mono_class_init() is called on an array class, its element_class is also initialized.
If GenericClass<T>:Method() uses any type/subtype checking (e.g. if (field is double[]) ), those may attempt to use cast_class, which is not ensured as initialized.

* Fix typo

Co-Authored-By: alexischr <alexis@thenull.net>
@marek-safar marek-safar moved this from Done to Archived in Bugs Week Nov 5, 2018
jonpryor added a commit to xamarin/xamarin-android that referenced this issue Apr 24, 2019
Bumps to mono/api-snapshot@ae01378
Bumps to mono/reference-assemblies@e5173a5
Bumps to mono/bockbuild@d30329d
Bumps to mono/boringssl@3d87996
Bumps to mono/corefx@72f7d76
Bumps to mono/corert@1b7d4a1
Bumps to mono/helix-binaries@7e893ea
Bumps to mono/illinker-test-assets@f21ff68
Bumps to mono/linker@13d864e
Bumps to mono/llvm@1aaaaa5 [mono]
Bumps to mono/llvm@2c2cffe [xamarin-android]
Bumps to mono/NUnitLite@0029561
Bumps to mono/roslyn-binaries@0bbc9b4
Bumps to mono/xunit-binaries@8f6e62e

	$ git diff --shortstat 886c4901..e66c7667      # mono
        3597 files changed, 350850 insertions(+), 91128 deletions(-)
	$ git diff --shortstat 349752c464c5fc93b32e7d45825f2890c85c8b7d..2c2cffedf01e0fe266b9aaad2c2563e05b750ff4
	 240 files changed, 18562 insertions(+), 6581 deletions(-)

Context: dotnet/coreclr#22046

Fixes: CVE 2018-8292 on macOS
Fixes: http://work.devdiv.io/737323
Fixes: dotnet/corefx#33965
Fixes: dotnet/standard#642
Fixes: mono/mono#6997
Fixes: mono/mono#7326
Fixes: mono/mono#7517
Fixes: mono/mono#7750
Fixes: mono/mono#7859
Fixes: mono/mono#8360
Fixes: mono/mono#8460
Fixes: mono/mono#8766
Fixes: mono/mono#8922
Fixes: mono/mono#9418
Fixes: mono/mono#9507
Fixes: mono/mono#9951
Fixes: mono/mono#10024
Fixes: mono/mono#10030
Fixes: mono/mono#10038
Fixes: mono/mono#10448
Fixes: mono/mono#10735
Fixes: mono/mono#10735
Fixes: mono/mono#10737
Fixes: mono/mono#10743
Fixes: mono/mono#10834
Fixes: mono/mono#10837
Fixes: mono/mono#10838
Fixes: mono/mono#10863
Fixes: mono/mono#10945
Fixes: mono/mono#11020
Fixes: mono/mono#11021
Fixes: mono/mono#11021
Fixes: mono/mono#11049
Fixes: mono/mono#11091
Fixes: mono/mono#11095
Fixes: mono/mono#11123
Fixes: mono/mono#11138
Fixes: mono/mono#11146
Fixes: mono/mono#11202
Fixes: mono/mono#11214
Fixes: mono/mono#11317
Fixes: mono/mono#11326
Fixes: mono/mono#11378
Fixes: mono/mono#11385
Fixes: mono/mono#11478
Fixes: mono/mono#11479
Fixes: mono/mono#11488
Fixes: mono/mono#11489
Fixes: mono/mono#11527
Fixes: mono/mono#11529
Fixes: mono/mono#11596
Fixes: mono/mono#11603
Fixes: mono/mono#11613
Fixes: mono/mono#11623
Fixes: mono/mono#11663
Fixes: mono/mono#11681
Fixes: mono/mono#11684
Fixes: mono/mono#11693
Fixes: mono/mono#11697
Fixes: mono/mono#11779
Fixes: mono/mono#11809
Fixes: mono/mono#11858
Fixes: mono/mono#11895
Fixes: mono/mono#11898
Fixes: mono/mono#11898
Fixes: mono/mono#11965
Fixes: mono/mono#12182
Fixes: mono/mono#12193
Fixes: mono/mono#12218
Fixes: mono/mono#12235
Fixes: mono/mono#12263
Fixes: mono/mono#12307
Fixes: mono/mono#12331
Fixes: mono/mono#12362
Fixes: mono/mono#12374
Fixes: mono/mono#12402
Fixes: mono/mono#12421
Fixes: mono/mono#12461
Fixes: mono/mono#12479
Fixes: mono/mono#12479
Fixes: mono/mono#12552
Fixes: mono/mono#12603
Fixes: mono/mono#12747
Fixes: mono/mono#12831
Fixes: mono/mono#12843
Fixes: mono/mono#12881
Fixes: mono/mono#13030
Fixes: mono/mono#13284
Fixes: mono/mono#13297
Fixes: mono/mono#13455
Fixes: mono/mono#13460
Fixes: mono/mono#13478
Fixes: mono/mono#13479
Fixes: mono/mono#13522
Fixes: mono/mono#13607
Fixes: mono/mono#13610
Fixes: mono/mono#13610
Fixes: mono/mono#13639
Fixes: mono/mono#13672
Fixes: mono/mono#13834
Fixes: mono/mono#13878
Fixes: mono/mono#6352
Fixes: mono/monodevelop#6898
Fixes: xamarin/maccore#1069
Fixes: xamarin/maccore#1407
Fixes: xamarin/maccore#604
Fixes: xamarin/xamarin-macios#4984
Fixes: xamarin/xamarin-macios#5289
Fixes: xamarin/xamarin-macios#5363
Fixes: xamarin/xamarin-macios#5381
Fixes: https://issuetracker.unity3d.com/issues/editor-crashes-with-g-logv-when-entering-play-mode-with-active-flowcanvas-script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Bugs Week
Archived
3 participants
You can’t perform that action at this time.