Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: 32-bit device unit test failure: [FAIL] FSharpTest.SprintfTest : Expected: True #9870

Closed
rolfbjarne opened this issue Aug 3, 2018 · 5 comments

Comments

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Aug 3, 2018

Steps to Reproduce

  1. Checkout & build the mono-2018-06 branch from xamarin-macios
  2. Open tests/tests.sln
  3. Select the fsharp project as the startup project, and select a Debug32|iPhone configuration (this failure does not happen in 64-bit).
  4. Execute and run all the tests

Current Behavior

[FAIL] FSharpTest.SprintfTest :   Expected: True
    But was:  False
	  at fsharp.FSharpTest.SprintfTest () [0x00052] in /work/maccore/mono-master/xamarin-macios/tests/fsharp/FSharpTests.fs:34 
	  at (wrapper managed-to-native) System.Reflection.MonoMethod.InternalInvoke(System.Reflection.MonoMethod,object,object[],System.Exception&)

improving the test a bit gets me a better assert message:

[FAIL] FSharpTest.SprintfTest :   String lengths are both 24. Strings differ at index 10.
  Expected: "1111 2222 3333 4444 5555"
  But was:  "1111 2222 4444 3333 5555"
  ---------------------^
at fsharp.FSharpTest.SprintfTest () [0x00044] in /work/maccore/mono-master/xamarin-macios/tests/fsharp/FSharpTests.fs:33 
at (wrapper managed-to-native) System.Reflection.MonoMethod.InternalInvoke(System.Reflection.MonoMethod,object,object[],System.Exception&)

Expected Behavior

No test failure.

On which platforms did you notice this

[x] iOS
[ ] macOS
[ ] Linux
[ ] Windows

@vargaz

This comment has been minimized.

Copy link
Member

@vargaz vargaz commented Aug 5, 2018

Did this use to work ?

@vargaz

This comment has been minimized.

Copy link
Member

@vargaz vargaz commented Aug 14, 2018

Which was the last version where this was tested and it succeeded ?

@jaykrell

This comment has been minimized.

Copy link
Collaborator

@jaykrell jaykrell commented Aug 14, 2018

Does this require device or repros in emulator?
Simple desktop/amd64 test passes.

@rolfbjarne

This comment has been minimized.

Copy link
Member Author

@rolfbjarne rolfbjarne commented Aug 17, 2018

@jaykrell it requires an iOS device capable of running 32-bit code

@vargaz it passes in d15-7.

the same thing happens with watchOS on device:

FSharpTest
	[PASS] FSharpTest.Func
	[FAIL] FSharpTest.SprintfTest :   Expected string length 24 but was 32. Strings differ at index 5.
  Expected: "1111 2222 3333 4444 5555"
  But was:  "1111 57822332 2222 57822332 5555"
@vargaz

This comment has been minimized.

Copy link
Member

@vargaz vargaz commented Aug 17, 2018

The PR above will fix it.

monojenkins added a commit to monojenkins/mono that referenced this issue Aug 27, 2018
monojenkins added a commit to monojenkins/mono that referenced this issue Aug 27, 2018
marek-safar added a commit that referenced this issue Aug 28, 2018
@marek-safar marek-safar reopened this Aug 28, 2018
marek-safar added a commit that referenced this issue Aug 28, 2018
@marek-safar marek-safar closed this Sep 6, 2018
EgorBo added a commit to EgorBo/mono that referenced this issue Sep 10, 2018
jonpryor added a commit to xamarin/xamarin-android that referenced this issue Oct 9, 2018
Bumps to mono/llvm:release_60@117a508c
Bumps to xamarin/xamarin-android-api-compatibility:master@7ccb4802

	$ git diff --shortstat e1af6ea..ab3c897d       # mono
        1443 files changed, 66049 insertions(+), 45745 deletions(-)
	$ git diff --shortstat bdb3a116..117a508c      # llvm
	 26794 files changed, 4110589 insertions(+), 754376 deletions(-)
	$ git diff --shortstat c550d1bd..7ccb4802      # xamarin-android-api-compatibility
	 2 files changed, 16260 insertions(+), 12347 deletions(-)

Incomplete summary of easily `grep`able fixes:

Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=11199
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=19436
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=23668
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=26983
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=33728
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=46917
fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=60065
Fixes: mono/mono#6173
Fixes: mono/mono#6466
Fixes: mono/mono#6647
Fixes: mono/mono#6834
Fixes: mono/mono#7058
Fixes: mono/mono#7137
Fixes: mono/mono#7260
Fixes: mono/mono#7305
Fixes: mono/mono#7402
Fixes: mono/mono#7525
Fixes: mono/mono#7610
Fixes: mono/mono#7649
Fixes: mono/mono#7655
Fixes: mono/mono#7683
Fixes: mono/mono#7685
Fixes: mono/mono#7716
Fixes: mono/mono#7731
Fixes: mono/mono#7785
Fixes: mono/mono#7828
Fixes: mono/mono#7944
Fixes: mono/mono#7947
Fixes: mono/mono#8036
Fixes: mono/mono#8074
Fixes: mono/mono#8089
Fixes: mono/mono#8112
Fixes: mono/mono#8122
Fixes: mono/mono#8143
Fixes: mono/mono#8149
Fixes: mono/mono#8152
Fixes: mono/mono#8175
Fixes: mono/mono#8177
Fixes: mono/mono#8250
Fixes: mono/mono#8267
Fixes: mono/mono#8273
Fixes: mono/mono#8282
Fixes: mono/mono#8310
Fixes: mono/mono#8311
Fixes: mono/mono#8329
Fixes: mono/mono#8340
Fixes: mono/mono#8372
Fixes: mono/mono#8407
Fixes: mono/mono#8409
Fixes: mono/mono#8422
Fixes: mono/mono#8430
Fixes: mono/mono#8439
fixes: mono/mono#8447
Fixes: mono/mono#8469
Fixes: mono/mono#8504
Fixes: mono/mono#8575
Fixes: mono/mono#8597
Fixes: mono/mono#8623
Fixes: mono/mono#8627
Fixes: mono/mono#8698
Fixes: mono/mono#8701
Fixes: mono/mono#8712
Fixes: mono/mono#8721
Fixes: mono/mono#8726
Fixes: mono/mono#8759
Fixes: mono/mono#8787
Fixes: mono/mono#8820
Fixes: mono/mono#8848
Fixes: mono/mono#8866
Fixes: mono/mono#8897
Fixes: mono/mono#8915
Fixes: mono/mono#8970
Fixes: mono/mono#8979
Fixes: mono/mono#9023
Fixes: mono/mono#9031
Fixes: mono/mono#9033
Fixes: mono/mono#9179
Fixes: mono/mono#9234
Fixes: mono/mono#9262
Fixes: mono/mono#9277
Fixes: mono/mono#9318
Fixes: mono/mono#9542
Fixes: mono/mono#9753
Fixes: mono/mono#9839
Fixes: mono/mono#9869
Fixes: mono/mono#9870
Fixes: mono/mono#9943
Fixes: mono/mono#9996
Fixes: mono/mono#10000
Fixes: mono/mono#10303
Fixes: mono/mono#10447
Fixes: mono/mono#10483
Fixes: mono/mono#10488
Fixes: xamarin/maccore#628
Fixes: xamarin/maccore#673
Fixes: #1561 (comment)
Fixes: #1845
Fixes: xamarin/xamarin-macios#4347
Fixes: xamarin/xamarin-macios#4617
Fixes: xamarin/xamarin-macios#4618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.