Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[System.ServiceModel] Replace SynchronizedCollection with referencesource #10021

Merged
merged 3 commits into from Aug 10, 2018

Conversation

Projects
None yet
3 participants
@akoeplinger
Copy link
Member

akoeplinger commented Aug 10, 2018

This fixes a bug in the old implementation where we didn't have proper locking in Add().

Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=43447
Closes #10007

[System.ServiceModel] Replace SynchronizedCollection with referenceso…
…urce

This fixes a bug in the old implementation where we didn't have proper
locking in Add().

Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=43447
Closes #10007

@akoeplinger akoeplinger force-pushed the akoeplinger:servicemodel-synchrocollections branch from 71805eb to e6f2764 Aug 10, 2018

@akoeplinger

This comment has been minimized.

Copy link
Member Author

akoeplinger commented Aug 10, 2018

@monojenkins commit apidiff and csproj

monojenkins added a commit to mono/api-snapshot that referenced this pull request Aug 10, 2018

@akoeplinger akoeplinger requested a review from luhenry as a code owner Aug 10, 2018

@akoeplinger akoeplinger merged commit 22c9616 into mono:master Aug 10, 2018

3 of 27 checks passed

Linux AArch64 Build started for merge commit.
Details
Linux AArch64 Coop Suspend Build started for merge commit.
Details
Linux AArch64 FullAOT Build started for merge commit.
Details
Linux AArch64 Interpreter Build started for merge commit.
Details
Linux ARMv5 Build started for merge commit.
Details
Linux ARMv7 Build started for merge commit.
Details
Linux ARMv7 Interpreter Build started for merge commit.
Details
Linux WebAssembly Build started for merge commit.
Details
Linux i386 Build started for merge commit.
Details
Linux x64 Build started for merge commit.
Details
Linux x64 Acceptance Tests Build started for merge commit.
Details
Linux x64 Checked Private Types Build Build started for merge commit.
Details
Linux x64 Coop Suspend Build started for merge commit.
Details
Linux x64 FullAOT Build started for merge commit.
Details
Linux x64 FullAOT+LLVM Build started for merge commit.
Details
Linux x64 Hybrid Suspend Build started for merge commit.
Details
Linux x64 Interpreter Build started for merge commit.
Details
Linux x64 mcs Build started for merge commit.
Details
OS X i386 Build started for merge commit.
Details
OS X x64 Build started for merge commit.
Details
OS X x64 Android SDK Build started for merge commit.
Details
OS X x64 iOS SDK Build triggered for merge commit.
Details
Windows i386 Build triggered for merge commit.
Details
Windows x64 Build triggered for merge commit.
Details
PR Trigger Docs Click to view available PR triggers (Xamarin internal).
Details
Test Result Viewer Click to view aggregated test results (Xamarin internal).
Details
license/cla All CLA requirements met.
Details

@akoeplinger akoeplinger deleted the akoeplinger:servicemodel-synchrocollections branch Aug 10, 2018

jonpryor added a commit to xamarin/xamarin-android-api-compatibility that referenced this pull request Feb 19, 2019

Update assemblies for mono/mono:2018-10@5ee0e28b breakage
Context: xamarin/xamarin-android#2253
Context: https://jenkins.mono-project.com/job/xamarin-android-pr-builder-release/840/API_20Compatibility_20Checks/

The mono/mono@5ee0e28 bump introduces breaking changes across
multiple assemblies.  Time to review and approve these changes. :-)

The `mscorlib.dll` and `System.Core.dll` assemblies removed the
`System.Runtime.InteropServices._MemberInfo` interface type, which we
are [told][0] is OK:

	<h3>Type Changed: System.Type</h3>
	<p>Removed interface:</p>
	<pre>
		<span class='removed removed-interface breaking' data-is-breaking>Runtime.InteropServices._MemberInfo</span>
	</pre>
	<!-- Plus many many others... -->

`System.ServiceModel.dll` was [updated to use referencesource][1]
which caused the remove of undocumented constructors on the
`SynchronizedCollection<T>` and `SynchronizedReadOnlyCollection<T>`
types:

	<h3>Type Changed: System.Collections.Generic.SynchronizedCollection`1</h3>
	<p>Removed constructor:</p>
	<pre>
		<span class='removed removed-constructor breaking' data-is-breaking>public SynchronizedCollection`1 (object, System.Collections.Generic.List&lt;T&gt;, bool);</span>
	</pre>

	<h3>Type Changed: System.Collections.Generic.SynchronizedReadOnlyCollection`1</h3>
	<p>Removed constructor:</p>
	<pre>
		<span class='removed removed-constructor breaking' data-is-breaking>public SynchronizedReadOnlyCollection`1 (object, System.Collections.Generic.List&lt;T&gt;, bool);</span>
	</pre>

The various `System.Drawing` types located within
`Mono.Android.dll` were *moved* into the new
`System.Drawing.Common.dll` facade assembly:

	<h2>Namespace System.Drawing</h2>
	<h3>Removed Type <span class='breaking' data-is-breaking>System.Drawing.Color</span></h3>
	<h3>Removed Type <span class='breaking' data-is-breaking>System.Drawing.ColorConverter</span></h3>
	<h3>Removed Type <span class='breaking' data-is-breaking>System.Drawing.KnownColor</span></h3>
	<h3>Removed Type <span class='breaking' data-is-breaking>System.Drawing.Point</span></h3>
	<h3>Removed Type <span class='breaking' data-is-breaking>System.Drawing.PointF</span></h3>
	<h3>Removed Type <span class='breaking' data-is-breaking>System.Drawing.Rectangle</span></h3>
	<h3>Removed Type <span class='breaking' data-is-breaking>System.Drawing.RectangleF</span></h3>
	<h3>Removed Type <span class='breaking' data-is-breaking>System.Drawing.Size</span></h3>
	<h3>Removed Type <span class='breaking' data-is-breaking>System.Drawing.SizeF</span></h3>
	<h3>Removed Type <span class='breaking' data-is-breaking>System.Drawing.SystemColors</span></h3>

Update and flush the reference API based on mono/mono@5ee0e28
and xamarin/xamarin-android@dad7be9.

[0]: https://xamarinhq.slack.com/archives/C03CEGRUW/p1550259372788900
[1]: mono/mono#10021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.