New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump F# to 4.5 #10919

Open
wants to merge 18 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@nosami
Member

nosami commented Oct 2, 2018

make pkg

@akoeplinger

This comment has been minimized.

Member

akoeplinger commented Oct 2, 2018

@monojenkins build pkg

configure='./configure --prefix="%{package_prefix}"',
override_properties={ 'make': 'make' })
self.extra_stage_files = ['lib/mono/xbuild/Microsoft/VisualStudio/v/FSharp/Microsoft.FSharp.Targets']
self.sources.extend(['patches/fsharp-portable-pdb.patch',
'patches/fsharp-string-switchName.patch',
'patches/fsharp-path-overloads.patch',
'patches/fsharp-debug-pinvoke-fix.patch'])

This comment has been minimized.

@akoeplinger

akoeplinger Oct 2, 2018

Member

@nosami btw do you think we can remove those two remaining patches as well now?

This comment has been minimized.

@nosami

nosami Oct 2, 2018

Member

No. Not yet. I will try and get them upstreamed.

@akoeplinger

This comment has been minimized.

Member

akoeplinger commented Oct 2, 2018

@monojenkins build pkg

1 similar comment
@akoeplinger

This comment has been minimized.

Member

akoeplinger commented Oct 3, 2018

@monojenkins build pkg

@nosami

This comment has been minimized.

Member

nosami commented Oct 3, 2018

@monojenkins build pkg

@nosami

This comment has been minimized.

Member

nosami commented Oct 4, 2018

@monojenkins build pkg

@nosami

This comment has been minimized.

Member

nosami commented Oct 5, 2018

@monojenkins build pkg

Update fsharp.py
Use build-mono.sh script so that `make install` is ran under `sudo`
@nosami

This comment has been minimized.

Member

nosami commented Oct 7, 2018

@monojenkins build pkg

@nosami

This comment has been minimized.

Member

nosami commented Oct 8, 2018

@monojenkins build pkg

@nosami

This comment has been minimized.

Member

nosami commented Oct 8, 2018

@monojenkins build pkg

1 similar comment
@alexischr

This comment has been minimized.

Member

alexischr commented Oct 9, 2018

@monojenkins build pkg

@dsyme

This comment has been minimized.

Contributor

dsyme commented Oct 18, 2018

From discussing with @nosami

  • Most CI builds don't run the make pkg step
  • Actual Mono releases run "make pkg"
  • Mono CI can no longer run "make pkg" successfully

Hence the failures above. We need to dig into this

@dsyme

This comment has been minimized.

Contributor

dsyme commented Oct 18, 2018

@monojenkins build pkg

@dsyme

This comment has been minimized.

Contributor

dsyme commented Oct 18, 2018

@monojenkins build Linux x64 C++
@monojenkins build Linux x64 Interpreter

@akoeplinger

This comment has been minimized.

Member

akoeplinger commented Oct 18, 2018

@dsyme you don't seem to be in the Microsoft/Xamarin/Mono GitHub orgs (at least not publicly) so the GitHub trigger won't work for you.

The failures from the previous build https://jenkins.mono-project.com/job/build-package-osx-mono-pullrequest/246 should still be accurate though since there wasn't another F# bump.

@nosami

This comment has been minimized.

Member

nosami commented Oct 18, 2018

@akoeplinger The errors now seem to be an artifact of previous test runs. The error that we now see is

15:49:58 mkdir: @/external/bockbuild/scratch/fsharp.install@/external/bockbuild/stage/lib/mono/fsharp: Permission denied
15:49:58 
make[1]: *** [install-sdk-lib] Error 1
15:49:58 make: *** [install] Error 2
15:49:58 
15:49:58 fsharp->build_sh:

As far as I can tell, the permission error has been caused by an inadvertent sudo make install from a previous build. I think the bots need manual clean up.

@akoeplinger

This comment has been minimized.

Member

akoeplinger commented Oct 18, 2018

Ok, I cleaned the bots, let's try another build.

@akoeplinger

This comment has been minimized.

Member

akoeplinger commented Oct 18, 2018

@monojenkins build pkg

@nosami

This comment has been minimized.

Member

nosami commented Oct 19, 2018

I am assuming that there is some issue with the Jenkins bots somewhere. The same script builds on Travis.

I don't see sudo being used anywhere apart from sudo make install (which I patched out - It appears that the bots run make install to a custom folder). It's also used for restoring packages when the script is ran on linux.

@dsyme

This comment has been minimized.

Contributor

dsyme commented Oct 19, 2018

Who can add me to those orgs? I should be in xamarin I thought

Can we get direct access to one of these build machines?

@akoeplinger

This comment has been minimized.

Member

akoeplinger commented Oct 19, 2018

@dsyme yeah you are in the org but your membership is set to private (so the bot can't see it). Go to https://github.com/orgs/xamarin/people?utf8=%E2%9C%93&query=dsyme and flip it to "public"

@akoeplinger

This comment has been minimized.

Member

akoeplinger commented Oct 19, 2018

@nosami yes, let's talk on Slack

@alexischr

This comment has been minimized.

Member

alexischr commented Oct 19, 2018

It seemed like more uncleanable files from sudo make install

@alexischr

This comment has been minimized.

Member

alexischr commented Oct 19, 2018

@monojenkins build pkg

1 similar comment
@nosami

This comment has been minimized.

Member

nosami commented Nov 18, 2018

@monojenkins build pkg

@nosami

This comment has been minimized.

Member

nosami commented Nov 19, 2018

@monojenkins build pkg

@nosami

This comment has been minimized.

Member

nosami commented Nov 19, 2018

@monojenkins build pkg

@nosami

This comment has been minimized.

Member

nosami commented Nov 20, 2018

@monojenkins build pkg

@nosami

This comment has been minimized.

Member

nosami commented Nov 20, 2018

@monojenkins build pkg

@nosami

This comment has been minimized.

Member

nosami commented Nov 20, 2018

@monojenkins build pkg

@nosami

This comment has been minimized.

Member

nosami commented Nov 20, 2018

@monojenkins build pkg

Update fsharp-noinstall.patch
make install without sudo
@nosami

This comment has been minimized.

Member

nosami commented Nov 21, 2018

@monojenkins build pkg

@dsyme

This comment has been minimized.

Contributor

dsyme commented Dec 11, 2018

@monojenkins build pkg

@dsyme

This comment has been minimized.

Contributor

dsyme commented Dec 11, 2018

Notes to self....

Prior to this PR we did this:

        self.sh('autoreconf') 
        Package.configure(self)
        Package.make(self)

I'm told that the last two lines are just configure && make though we should double check this.

After this PR we do this:

        self.sh('./mono/build-mono.sh')

Which contains this:

make && make install

after patching. Prior to patching this was:

 ./mono/prepare-mono.sh && \
make && \
sudo make install
@dsyme

This comment has been minimized.

Contributor

dsyme commented Dec 11, 2018

I have created a no-op PR so we can get a bockbuild baseline for this to understand why the change to the F# build process is problematic #12018

dsyme added some commits Dec 11, 2018

@dsyme

This comment has been minimized.

Contributor

dsyme commented Dec 11, 2018

@monojenkins build pkg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment