New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct duplicate X509CertificateValidationMode definition error #1240

Merged
merged 1 commit into from Aug 29, 2014

Conversation

Projects
None yet
3 participants
@RyanMelenaNoesis
Contributor

RyanMelenaNoesis commented Aug 29, 2014

Correct duplicate X509CertificateValidationMode definition error caused by enum changing assemblies between .NET 4.0 and 4.5 (introduced in previous pull request https://github.com/mono/mono/pull/1236/files)

Correct duplicate X509CertificateValidationMode definition error caus…
…ed by enum changing assemblies between .NET 4.0 and 4.5.
@monoadmin

This comment has been minimized.

Show comment
Hide comment
@monoadmin

monoadmin Aug 29, 2014

Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message.

monoadmin commented Aug 29, 2014

Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message.

alexischr added a commit that referenced this pull request Aug 29, 2014

Merge pull request #1240 from NoesisLabs/master
Correct duplicate X509CertificateValidationMode definition error

@alexischr alexischr merged commit c109e47 into mono:master Aug 29, 2014

@@ -35,4 +37,5 @@ public enum X509CertificateValidationMode
PeerOrChainTrust = 3,
Custom = 4,
}
}

This comment has been minimized.

@alexischr

alexischr Aug 29, 2014

Member

Could you please remove the explicit enum values, for consistency's sake with the existing enum?

@alexischr

alexischr Aug 29, 2014

Member

Could you please remove the explicit enum values, for consistency's sake with the existing enum?

@RyanMelenaNoesis

This comment has been minimized.

Show comment
Hide comment
@RyanMelenaNoesis

RyanMelenaNoesis Aug 29, 2014

Contributor

Done... #1241

Contributor

RyanMelenaNoesis commented Aug 29, 2014

Done... #1241

@monoadmin

This comment has been minimized.

Show comment
Hide comment
@monoadmin

monoadmin Aug 29, 2014

Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message.

monoadmin commented Aug 29, 2014

Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment