New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWF] Improve ellipsis handling #1347

Merged
merged 2 commits into from Nov 2, 2014

Conversation

Projects
None yet
3 participants
@ermshiperete
Contributor

ermshiperete commented Oct 16, 2014

  • Don't subtract room for ellipsis. Ellipsis should be
    handled by the renderer so we shouldn't reserve space for it.
    Otherwise we end up not getting ellipsis (because the renderer
    thinks there is enough space available), or we don't use up the
    available space.
  • Don't allow text to go below button if we want to show ellipsis.

(There will probably be not difference visible when using the Cairo renderer, but it will improve things when using the experimental Pango renderer)

@monoadmin

This comment has been minimized.

Show comment
Hide comment
@monoadmin

monoadmin Oct 16, 2014

Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message.

monoadmin commented Oct 16, 2014

Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message.

@migueldeicaza

This comment has been minimized.

Show comment
Hide comment
@migueldeicaza

migueldeicaza Oct 20, 2014

Member

Please notify mono-deve-list and discuss this PR there.

Member

migueldeicaza commented Oct 20, 2014

Please notify mono-deve-list and discuss this PR there.

@migueldeicaza

This comment has been minimized.

Show comment
Hide comment
@migueldeicaza

migueldeicaza Oct 24, 2014

Member

Do you mind resending this pull request?

Member

migueldeicaza commented Oct 24, 2014

Do you mind resending this pull request?

ermshiperete added some commits Oct 16, 2014

[MWF] Display visual feedback on pressed button (#23869)
When a button is pressed the image and the text needs to be rendered one
pixel to the right and to the bottom so that there is some visual
feedback of the button press. Previously this was only the case if
TextImageRelation was set to Overlay.
[MWF] Improve ellipsis handling
- Don't subtract room for ellipsis. Ellipsis should be
  handled by the renderer so we shouldn't reserve space for it.
  Otherwise we end up not getting ellipsis (because the renderer
  thinks there is enough space available), or we don't use up the
  available space.
- Don't allow text to go below button if we want to show ellipsis.
@ermshiperete

This comment has been minimized.

Show comment
Hide comment
@ermshiperete

ermshiperete Oct 24, 2014

Contributor

This is now rebased on PR #1346 so that it doesn't give another merge conflict once that PR is merged.

Contributor

ermshiperete commented Oct 24, 2014

This is now rebased on PR #1346 so that it doesn't give another merge conflict once that PR is merged.

migueldeicaza added a commit that referenced this pull request Nov 2, 2014

@migueldeicaza migueldeicaza merged commit 0930889 into mono:master Nov 2, 2014

@ermshiperete ermshiperete deleted the ermshiperete:ImproveEllipsisHandling branch Nov 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment