New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xbuild] Only execute PCL target "ImplicitlyExpandTargetFramework" when corresponding property is true #1464

Merged
merged 1 commit into from Feb 18, 2015

Conversation

Projects
None yet
6 participants
@akoeplinger
Member

akoeplinger commented Dec 18, 2014

This aligns xbuild with the MS.NET behavior.

/cc @mhutch

[xbuild] Only execute PCL target "ImplicitlyExpandTargetFramework" wh…
…en corresponding property is true

This aligns xbuild with the MS.NET behavior.
@directhex

This comment has been minimized.

Show comment
Hide comment
@directhex

directhex Jan 7, 2015

Contributor

build

Contributor

directhex commented Jan 7, 2015

build

@migueldeicaza

This comment has been minimized.

Show comment
Hide comment
@migueldeicaza

migueldeicaza Feb 16, 2015

Member

Comment: this patch is part of a set of patches to build CoreFX with Mono on Unix.

Member

migueldeicaza commented Feb 16, 2015

Comment: this patch is part of a set of patches to build CoreFX with Mono on Unix.

@kumpera

This comment has been minimized.

Show comment
Hide comment
@kumpera

kumpera Feb 16, 2015

Member

Who can review this? I believe @mhutch or @baulig?

Member

kumpera commented Feb 16, 2015

Who can review this? I believe @mhutch or @baulig?

@mhutch

This comment has been minimized.

Show comment
Hide comment
@mhutch

mhutch Feb 16, 2015

Member

Looks okay to me, though I can't easily test it.

Member

mhutch commented Feb 16, 2015

Looks okay to me, though I can't easily test it.

baulig added a commit that referenced this pull request Feb 18, 2015

Merge pull request #1464 from akoeplinger/fix-portable-target
[xbuild] Only execute PCL target "ImplicitlyExpandTargetFramework" when corresponding property is true

@baulig baulig merged commit a20a045 into mono:master Feb 18, 2015

1 check failed

default Merged build finished.
Details
@baulig

This comment has been minimized.

Show comment
Hide comment
@baulig

baulig Feb 18, 2015

Member

Looks good to me.

Member

baulig commented Feb 18, 2015

Looks good to me.

@akoeplinger akoeplinger deleted the akoeplinger:fix-portable-target branch Feb 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment