Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dim] Emit error when calling abstract methods #15433

Merged
merged 2 commits into from Jun 28, 2019

Conversation

thaystg
Copy link
Contributor

@thaystg thaystg commented Jun 26, 2019

Emitting bad image exception when a non virtual call is calling an abstract method.

Fixes #13925

mono/mini/method-to-ir.c Outdated Show resolved Hide resolved
Implementing the same thing on interpreter.
Adding unit test.
@thaystg
Copy link
Contributor Author

thaystg commented Jun 27, 2019

@monojenkins build failed

2 similar comments
@thaystg
Copy link
Contributor Author

thaystg commented Jun 27, 2019

@monojenkins build failed

@thaystg
Copy link
Contributor Author

thaystg commented Jun 27, 2019

@monojenkins build failed

@thaystg thaystg merged commit c011456 into mono:master Jun 28, 2019
@lambdageek
Copy link
Member

@monojenkins backport to 2019-06

@monojenkins
Copy link
Contributor

@lambdageek backporting to 2019-06 failed, the patch results in conflicts:

Applying: Emitting bad image exception when a non virtual call is calling an abstract method.
Using index info to reconstruct a base tree...
M	mono/metadata/jit-icall-reg.h
M	mono/mini/method-to-ir.c
M	mono/mini/mini-runtime.c
Falling back to patching base and 3-way merge...
Auto-merging mono/mini/mini-runtime.c
Auto-merging mono/mini/method-to-ir.c
Auto-merging mono/metadata/jit-icall-reg.h
CONFLICT (content): Merge conflict in mono/metadata/jit-icall-reg.h
error: Failed to merge in the changes.
Patch failed at 0001 Emitting bad image exception when a non virtual call is calling an abstract method.

Please backport manually!

thaystg added a commit to thaystg/mono that referenced this pull request Jul 1, 2019
Backport mono#15433 to 2019-06.
thaystg added a commit that referenced this pull request Jul 1, 2019
Backport #15433 to 2019-06.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DIM] [CoreCLR Test] abstractcalls not working
4 participants