New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dim] Emit error when calling abstract methods #15433
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaystg
requested review from
lambdageek,
lewurm,
SamMonoRT and
vargaz
as code owners
June 26, 2019 22:04
lewurm
reviewed
Jun 27, 2019
Implementing the same thing on interpreter. Adding unit test.
lewurm
approved these changes
Jun 27, 2019
@monojenkins build failed |
@monojenkins backport to 2019-06 |
@lambdageek backporting to 2019-06 failed, the patch results in conflicts:
Please backport manually! |
thaystg
added a commit
to thaystg/mono
that referenced
this pull request
Jul 1, 2019
Backport mono#15433 to 2019-06.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emitting bad image exception when a non virtual call is calling an abstract method.
Fixes #13925