Fix various bugs causing hangs on Xunit #1654

Merged
merged 4 commits into from May 15, 2015

Conversation

Projects
None yet
5 participants
@alexanderkyte
Contributor

alexanderkyte commented Mar 24, 2015

No description provided.

@alexanderkyte alexanderkyte referenced this pull request in xunit/xunit Mar 24, 2015

Closed

xunit 2.0 TypeLoadException on Mono #158

@adamralph

This comment has been minimized.

Show comment
Hide comment
@adamralph

adamralph Mar 24, 2015

nice work @alexanderkyte! I'm really looking forward to being able to run xunit 2.0 in Mono

nice work @alexanderkyte! I'm really looking forward to being able to run xunit 2.0 in Mono

@NTaylorMullen

This comment has been minimized.

Show comment
Hide comment
@NTaylorMullen

NTaylorMullen Apr 3, 2015

+1 to what @adamralph said hah.

+1 to what @adamralph said hah.

@alexanderkyte

This comment has been minimized.

Show comment
Hide comment
@alexanderkyte

alexanderkyte Apr 6, 2015

Contributor

build

Contributor

alexanderkyte commented Apr 6, 2015

build

@alexanderkyte

This comment has been minimized.

Show comment
Hide comment
@alexanderkyte

alexanderkyte Apr 6, 2015

Contributor

I think it's safe to say that all the tests for this are passing, as the broken one looks like a jenkins bug I've been seeing on other bug builds.

Hold off on merging for a bit, I'm putting together a test for this specific crasher. It's pretty hard to extract from xunit, but at least it's not a race condition. It's pretty deterministic.

Contributor

alexanderkyte commented Apr 6, 2015

I think it's safe to say that all the tests for this are passing, as the broken one looks like a jenkins bug I've been seeing on other bug builds.

Hold off on merging for a bit, I'm putting together a test for this specific crasher. It's pretty hard to extract from xunit, but at least it's not a race condition. It's pretty deterministic.

@akoeplinger akoeplinger referenced this pull request in travis-ci/docs-travis-ci-com Apr 13, 2015

Closed

XUnit sample should use test runner for .NET 4.0 instead of .NET 2.0? #226

@LaylConway LaylConway referenced this pull request in opentk/opentk Apr 14, 2015

Closed

Add xunit example #250

@alexrp

This comment has been minimized.

Show comment
Hide comment
@alexrp

alexrp Apr 28, 2015

Member

build

Member

alexrp commented Apr 28, 2015

build

@alexanderkyte

This comment has been minimized.

Show comment
Hide comment
@alexanderkyte

alexanderkyte Apr 28, 2015

Contributor

I'm seeing the

* Assertion at mini-arm.c:3781, condition `pdata.found == 1' not met

error that has been haunting us on public jenkins arm for a while.

Contributor

alexanderkyte commented Apr 28, 2015

I'm seeing the

* Assertion at mini-arm.c:3781, condition `pdata.found == 1' not met

error that has been haunting us on public jenkins arm for a while.

alexanderkyte added some commits Mar 23, 2015

[Remoting] Avoid needing to resolve the type by serializing the TypeInfo
This is a better fix for the problem of what type to give an object
when the actual type can't be loaded in the current domain.

@martincostello martincostello referenced this pull request in experiandataquality/electronicupdates May 13, 2015

Merged

Linux support for C# #6

[runtime] Do not cache isinstance for TransparentProxies
When using a TransparentProxy, we run into the problem that the cache is
shared between all marshalbyrefobjects. The fix here is to not update
the cache when using a TransparentProxy, so that the correct slow path
is used.

@martincostello martincostello referenced this pull request in experiandataquality/electronicupdates May 14, 2015

Closed

C# Tests Not Run In Travis CI #13

@alexanderkyte

This comment has been minimized.

Show comment
Hide comment
@alexanderkyte

alexanderkyte May 14, 2015

Contributor

@kumpera I've updated the PR to bring the fixes to castclass, and extracted the caching behavior into a function. The indents look a bit absurd in a diff, but when in an editor where a tab is 8 spaces, as per the style guide, it's lined up.

Contributor

alexanderkyte commented May 14, 2015

@kumpera I've updated the PR to bring the fixes to castclass, and extracted the caching behavior into a function. The indents look a bit absurd in a diff, but when in an editor where a tab is 8 spaces, as per the style guide, it's lined up.

kumpera added a commit that referenced this pull request May 15, 2015

Merge pull request #1654 from alexanderkyte/xunit-fixes
Fix various bugs causing hangs on Xunit

@kumpera kumpera merged commit 738acc7 into mono:master May 15, 2015

0 of 4 checks passed

AMD64 Merged build finished. 10615 tests run, 85 skipped, 1 failed.
Details
ARM hard float Merged build finished. 44181 tests run, 1021 skipped, 4 failed.
Details
ARM soft float Merged build finished. 10603 tests run, 88 skipped, 2 failed.
Details
i386 Merged build finished. 10615 tests run, 85 skipped, 1 failed.
Details

@martincostello martincostello referenced this pull request in csMACnz/coveralls.net May 15, 2015

Closed

Use COVERALLS_REPO_TOKEN Environment Variable #41

@kspearrin kspearrin referenced this pull request in travis-ci/travis-ci Jun 8, 2015

Closed

mono 4.0.1.44 and xunit 2.0 #4045

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment