Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various bugs causing hangs on Xunit #1654

Merged
merged 4 commits into from May 15, 2015
Merged

Conversation

@alexanderkyte
Copy link
Contributor

@alexanderkyte alexanderkyte commented Mar 24, 2015

No description provided.

@adamralph
Copy link

@adamralph adamralph commented Mar 24, 2015

nice work @alexanderkyte! I'm really looking forward to being able to run xunit 2.0 in Mono

@NTaylorMullen
Copy link

@NTaylorMullen NTaylorMullen commented Apr 3, 2015

+1 to what @adamralph said hah.

@alexanderkyte
Copy link
Contributor Author

@alexanderkyte alexanderkyte commented Apr 6, 2015

build

@alexanderkyte
Copy link
Contributor Author

@alexanderkyte alexanderkyte commented Apr 6, 2015

I think it's safe to say that all the tests for this are passing, as the broken one looks like a jenkins bug I've been seeing on other bug builds.

Hold off on merging for a bit, I'm putting together a test for this specific crasher. It's pretty hard to extract from xunit, but at least it's not a race condition. It's pretty deterministic.

@alexrp
Copy link
Contributor

@alexrp alexrp commented Apr 28, 2015

build

@alexanderkyte
Copy link
Contributor Author

@alexanderkyte alexanderkyte commented Apr 28, 2015

I'm seeing the

* Assertion at mini-arm.c:3781, condition `pdata.found == 1' not met

error that has been haunting us on public jenkins arm for a while.

This is a better fix for the problem of what type to give an object
when the actual type can't be loaded in the current domain.
@alexanderkyte alexanderkyte force-pushed the alexanderkyte:xunit-fixes branch 2 times, most recently from 300f0e7 to 7f898e1 May 6, 2015
When using a TransparentProxy, we run into the problem that the cache is
shared between all marshalbyrefobjects. The fix here is to not update
the cache when using a TransparentProxy, so that the correct slow path
is used.
@alexanderkyte
Copy link
Contributor Author

@alexanderkyte alexanderkyte commented May 14, 2015

@kumpera I've updated the PR to bring the fixes to castclass, and extracted the caching behavior into a function. The indents look a bit absurd in a diff, but when in an editor where a tab is 8 spaces, as per the style guide, it's lined up.

kumpera added a commit that referenced this pull request May 15, 2015
Fix various bugs causing hangs on Xunit
@kumpera kumpera merged commit 738acc7 into mono:master May 15, 2015
0 of 4 checks passed
0 of 4 checks passed
AMD64 Merged build finished. 10615 tests run, 85 skipped, 1 failed.
Details
ARM hard float Merged build finished. 44181 tests run, 1021 skipped, 4 failed.
Details
ARM soft float Merged build finished. 10603 tests run, 88 skipped, 2 failed.
Details
i386 Merged build finished. 10615 tests run, 85 skipped, 1 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.