Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix various bugs causing hangs on Xunit #1654
I think it's safe to say that all the tests for this are passing, as the broken one looks like a jenkins bug I've been seeing on other bug builds.
Hold off on merging for a bit, I'm putting together a test for this specific crasher. It's pretty hard to extract from xunit, but at least it's not a race condition. It's pretty deterministic.
This is a better fix for the problem of what type to give an object when the actual type can't be loaded in the current domain.
When using a TransparentProxy, we run into the problem that the cache is shared between all marshalbyrefobjects. The fix here is to not update the cache when using a TransparentProxy, so that the correct slow path is used.