[runtime] NOHANDLES for ves_icall_System_Threading_Thread_GetCurrentThread #18480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hread This function (and its call to mono_handle_new) was showing up in the flamegraph for some async-heavy benchmarks
lambdageek
requested review from
akoeplinger,
EgorBo,
lateralusX,
marek-safar,
steveisok,
thaystg and
vargaz
as code owners
|
@monojenkins build deb with monolite |
CoffeeFlux
changed the title
CoffeeFlux
approved these changes
Jan 16, 2020
|
@monojenkins build |
lambdageek
changed the title
jaykrell
reviewed
Jan 17, 2020
| extern static Thread InitializeCurrentThread (); | ||
| private extern static void InitializeCurrentThread_icall (ref Thread thread); | ||
|
|
||
| static Thread InitializeCurrentThread () { |
There was a problem hiding this comment.
We are supposed to mark this NoInline right?
There was a problem hiding this comment.
Hm. yea. I think we want to try to replace it with an intrinsic in the near future
lambdageek
added a commit
to lambdageek/mono
that referenced
this pull request
Jan 17, 2020
Follow-up forhttps://github.com/mono/pull/18480 We might want to replace calls to this with an intrinsic
lambdageek
added a commit
to lambdageek/mono
that referenced
this pull request
Jan 17, 2020
Follow-up for mono#18480 We might want to replace calls to this with an intrinsic
akoeplinger
pushed a commit
that referenced
this pull request
Jan 17, 2020
Follow-up for #18480 We might want to replace calls to this with an intrinsic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function (and its call to
mono_handle_new) was showing up in theflamegraph for some async-heavy benchmarks