Jump to conversation
Unresolved conversations (1)
@lambdageek lambdageek May 29, 2020
Could just `if (...retargetable...) { g_string_append_printf (str, ", Retargetable=Yes"); }` after the public key token logic - then you wouldn't have to duplicate that `?:` expression.
Outdated
mono/metadata/assembly.c
Resolved conversations (8)
@lambdageek lambdageek Jun 19, 2020
Over in the https://github.com/dotnet/runtime/pull/37156 (mirror PR for the dotnet/runtime version of Mono), the builds are failing here. ``` /__w/1/s/src/mono/mono/metadata/reflection.c:1524:14: error: passing 'const char *' to parameter of type 'gchar *' (aka 'char *') discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] g_strchomp (assembly->name); ^~~~~~~~~~~~~~ /__w/1/s/src/mono/mono/eglib/glib.h:377:39: note: passing argument to parameter 'str' here gchar *g_strchomp (gchar *str); ^ 1 error generated. ``` ```suggestion g_strchomp ((char*)assembly->name); ```
Outdated
mono/metadata/reflection.c
@CoffeeFlux CoffeeFlux May 29, 2020
```suggestion g_string_append_printf (str, ", Version=%d.%d.%d.%d", aname->major, aname->minor, aname->build, aname->revision); ```
Outdated
mono/metadata/assembly.c
@CoffeeFlux CoffeeFlux May 29, 2020
```suggestion if (aname->has_version) ```
Outdated
mono/metadata/assembly.c
@CoffeeFlux CoffeeFlux May 29, 2020
```suggestion g_string_append_printf (str, ", Culture=%s", "neutral"); ```
Outdated
mono/metadata/assembly.c
@CoffeeFlux CoffeeFlux May 29, 2020
```suggestion g_string_append_printf (str, ", Culture=%s", aname->culture); ```
Outdated
mono/metadata/assembly.c
@lambdageek lambdageek May 29, 2020
Ooh... good catch!
mono/metadata/reflection.c
@lambdageek lambdageek May 29, 2020
```suggestion g_strchomp (assembly->name); ```
Outdated
mono/metadata/reflection.c
@lambdageek lambdageek May 29, 2020
```suggestion if (aname->has_public_key_token) { ```
Outdated
mono/metadata/assembly.c