Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[verifier] Do method visibility checks for virtual final methods. Enable type visibility for all methods. Fixes #5644. #2880

Merged
merged 3 commits into from Apr 20, 2016

Conversation

@kumpera
Copy link
Member

kumpera commented Apr 14, 2016

I cannot repro the issue mentioned in the comments of mono_method_can_access_method.

  • FIXME:
  • with generics calls to explicit interface implementations can be expressed
  • directly: the method is private, but we must allow it. This may be opening
  • a hole or the generics code should handle this differently.
  • Maybe just ensure the interface type is public.

@monojenkins merge

@monojenkins

This comment has been minimized.

Copy link
Contributor

monojenkins commented Apr 14, 2016

cannot merge:

  • "i386 Linux" state is "failure"
  • "AMD64 Linux" state is "failure"
@kumpera kumpera force-pushed the kumpera:fix_5644 branch from cf22854 to 633a9c7 Apr 14, 2016
@monojenkins

This comment has been minimized.

Copy link
Contributor

monojenkins commented Apr 15, 2016

cannot merge:

  • "i386 Linux" state is "failure"
  • "AMD64 Linux" state is "pending"
kumpera added 3 commits Apr 14, 2016
…ble type visibility for all methods. Fixes #5644.

I cannot repro the issue mentioned in the comments of mono_method_can_access_method.

* FIXME:
* with generics calls to explicit interface implementations can be expressed
* directly: the method is private, but we must allow it. This may be opening
* a hole or the generics code should handle this differently.
* Maybe just ensure the interface type is public.
@kumpera kumpera force-pushed the kumpera:fix_5644 branch from 633a9c7 to a26a533 Apr 20, 2016
@monojenkins monojenkins merged commit 4e91608 into mono:master Apr 20, 2016
4 of 6 checks passed
4 of 6 checks passed
AMD64 OSX Build triggered. sha1 is merged.
Details
ARM soft float Linux Build started sha1 is merged.
Details
AMD64 Linux Build finished. 44659 tests run, 1022 skipped, 0 failed.
Details
ARM hard float Linux Build finished. 44632 tests run, 1024 skipped, 0 failed.
Details
i386 Linux Build finished. 44659 tests run, 1022 skipped, 0 failed.
Details
i386 Windows Build finished. No test results found.
Details
@vargaz

This comment has been minimized.

Copy link
Member

vargaz commented Apr 21, 2016

@lewurm

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.