[sdb] Fix support for async debugging in optimized mode, roslyn gener… #5442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncham
reviewed
Aug 24, 2017
mono/mini/debugger-agent.c
Outdated
| /* Roslyn generates valuetypes in optimize mode */ | ||
| /* This is ok to do because the caller will not modify the object */ | ||
| return mono_value_box_checked (frame->domain, frame->method->klass, *(gpointer*)addr, &error); | ||
| mono_error_assert_ok (&error); |
There was a problem hiding this comment.
Does not make sense to assert after return
…ates valuetype IAsyncStateMethod implementations. Fixes #58728.
vargaz
force-pushed
the
fix-async-debug
branch
from
cc995c4
to
8481036
Compare
joncham
reviewed
Aug 24, 2017
| MonoError error; | ||
| /* Roslyn generates valuetypes in optimize mode */ | ||
| /* This is ok to do because the caller will not modify the object */ | ||
| MonoObject *obj = mono_value_box_checked (frame->domain, frame->method->klass, *(gpointer*)addr, &error); |
There was a problem hiding this comment.
So addr is a pointer to a pointer to the value type, not a pointer to the value type?
There was a problem hiding this comment.
It might be wrong, the test suite doesn't hit the code path which actually uses the object, and it just uses the object as an id, so this fix is probably wrong.
|
This looks like simple fix, could we get it to -08, -06 -04 branches |
|
There are more locations than just that one. |
|
So the result of the get_this () function is used as an id in parts of the code, so this patch which boxes the valuetype will not work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ates valuetype IAsyncStateMethod implementations. Fixes #58728.