[amd64] Make code patching smp safe for the case where we emit a mov … #5452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumpera
reviewed
Aug 26, 2017
mono/mini/mini-amd64.c
Outdated
| @@ -2870,6 +2870,10 @@ emit_call_body (MonoCompile *cfg, guint8 *code, MonoJumpInfoType patch_type, gco | |||
| amd64_call_code (code, 0); | |||
| } | |||
| else { | |||
| if (!no_patch && ((guint32)(code + 2 - cfg->native_code) % 4) != 0) { | |||
| guint32 pad_size = 4 - ((guint32)(code + 2 - cfg->native_code) % 4); | |||
There was a problem hiding this comment.
Shouldn't we align to 8 bytes here? Aligning at 4 we still risk cross a cache line
…+ call_reg. Hopefully fixes #57959.
|
LGTM, could explain how you found this issue? Everyone is curious about it!! |
|
that should probably be backported to at least |
|
Yes, this needs to go to 2017-08, 2017-06 and d15-4-2017-06 branches |
vargaz
added a commit
that referenced
this pull request
Aug 28, 2017
…+ call_reg. Hopefully fixes #57959. (#5452)
vargaz
added a commit
that referenced
this pull request
Aug 28, 2017
…+ call_reg. Hopefully fixes #57959. (#5452)
vargaz
added a commit
that referenced
this pull request
Aug 28, 2017
…+ call_reg. Hopefully fixes #57959. (#5452)
baulig
pushed a commit
to baulig/mono
that referenced
this pull request
Sep 1, 2017
Squashed commit of the following:
commit e82634a55776a1124a5ef4a6c742d13c79ac0a6d
Author: Zoltan Varga <vargaz@gmail.com>
Date: Thu Aug 31 07:17:02 2017 -0400
[sdb] Fix support for async debugging in optimized mode, roslyn generates valuetype IAsyncStateMethod implementations. Fixes #58728. (mono#5476)
commit 7110833d7e8dbe255ce82e2932049fd20e81272f
Author: Alexander Köplinger <alex.koeplinger@outlook.com>
Date: Thu Aug 31 10:53:35 2017 +0200
[bcl] Fix a few hardcoded socket ports in tests (mono#5471)
* [System] Fix a few hardcoded socket ports in tests
Those could've shown up as "address already in use" in CI.
* [System.Runtime.Remoting] Fix a few hardcoded socket ports in tests
Those could've shown up as "address already in use" in CI.
Additionally remove a copy of RemotingServicesTest.cs from corlib
which also exists in System.Runtime.Remoting in updated form.
* [System.ServiceModel] Fix a few hardcoded socket ports in tests
Those could've shown up as "address already in use" in CI.
* [System.Net.Http] Fix a few hardcoded socket ports in tests
Those could've shown up as "address already in use" in CI.
The additional "keep-alive" header in Send_Complete_NoContent() and
Send_Transfer_Encoding_Chunked() is because we were using the same
port for all tests before so other tests would clear the header.
This doesn't happen now that we use distinct test ports.
* [System.ServiceModel.Web] Fix a few hardcoded socket ports in tests
Those could've shown up as "address already in use" in CI.
commit e250d9f6cc73c9ba69fa3318154e9eae68a2b542
Author: Alexander Köplinger <alex.koeplinger@outlook.com>
Date: Thu Aug 31 00:41:53 2017 +0200
Revert "Merge pull request mono#5330 from alexanderkyte/dedup_mkbundle"
This reverts commit 9a287c0, reversing
changes made to 4a79280.
It breaks tons of tests.
commit b9164d6739f59cad9789b1ac4bde4011661377f7
Author: Martin Baulig <mabaul@microsoft.com>
Date: Wed Aug 30 13:43:36 2017 -0400
[Mono.Security]: Add 'MonoTlsProvider.SupportsCleanShutdown' and 'MonoTlsSettings.SendCloseNotify'. (mono#5465)
Only send close_notify when using BTLS and explicitly requested via 'MonoTlsSettings.SendCloseNotify'.
commit c77819f16ed144fce1b1bc163b72c904110db62b
Author: Alexander Kyte <alexmkyte@gmail.com>
Date: Sun Aug 13 06:43:36 2017 -0400
[runtime] Document mkbundle AOT options in man pages
commit 5f7d3ec1cb8962f78eb165f68849258dde3f872c
Author: Alexander Kyte <alkyte@microsoft.com>
Date: Mon Aug 7 17:25:52 2017 -0400
[runtime] Fix tracking of dedup module in mkbundle
commit 08b261b1cd427c1194e30456ffb36b16f3d17f3c
Author: Alexander Kyte <alexmkyte@gmail.com>
Date: Mon Jul 10 18:12:32 2017 -0400
[runtime] Add mkbundle support for dedup
commit 1e7fd43a851c5e785b0bc09a2f16f54ce18aab86
Author: Alexander Kyte <alexmkyte@gmail.com>
Date: Wed Jun 7 14:42:34 2017 -0400
[runtime] Clean up temp mkbundle aot directory
commit 09131a532faabd7d5b59ae2ae06a14d4d01e03d0
Author: Alexander Kyte <alexmkyte@gmail.com>
Date: Wed Jun 7 01:19:12 2017 -0400
[runtime] Fix mkbundle internationalization test results, build all
commit cd8a679ea8b62e1017f6d4911831c34b8fd8eda3
Author: Alexander Kyte <alexmkyte@gmail.com>
Date: Tue Jun 6 18:41:13 2017 -0400
[runtime] Provide config to mkbundle
commit cc5793c167894634971838f7bd6c79fb9feda646
Author: Alexander Kyte <alexmkyte@gmail.com>
Date: Mon Jun 5 17:52:59 2017 -0400
[runtime] Don't re-aot when running BCL tests
commit f14567a6646f34b4fd5376de632f5d3e3020d3ed
Author: Alexander Kyte <alexmkyte@gmail.com>
Date: Mon Jun 5 15:18:41 2017 -0400
[runtime] Skip not supported tests with mkbundle
commit 4850f483e51aa1fdb2945ca67e1cdac4540949eb
Author: Alexander Kyte <alexmkyte@gmail.com>
Date: Wed May 31 14:13:09 2017 -0400
[runtime] Build stripper and use with mkbundle
Preliminary linker support ran into dependency-finding bug
with the monolinker.exe binary. Fix postponed until later.
commit 3685f89bb99dc1ac1a38b4d1c069d78d6f4739bf
Author: Alexander Kyte <alexmkyte@gmail.com>
Date: Wed Jun 7 14:44:45 2017 -0400
[runtime] Add target to mkbundle all tests before CI
commit 24c87bf113efbe07a27b5cdc933c1d89b7978d06
Author: Alexander Kyte <alexmkyte@gmail.com>
Date: Wed Jun 7 14:44:36 2017 -0400
[runtime] Move testing dll into profile
commit 0c756a6ce1477635e31cac16b50281b7346d2f78
Author: Alexander Kyte <alexmkyte@gmail.com>
Date: Wed Jun 7 14:44:16 2017 -0400
[runtime] Fix in-tree building for mkbundle
commit de39aea0707f9678f8f1fa6ace0a0f9b03042821
Author: Alexander Kyte <alexmkyte@gmail.com>
Date: Wed Jun 7 14:44:09 2017 -0400
[runtime] Skip building System.Security, System.IdentityModel tests on testing_aot_full
commit b0eeda759fa662f559afbb67b4c5e1d479e1504c
Author: Alexander Kyte <alexmkyte@gmail.com>
Date: Wed Jun 7 14:43:58 2017 -0400
[runtime] Use mkbundle in BCL tests
commit c4270b37668048ca24e0e7f5bd0989f92835abe7
Author: Alexander Kyte <alexmkyte@gmail.com>
Date: Wed May 3 11:48:37 2017 -0400
[runtime] Fix path resolving for mkbundle
commit 9ca84de9e16de2eee9ad0ad870c678c8e5bde451
Author: Alexander Kyte <alexmkyte@gmail.com>
Date: Tue May 2 13:38:59 2017 -0400
[runtime] Add new dedup interface to mkbundle
commit 6e6e70c364db702cf30aa443ee58959ec62a7474
Author: Alexander Kyte <alexmkyte@gmail.com>
Date: Mon May 1 17:32:14 2017 -0400
[runtime] Fix mkbundle compilation on OSX
commit f7c5ea02ac0b517e90c9d646efd0edfc944c7a39
Author: Alexander Kyte <alexmkyte@gmail.com>
Date: Wed Jun 7 14:43:48 2017 -0400
[runtime] Enable compiling aot with mkbundle
commit 228003ef127bd2c92ee4c7e6823756354d1bea21
Author: Alexander Kyte <alexmkyte@gmail.com>
Date: Wed Jun 7 14:43:39 2017 -0400
[runtime] Add aot arguments to mkbundle
commit c7a98a4388184fd6d5d42c2d77ba26fe9d5881de
Author: Armin Hasitzka <cherusker@users.noreply.github.com>
Date: Wed Aug 30 12:16:20 2017 +0200
Update Clang's ThreadSanitizer blacklist (mono#5467)
commit 8e5ff842ec3110b8c27731c398020e09b0c50f03
Author: Joshua Peterson <petersonjm1@gmail.com>
Date: Wed Aug 30 05:59:57 2017 -0400
Call `g_utf8_to_utf16` with a proper argument (mono#5470)
* The sizes of `glong` and `gsize` differ on 64-bit Windows.
* In order to avoid uninitialized data in the high four bytes of the `bytes` argument to `mono_unicode_from_external`, call `g_utf8_to_utf16` with a `glong`, then copy the result.
commit 6a617161462ba223292268aebcef529971cdc45b
Author: Alexander Köplinger <alex.koeplinger@outlook.com>
Date: Tue Aug 29 22:05:12 2017 +0200
Revert "[runtime] Wait for the thread to really exit in Thread.Join (). (mono#5454)"
This reverts commit ec30afd.
It causes test failures on s390x.
commit 4e98fee260a99614a16ae2209dbcdf0b837010d2
Author: Alexander Köplinger <alex.koeplinger@outlook.com>
Date: Tue Aug 29 21:45:59 2017 +0200
Revert "[llvm] Add support for building with more recent versions of the mono llvm branch, in particular https://github.com/mono/llvm/tree/2017-07-06-5a1ffa96376e8a3ee895b782790591e5e7814ccf, which is based on llvm 5.0. (mono#5408)"
This reverts commit f01f854.
It broke a bunch of tests with llvm.
commit 725b3632ad596bd3115f04f4e0bd166fc4cacef1
Author: Marek Safar <marek.safar@gmail.com>
Date: Tue Aug 29 19:47:37 2017 +0200
[PEAPI] Don't add mscorlib reference when no type needs it
commit f341e96ac9d46d045535825cbb13ca5bfb546b69
Author: Marek Safar <marek.safar@gmail.com>
Date: Tue Aug 29 16:23:00 2017 +0200
[ilasm] Adds noautoinherit option
commit 38a99d7ad4cae044920751be5abdcdd335cf6e49
Author: Marek Safar <marek.safar@gmail.com>
Date: Tue Aug 29 15:51:55 2017 +0200
[ilasm] Adds AggressiveInlining support
commit fac5e77688cbb1013c242155e181252db6fbd99b
Author: Alexander Köplinger <alex.koeplinger@outlook.com>
Date: Tue Aug 29 09:18:43 2017 +0200
Remove leftover targets from Makefile.am (mono#5466)
win32getdeps and win32setup don't apply anymore.
commit e188f938e712d2b207393d6bb44f269faefd87c4
Author: Zoltan Varga <vargaz@gmail.com>
Date: Mon Aug 28 21:42:39 2017 -0400
[llvm] Add support for building with more recent versions of the mono llvm branch, in particular https://github.com/mono/llvm/tree/2017-07-06-5a1ffa96376e8a3ee895b782790591e5e7814ccf, which is based on llvm 5.0. (mono#5408)
commit a3be8e5ed6e2d7afcbfb6ddb1df96587203111c6
Author: Zoltan Varga <vargaz@gmail.com>
Date: Mon Aug 28 21:38:29 2017 -0400
[runtime] Wait for the thread to really exit in Thread.Join (). (mono#5454)
commit c3e2042e63da16b7fa195ef95b378875b2f02c97
Author: Zoltan Varga <vargaz@gmail.com>
Date: Mon Aug 28 21:37:08 2017 -0400
[sgen] Move the mono_gchandle_ functions to sgen-mono.c for consistency, add sgen_gchandle () functions instead. (mono#5460)
commit fd86cae5e7e362a1d99cf9b0cc7473dd0e5146db
Author: Zoltan Varga <vargaz@gmail.com>
Date: Mon Aug 28 21:36:42 2017 -0400
[sdb] Make the IL in dtest-excfilter.il valid. (mono#5463)
commit fb16067d35d185faf30d5d26385ef9bf58a6c5a7
Author: Zoltan Varga <vargaz@gmail.com>
Date: Mon Aug 28 04:37:53 2017 -0400
[amd64] Make code patching smp safe for the case where we emit a mov + call_reg. Hopefully fixes #57959. (mono#5452)
commit 427beae682b23a4e7da2dcc930d27a7357c8abf8
Author: Bernhard Urban <bernhard.urban@xamarin.com>
Date: Mon Aug 28 07:57:00 2017 +0200
[gc counters] avoid using Interlocked*64 functions as they are broken on some arches (mono#5451)
They are implemented via a global lock, which can lead to deadlooks in
some situations, e.g.
```
-0 0xb6c92e14 in sigsuspend () from /lib/arm-linux-gnueabi/libc.so.6
-1 0x0043f3b4 in suspend_signal_handler (_dummy=35, info=0xb4afe6d0, context=0xb4afe750) at mono-threads-posix-signals.c:177
-2 <signal handler called>
-3 0xb6de6bc4 in __pthread_mutex_unlock_usercnt () from /lib/arm-linux-gnueabi/libpthread.so.0
-4 0x00440f00 in InterlockedCompareExchange64 (dest=0x530700 <worker+64>, exch=0, comp=0) at atomic.c:578
-5 0x002f228c in InterlockedRead64 (src=0x530700 <worker+64>) at ../../mono/utils/atomic.h:398
-6 0x002f29a0 in COUNTER_READ () at threadpool-worker-default.c:194
-7 0x002f3320 in worker_park () at threadpool-worker-default.c:426
-8 0x002f3774 in worker_thread (unused=0x0) at threadpool-worker-default.c:488
-9 0x002e66b0 in start_wrapper_internal (start_info=0x0, stack_ptr=0xb4b00000) at threads.c:982
-10 0x002e6894 in start_wrapper (data=0x5a8f38) at threads.c:1044
-11 0xb6de31a8 in start_thread () from /lib/arm-linux-gnueabi/libpthread.so.0
-12 0xb6d3a1bc in ?? () from /lib/arm-linux-gnueabi/libc.so.6
Backtrace stopped: previous frame identical to this frame (corrupt stack?)
Thread 4 (Thread 0xb40ff440 (LWP 10198)):
-0 0xb6deb56c in __lll_lock_wait () from /lib/arm-linux-gnueabi/libpthread.so.0
-1 0xb6de584c in pthread_mutex_lock () from /lib/arm-linux-gnueabi/libpthread.so.0
-2 0x00440e6c in InterlockedCompareExchange64 (dest=0x559868 <gc_stats+8>, exch=2855648, comp=2844091) at atomic.c:570
-3 0x0039bdcc in InterlockedAdd64 (dest=0x559868 <gc_stats+8>, add=11557) at ../../mono/utils/atomic.h:392
-4 0x003a1b50 in collect_nursery (reason=0x5083f4 "Nursery full", is_overflow=0, unpin_queue=0x0) at sgen-gc.c:1865
-5 0x003a3794 in sgen_perform_collection (requested_size=4096, generation_to_collect=0, reason=0x5083f4 "Nursery full", wait_to_finish=0, stw=1) at sgen-gc.c:2539
-6 0x003a35f0 in sgen_ensure_free_space (size=4096, generation=0) at sgen-gc.c:2505
-7 0x00389db0 in sgen_alloc_obj_nolock (vtable=0xb4d174d0, size=64) at sgen-alloc.c:256
-8 0x0036e330 in mono_gc_alloc_vector (vtable=0xb4d174d0, size=64, max_length=12) at sgen-mono.c:1743
-9 0xb6c16a38 in ?? ()
Backtrace stopped: previous frame identical to this frame (corrupt stack?)
```
fixes https://bugzilla.xamarin.com/show_bug.cgi?id=59039
commit 7737b62c94dcfc143837a0690cd8a25bae50e177
Author: HinTak <htl10@users.sourceforge.net>
Date: Sun Aug 27 22:55:11 2017 +0100
More informative g_error message
Encountered this message while running the new mkbundle simple-cross functionality introduced recently. "Function not supported" is seen on both Mac OS X and Ubuntu. Will possibly file a separate bug since HAVE_MKDTEMP should be true... but it should be "Function mkdtemp not supported" in any case.
commit 950d0891a8f1876cd2e9e7bf8ba44a06ec0bf41b
Author: HinTak <htl10@users.sourceforge.net>
Date: Sun Aug 27 22:44:09 2017 +0100
remove redundant duplicate word 'not'
Found a consecutive 'not' pair while searching the code for somethng else.
commit 000782dd33745c361d0bbaf6b258788d288ac880
Author: Zoltan Varga <vargaz@gmail.com>
Date: Sun Aug 27 03:35:50 2017 -0400
[runtime] Use the AC_FUNC_STRERROR_R() autoconf macro to distinguish between the two possible signatures for strerror_r (). (mono#5453)
commit 87580b0b81883fa8fe989d1183d669aa7795e35d
Author: HinTak <htl10@users.sourceforge.net>
Date: Sun Aug 27 12:21:59 2017 +0800
Fixing confusing typos
Fixing confusing typos - should be self-explanatory.
commit 3195b7e9a9be33e3a4a3c9f1f887b7e95eb19ceb
Author: Zoltan Varga <vargaz@gmail.com>
Date: Sat Aug 26 04:53:24 2017 -0400
[jit] Assert that the trampoline code is called in gc unsafe mode, throw exceptions by returning the exception to the assembly trampoline code and throwing it from there. (mono#5409)
commit a2aec2fc41d61bfcdee84f0b3079511fe4078e6d
Author: Uri Simchoni <urisimchoni@users.noreply.github.com>
Date: Sat Aug 26 06:24:47 2017 +0300
[amd64] silence compiler warning (mono#5435)
Silence a GCC warning about param_regs and return_regs not being
used.
commit 30b369b5d7655b34668d2d1c4248e7490b177ca0
Author: Alexander Köplinger <alex.koeplinger@outlook.com>
Date: Fri Aug 25 21:58:52 2017 +0200
[System] Disable SocketTest.SendAsyncFile for now (mono#5447)
It's one of the flaky tests that we have had for a very long time.
There's work in progress fixing it as part of
mono#5345 and https://bugzilla.xamarin.com/show_bug.cgi?id=43172
but I think we should disable it in the meantime for clean CI.
commit 7547a81206d33f32916199cd72761415600e385d
Author: Alexander Köplinger <alex.koeplinger@outlook.com>
Date: Fri Aug 25 21:57:20 2017 +0200
[configure.ac] Don't include the .build number in runtime-corlib version (mono#5449)
It's causing unnecessary complexity because we need to create a new
monolite when bumping the .build number in a major.minor.build
version like from 5.2.0 -> 5.2.1
corlib version bumps are very rare in those cases and even then
you can just increment the MONO_CORLIB_COUNTER variable.
commit 833846c4eb27d034b2db07b6cef0fea3f8fe695d
Author: Alex Rønne Petersen <alex@alexrp.com>
Date: Fri Aug 25 21:06:36 2017 +0200
[profiler] Correct the description of the 'legacy' option.
commit 436671d65b80239c93637401f10e4d9fb2b70690
Author: Martin Baulig <mabaul@microsoft.com>
Date: Fri Aug 25 12:58:50 2017 -0400
[System]: Cleanup debugging and use the same technique from the new web stack. (mono#5441)
* Cleanup debugging and use the same technique from the new web stack.
* The MARTIN_DEBUG conditional has been renamed into MONO_TLS_DEBUG.
* Moved the actual implementation into MNS.MonoTlsProviderFactory.
* We now use an environment variable called 'MONO_TLS_DEBUG' to
enable debugging (so to get debugging, you need to both compile with
-define:MONO_TLS_DEBUG and set that environment variable).
The new web stack has a conditional and environment variable called
'MARTIN_WEB_DEBUG'.
* Use [Conditional] instead of #if.
commit 20c23ddce5721d7f67af2b99e7c32ac0b204c500
Author: monojenkins <jo.shields+jenkins@xamarin.com>
Date: Fri Aug 25 18:14:40 2017 +0200
[msvc] Update csproj files (mono#5450)
commit 1f325d59840af38ef6a573b5ef31e3ff3a6d59d2
Author: Alexander Köplinger <alex.koeplinger@outlook.com>
Date: Fri Aug 25 14:36:44 2017 +0200
[man] Cleanup mentions of monocov in mono.1 (mono#5446)
Coverage support was added to the log profiler in a5ab6c6
and the monocov profiler was removed with 1657026.
commit d3563fff7ca699142a3db7df9d7bc79b71072a28
Author: Jonathan Chambers <joncham@gmail.com>
Date: Fri Aug 25 03:46:34 2017 -0400
Retrieve thread lazily and avoid special case for defer. We were trying to get thread when in defer mode even for EVENT_KIND_VM_DEATH and hitting assert since current thread was not available. (mono#5440)
commit eef6fcabd0c10801650f42c3acc95d0eda260c28
Author: Jonathan Chambers <joncham@gmail.com>
Date: Fri Aug 25 03:38:11 2017 -0400
Ensure exception out argument is initialized to NULL. (mono#5424)
commit 6287b11d845fc9de2b4d328e40da688935aef52b
Author: Martin Baulig <mabaul@microsoft.com>
Date: Thu Aug 24 16:13:04 2017 -0400
[System]: Cleanup internal TLS APIs in preparation of adding renegotiation support. (mono#5426)
* [btls]: Bind new native APIs to support renegotiation.
* mono_btls_ssl_set_renegotiate_mode(), mono_btls_ssl_renegotiate_pending():
New native methods.
* MonoBtlsSsl: Added SetRenegotiateMode() and RenegotiatePending().
* MonoBtlsSslRenegotiateMode: New internal enum.
* [System]: Cleanup internal Mono.Net.Security.MobileTlsContext APIs.
Use tuple `(int ret, bool wantMore)' return value instead of out variables.
* [System]: Check for pending exceptions in MobileAuthenticatedStream.
This should fix some issues where we're hanging instead of throwing
an exception if something went wrong.
commit 21d156d34aef1cc56151c884bc11d0a91d0bcf55
Author: Alex Rønne Petersen <alpeters@microsoft.com>
Date: Thu Aug 24 17:08:49 2017 +0200
[profiler] Add a missing method_leave event for the CEE_MONO_RETOBJ opcode.
commit 40c349fd10e741428f4bc70e3628f193c42a5cfc
Author: Alex Rønne Petersen <alpeters@microsoft.com>
Date: Thu Aug 24 17:08:20 2017 +0200
[profiler] Add a missing method_tail_call event when the tailc optimization is enabled.
commit 789c583cbb554249c8b291d02f23f51db45518e1
Author: cherusker <prince.cherusker@gmail.com>
Date: Thu Aug 24 16:16:02 2017 +0200
Complete the function prototype
commit 79e706fc97e53078d20b1d51afc574585af604f5
Author: Marek Safar <marek.safar@gmail.com>
Date: Thu Aug 24 10:37:05 2017 +0200
[mcs] Update logic when checking for tuple element names when overriding inherited member
commit 7c84271253750344cfc32a1c66b2f1d0c9c31978
Author: Zoltan Varga <vargaz@gmail.com>
Date: Wed Aug 23 22:46:10 2017 -0400
Revert "[runtime] Fix a warning."
This reverts commit f996175.
Revert this as the original code was right, there is a problem with the defines.
commit c767a546d9e27dbfa7f3d505531ca9ef1635703e
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Tue Aug 22 13:15:04 2017 -0700
[wasm] Don't define MONO_CROSS_COMPILE in the wasm configure.ac
commit ebf27836670f8d337959844904635314f8260500
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Tue Aug 22 13:02:10 2017 -0700
[utils] Fix mono_valloc and mono_valloc_aligned malloc-based implementation.
commit 80723179154f9c13e760ae36c8b3cf23a2d9bd94
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Tue Aug 22 11:42:33 2017 -0700
[wasm] Add wasm stubs for object-offsets and sgen-archdep.
commit 442807ec17ee254804799afc89283bf2eef59908
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Tue Aug 22 11:42:01 2017 -0700
[wasm] Add wasm strings to mono-config.c
commit 25f8b7339593e6d2ff332af99190da3176d9b6d7
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Tue Aug 22 11:37:28 2017 -0700
[wasm] Add comments explaining the magic strings in mono-dl-wasm.c
commit a97d816318906d6d845b1e470808a164a2a1710a
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Tue Aug 22 11:36:45 2017 -0700
[readme] Document --enable-wasm
commit 88d4c6a805d165a7f23b32422eda4c007b2f3ede
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Mon Aug 21 16:26:04 2017 -0700
[wasm] Add threading, dl and hwcap support for wasm.
commit c0dbc42db882f00d5b94dff9b9e8389396bf8f9b
Author: Neale Ferguson <neale@sinenomine.net>
Date: Tue Aug 22 11:29:27 2017 -0400
Remove unnecessary ifdefed code
commit f7eff0f6a9d4e64ae5916189ec7004040b177da4
Author: Neale Ferguson <neale@sinenomine.net>
Date: Fri Aug 18 11:22:04 2017 -0400
Skip load if same register
commit daa0cbfe426bd0054aade4755db5e665565b1a27
Author: Neale Ferguson <neale@sinenomine.net>
Date: Thu Aug 17 16:42:54 2017 -0400
Add support for z13 processor
The z13 supports some useful instructions that can be exploited
by the JIT. Most notably the compare-and-branch instructions can
reduce a two instruction sequence to one. The load-and-add command
eliminates the more complex compare-and-swap sequence.
The z13 also supports three operand instructions dst,src1,src2
which eliminate checks and loads for instructions like add and subtract.
The unaligned.cs test has been changed to cater for big-endian platforms.
For s390x only, the --trace option will result in a file per thread
being created rather than the traces being written to stdout and
sometimes intermixing incomplete trace entries.
commit b2ada70e9c559820ccef1c908b851f2dfe17f477
Author: Armin Hasitzka <cherusker@users.noreply.github.com>
Date: Wed Aug 23 19:50:34 2017 +0200
[TSan] Unlocking MonoStats, GCStats and JITGCStats (mono#5381)
[TSan] Unlocking MonoStats, GCStats and JITGCStats
As the `Unlocked* ()` functions have been approved in mono#5310, I used them to blacklist some of the most obvious counting variables whose data races should be ignored: `MonoStats`, `GCStats` and `JITGCStats` (more to follow if approved).
Please find details about all changes within the commit messages.
commit ca6dba77d255f63fdc92048f8da3e1ffb4bdf0cc
Author: Marek Safar <marek.safar@gmail.com>
Date: Tue Aug 22 18:30:08 2017 +0200
[threadpool] Reduce logging verbosity level. Fixes #58829
commit b071366f4f64ebbbb0abb2585365ff2d94c2a627
Author: Elastino <lee@serialimage.com>
Date: Wed Aug 23 12:42:16 2017 +0900
Added compile target option as library
Added -t:library since mcd does not interpret output filename for dll suffix.
Without -t:library option, it fails to compile.
{code}
mono$ mcs -debug+ -r:System.Core Options.cs -o:Mono.Options.dll
error CS5001: Program `Options.exe' does not contain a static `Main' method suitable for an entry point
Compilation failed: 1 error(s), 0 warnings
{code}
commit 75e44d09b42a33bda85b40eeaaef7fac32ffe789
Author: Zoltan Varga <vargaz@gmail.com>
Date: Tue Aug 22 16:53:01 2017 -0400
Revert "Disable pinvoke2.exe test on OSX i386 for now (mono#5411)"
This reverts commit 4d89d5f.
Revert this as the problematic test is disabled in libtest.c.
commit ad532132bf31acc7b793441105b759f29f178665
Author: Zoltan Varga <vargaz@gmail.com>
Date: Tue Aug 22 14:46:48 2017 -0400
[runtime] Disable a test which asserts because of an abi break in recent xcode/clang versions. Works around #58901.
commit 84f196c616c59d05fe70931b1b71bb627f307640
Author: Rogier Hofboer <r.hofboer@nl.ccv.eu>
Date: Tue Aug 22 13:38:25 2017 +0200
[Mono.Security] Bugfix of bug 23153. Certificate loop variable not used to find certificate
commit ebf486b80f413f46882c5729303228a5140b6d1d
Author: Jo Shields <joshield@microsoft.com>
Date: Tue Aug 22 10:18:20 2017 -0400
[msi] Fix typos in f9bdab7
commit c87c221fd2d54afa159531a0bf0247371e65497e
Author: Infko <recollectionforgot@gmail.com>
Date: Tue Aug 22 21:11:43 2017 +0800
[Syndication]Fix Runtime crash when parsing pubTime in RFC822 format (mono#5416)
commit 45cfb9f10fe259201cd0fb643cc50001e72eb483
Author: Alexander Köplinger <alex.koeplinger@outlook.com>
Date: Tue Aug 22 15:05:59 2017 +0200
[bcl] Remove unused left over .args files
commit 9dca54f3c9af9cbabad905a15bfe3c911ec4c66d
Author: Alexander Köplinger <alex.koeplinger@outlook.com>
Date: Tue Aug 22 12:49:35 2017 +0200
[MacSDK] Whitelist the csi script
commit 41eff91fa897823872a133f038d52cde8322ea5c
Author: markusbeth <markus.beth@web.de>
Date: Tue Aug 22 02:49:37 2017 +0200
enable some tests for System.Text.UnicodeEncoding (mono#5414)
Remove attribute Category ("NotWorking") from tests GetString_Odd_Count_0
and GetString_Odd_Count_ff as they are now working.
commit 631960d9761eeee41610c02e66b019fc1afd0e58
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Mon Aug 21 15:31:05 2017 -0700
[utils] Fix atomic fallout implementation function naming.
commit 91f379c61a272430bdd32cf691338fdb84f575d7
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Mon Aug 21 15:30:16 2017 -0700
[wasm] Add wasm stubs for MonoContext and membar ops.
commit 22728af39b93d53fb50282a15459864df6e45da2
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Mon Aug 21 15:14:43 2017 -0700
[WASM] Hack configure.ac to support wasm. Use --enable-wasm instead of --host / --target
commit d9c333162c38a1c1f44230f675303dc523793f36
Author: Alexander Köplinger <alex.koeplinger@outlook.com>
Date: Mon Aug 21 17:33:40 2017 +0200
Fix method-access.exe test (mono#5412)
The exception message of a MethodAccessException was changed in 7b88115.
This caused the method-access.exe test to fail since it checked for the old format.
commit 65ca9793ddb1e6b34a564d1982525193fef9d7e3
Author: Alexander Köplinger <alex.koeplinger@outlook.com>
Date: Mon Aug 21 17:09:06 2017 +0200
Disable pinvoke2.exe test on OSX i386 for now (mono#5411)
Reenable once https://bugzilla.xamarin.com/show_bug.cgi?id=58901 is fixed.
commit 7feefe5ca1f2bb6675e3fd779636fcdc58061a3d
Author: Jo Shields <joshield@microsoft.com>
Date: Mon Aug 21 09:59:36 2017 -0400
[msi] Pull in MSI changes from Mono 5.2 branch
(cherry picked from commit 929575b)
commit 925580fb4e895d585dd968f8fe85c1daadaea23e
Author: Alexander Köplinger <alex.koeplinger@outlook.com>
Date: Mon Aug 21 15:28:44 2017 +0200
Bump libgdiplus (mono#5393)
commit d126f8dc80ff3dfb6288014f3d4c92ac926c1e82
Author: Alexander Köplinger <alex.koeplinger@outlook.com>
Date: Mon Aug 21 13:45:58 2017 +0200
Bump timeout for TaskTests.Delay_Simple (mono#5410)
Should be reverted once https://bugzilla.xamarin.com/show_bug.cgi?id=58877 is investigated and fixed.
commit dc240f7432f2de9632dcae4eb363c47766747fa4
Author: Marek Safar <marek.safar@gmail.com>
Date: Mon Aug 21 13:04:34 2017 +0200
Use absolute paths to avoid ambiguity
commit bf19c99aa96b10eb8301f440ed9bfd9d9ae36a54
Author: Marek Safar <marek.safar@gmail.com>
Date: Mon Aug 21 10:45:30 2017 +0200
CODEOWNERS update
commit 7a3b8fdcd4f64eb62190e589f727cfb7c31ccc97
Author: Jonathan Chambers <joncham@gmail.com>
Date: Fri Aug 18 21:34:29 2017 -0400
Add null check for target to optimized delegate constructor code path. Fixes case 58888 (mono#5404)
commit 8138352fc9ad63e1a241472cfb5666346284097d
Author: Alexander Köplinger <alex.koeplinger@outlook.com>
Date: Sat Aug 19 02:40:54 2017 +0200
Update CODEOWNERS
commit fcddabf204aee980607ff232aa2be22195ed6d02
Author: Miguel de Icaza <miguel@gnome.org>
Date: Fri Aug 18 20:05:32 2017 -0400
Remove lingering bits from removed prj2make tool (mono#5405)
commit a983487a6a23650b96d5cd3caffcafbb19fb1fb6
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Fri Aug 18 15:40:03 2017 -0700
[pedump] Have the assembly search hook look at the same directory of the assembly being verified.
Unfortunately using mono_set_assemblies_path is not much of an option as it disables the MONO_PATH env var
and that's needed when working with an in-tree pedump - cuz having to `make install` all the time is BS.
commit e3d51333158011eded7e340b8ca7bce07d637d2e
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Fri Aug 18 15:00:45 2017 -0700
[verifier] Base constructors can only be called on uninit'd this pointers. Fix mono#12157.
commit a87447c7b0acbd6ea25fd56cadd328318b5d8b50
Author: Marek Safar <marek.safar@gmail.com>
Date: Fri Aug 18 23:13:29 2017 +0200
More codeowners updates
commit 4f531342e45e7046c14765f01f8032a6a3fbf1e3
Author: vkargov <kargov@gmail.com>
Date: Fri Aug 18 08:09:30 2017 -0700
[jit] Don't emit a redundant move in lazy fetch trampolines on AMD64. (mono#5346)
commit 7b892efb098780f9e849436a8184c00555eb6b9a
Author: Aleksey Kliger <aleksey@xamarin.com>
Date: Thu Aug 17 18:56:49 2017 -0400
[threads] Use designated initializer syntax in MAKE_SPECIAL_STATIC_OFFSET
Originally we used a C90-style struct initializer `{ (index), (offset), (type)
}`. Unfortunately, SpecialStaticOffset is defined with fields in a different
order on big-endian and little-endian machines. Using a designated
initializer, we don't have to care about the order.
commit 873daa00366ef7562a7816f131aa17a2d9b3f462
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Thu Aug 17 15:47:27 2017 -0700
[runtime] Format MethodAccessException method names to use the same formating as reflection. Fixes #41279
Add mono_method_get_reflection_name that returns the string managed is expecting.
commit 7be787bb14194d0f937bfedebe7e4ce859c75aed
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Thu Aug 17 11:33:37 2017 -0700
[runtime] Don't set pkey to a value that will be freed immediately after.
commit cfc4ac51f269a586c081be497b9f2920e1c2e952
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Thu Aug 17 11:01:04 2017 -0700
update CODEOWNERS
commit 58f010df906f59b826f0e64ae500a45a32b82856
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Wed Aug 16 15:42:33 2017 -0700
[verifier] Check methodimpl table for duplicated. Fixes mono#11696
commit 2101f826371090e905ffe38b49a2457f3a28ce02
Author: Ludovic Henry <ludovic@xamarin.com>
Date: Thu Aug 17 19:11:23 2017 +0200
[marshal] Rethrow in native-to-managed wrapper to keep exception stacktrace (mono#5384)
* [marshal] Rethrow in native-to-managed wrapper to keep exception stacktrace
Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=58782
* [interp] disable tests for 58782 as they rely on appdomains
commit 490cc16acc4326208d148ed9f73ef53d81c3984d
Author: Ludovic Henry <ludovic@xamarin.com>
Date: Thu Aug 17 19:03:40 2017 +0200
[w32error] Add ENODEV -> ERROR_DEV_NOT_EXIST error translation (mono#5385)
Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=58738
commit 816338a9bce4dca4d109f5654647cb2a2106af64
Author: Eberhard Beilharz <eb1@sil.org>
Date: Wed Aug 16 12:33:18 2017 -0600
[SWF] Fix string drawing truncation in combo boxes
This fixes Xamarin-10321. This change fixes the problem in SWF rather
than in libgdiplus which has the advantage that it works with both
Cairo and Pango renderers.
Without the additional NoWrap flag the text will wrap at a word boundary,
which results in the combo box showing lines with potentially a lot of
empty space at the end. With the NoWrap flag we render only one line,
displaying as many characters as possible in that one line.
commit a86d15c9bc4cfd8f6e3e0ff32b6bef4c88a36402
Author: Armin Hasitzka <cherusker@users.noreply.github.com>
Date: Thu Aug 17 09:54:26 2017 +0200
Use the `Unlocked* ()` functions to blacklist specific load / store operations (mono#5387)
- avoid blacklisting whole functions with `MONO_NO_SANITIZE_THREAD`
- change `long` to `gint64` as it is more portable
commit be587490d0f36d109ca05b571c916e08146e9488
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Wed Aug 16 16:43:11 2017 -0700
[corlib] When parsing the ECMA key, don't produce a public key. Fixes #58637
The key was incorrectly encoded and triggered heap corruption.
commit 4e51450cfc2602f43672001a0db5c67d10602db8
Author: Ludovic Henry <ludovic@xamarin.com>
Date: Wed Aug 16 22:21:13 2017 +0200
[corlib] Increase timeout for MonoTests.System.Runtime.Remoting.TestSynchronizationReleasedOnMultipleAcquire (mono#5373)
commit c010cf5ef7109d38c8f711291724ff14fa7fddda
Author: Alexander Köplinger <alex.koeplinger@outlook.com>
Date: Wed Aug 16 19:09:28 2017 +0200
Bump bockbuild
commit 25e8623d30fcdcfc7b64692c7b65e7b78fab8eba
Author: Marek Safar <marek.safar@gmail.com>
Date: Wed Aug 16 13:15:41 2017 +0200
Update list of denied assemblies
commit 94bee91122f9ca72233014cb347833f7db72b6f3
Author: Ankit Jain <ankit.jain@xamarin.com>
Date: Tue Aug 15 23:50:09 2017 -0400
[msbuild] bump to xplat-master branch HEAD
commit 286b744c9544f52c764456a3b01711652c02c859
Author: Ankit Jain <radical@gmail.com>
Date: Tue Aug 15 23:51:29 2017 -0400
[msbuild] Install a `deniedAssembliesList.txt` to support denied ... (mono#5358)
... assemblies.
msbuild tries to filter out the denied assemblies, which mono refuses to
load, during a build. It uses the `deniedAssembliesList.txt` installed
to `$mono_prefix/lib/mono/xbuild` to identify them.
This was generated with:
`$ mono tools/nuget-hash-extractor/nuget-hash-extractor.exe nugets guids_for_msbuild > mcs/tools/xbuild/data/deniedAssembliesList.txt`
This file needs to be kept in sync with any changes in the assemblies
denied by the runtime.
msbuild PR that adds support for this -
mono/msbuild#23 .
commit 3302a8695914fcec55387ccd5bea8e4faaa3fcf7
Author: Ankit Jain <ankit.jain@xamarin.com>
Date: Tue Aug 15 22:55:13 2017 -0400
[msbuild] bump to xplat-master branch HEAD
commit c41700548b99638b5805eb08e1e7f49733c3badd
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Tue Aug 15 14:56:09 2017 -0700
[verifier] Add workaround for verifying corlib and valid-only output.
commit c2340aacc20f14d9965c04665820dedf3983884f
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Tue Aug 15 14:54:47 2017 -0700
[verifier] Handle csc encoding of enums in cattr blobs. Fixes #58168.
commit a23c81bdc1c811fa8f3c4e4061e3550d9ed2ef23
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Tue Aug 15 14:53:17 2017 -0700
[runtime] Add WINDOWS_RUNTIME type attribute that csc generates
commit 69e6b478cde17123cc29d8a2c3fca50d1b2a4154
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Tue Aug 15 14:32:38 2017 -0700
[verifier] Avoid double init of metadata when using pedump.
This is a workaround for the larger problem of it using a non-standard init sequence.
Tracked as https://bugzilla.xamarin.com/show_bug.cgi?id=58793
commit 2d35e1b837fa58a48fc033cb565b5de130278883
Author: Rodrigo Kumpera <kumpera@gmail.com>
Date: Tue Aug 15 14:28:21 2017 -0700
[verifier] Partially revert 6d37ffd. It adds internal a header to a public one.
commit f3bf264e3d16e7e1150605d179bd69d500f374d0
Author: Marek Safar <marek.safar@gmail.com>
Date: Tue Aug 15 23:14:36 2017 +0200
netstandard dependant facades update after 2.0 release (mono#5371)
commit 531a4f8b319c98f566fda83a0dcaea617af215ef
Author: Aaron Bockover <abock@xamarin.com>
Date: Tue Aug 15 11:37:41 2017 -0400
mkbundle: avoid NREs and print useful errors
When scanning for references, emit an error when loading the assembly
into the universe fails or when loading a referenced assembly by
name fails.
commit 917f18aef3f67239e81936c90262414e8c5264a4
Author: Ankit Jain <ankit.jain@xamarin.com>
Date: Tue Aug 15 16:39:27 2017 -0400
[msbuild] bump to help debug wrench build failure
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…+ call_reg. Hopefully fixes mono/mono#57959. (mono/mono#5452) Commit migrated from mono/mono@9a634c1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…+ call_reg. Hopefully fixes #57959.