Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jit] Fix the saving of the 'cfg->ret_var_set' flag when inlining, it… #5654

Merged
merged 1 commit into from Oct 2, 2017
Merged

[jit] Fix the saving of the 'cfg->ret_var_set' flag when inlining, it… #5654

merged 1 commit into from Oct 2, 2017

Conversation

vargaz
Copy link
Member

@vargaz vargaz commented Sep 27, 2017

… was set to FALSE before it was saved, causing invalid code to be generated in some cases when doing nested inlining. Fixes #59608.

@vargaz
[jit] Fix the saving of the 'cfg->ret_var_set' flag when inlining, it…
566480f 
… was set to FALSE before it was saved, causing invalid code to be generated in some cases when doing nested inlining. Fixes #59608.
lewurm
lewurm approved these changes Oct 2, 2017
View reviewed changes
Copy link
Contributor

@lewurm lewurm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tricky. LGTM

@vargaz vargaz merged commit 30cddad into mono:master Oct 2, 2017
@vargaz vargaz deleted the fix-59608 branch October 2, 2017 14:26
@akoeplinger
Copy link
Member

should we backport it?

vargaz added a commit to vargaz/mono that referenced this pull request Oct 2, 2017
@vargaz
[jit] Fix the saving of the 'cfg->ret_var_set' flag when inlining, it…
b6c5e49 
… was set to FALSE before it was saved, causing invalid code to be generated in some cases when doing nested inlining. Fixes #59608. (mono#5654)
@vargaz vargaz mentioned this pull request Oct 2, 2017
Merged
akoeplinger pushed a commit that referenced this pull request Oct 3, 2017
@vargaz @akoeplinger
[jit] Fix the saving of the 'cfg->ret_var_set' flag when inlining, it… (
df4669b 
#5674)

* [jit] Fix the saving of the 'cfg->ret_var_set' flag when inlining, it was set to FALSE before it was saved, causing invalid code to be generated in some cases when doing nested inlining. Fixes #59608. (#5654)

* Bump API snapshot submodule
akoeplinger pushed a commit that referenced this pull request Oct 3, 2017
@vargaz @akoeplinger
[jit] Fix the saving of the 'cfg->ret_var_set' flag when inlining, it…
7a3c714 
… was set to FALSE before it was saved, causing invalid code to be generated in some cases when doing nested inlining. Fixes #59608. (#5654)

(cherry picked from commit 30cddad)
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@vargaz
[jit] Fix the saving of the 'cfg->ret_var_set' flag when inlining, it…
40b5b19 
… was set to FALSE before it was saved, causing invalid code to be generated in some cases when doing nested inlining. Fixes mono/mono#59608. (mono/mono#5654)

Commit migrated from mono/mono@30cddad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewurm lewurm lewurm approved these changes

@kumpera kumpera Awaiting requested review from kumpera

@alexrp alexrp Awaiting requested review from alexrp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vargaz @akoeplinger @lewurm @dnfclas