[sdk] Add wasm interpreter support. #5924

kumpera · 2017-11-01T21:17:06Z

This adds all bits to get the mini test suite to run under the interpreter

…time.

luhenry · 2017-11-02T00:20:18Z

sdks/builds/setup-emsdk.sh

@@ -0,0 +1,14 @@
+


why use a separate sh file?

The script was a lot more convoluted before. I'll merge.

luhenry · 2017-11-02T00:20:45Z

sdks/builds/wasm.mk

+
+#toolchain code
+.stamp-wasm-toolchain:
+	@./setup-emsdk.sh $(TOP)/sdks/builds/toolchains/emsdk


please do not use @, we don't use it anywhere else

luhenry · 2017-11-02T00:22:20Z

sdks/builds/wasm.mk

+	--host=i386-apple-darwin10
+
+#toolchain code
+.stamp-wasm-toolchain:


Why do we have a wasm while all other targets are wasm-interp?

cuz the other wasm targets require their own toolchains.

luhenry · 2017-11-02T00:28:56Z

sdks/builds/wasm.mk

+.PHONY: clean-wasm-interp clean-wasm
+clean-wasm::
+	rm -rf .stamp-wasm-toolchain
+clean-wasm-interp:: clean-wasm


please unify both wasm-interp and wasm targets as there is no apparent reason to have wasm

There's a reason for this.
There are 4 more runtime configs coming down the line: mini aot/runtime, llvm aot/runtime.

This is the only one ready for merging and I feel like keeping the bits for the others made sense.

kumpera · 2017-11-02T23:05:50Z

@luhenry I updated this PR with the rest of the required work to bring the interpreter in.

kumpera · 2017-11-02T23:09:25Z

Here's a sample run from the wasm dir: https://gist.github.com/11180dc8613200c0d22a0ba4571ba674

SteveSandersonMS · 2017-11-03T17:23:40Z

sdks/wasm/test.js

+		Module.setValue (args_mem + i * 4, args [i], "i32");
+	Module.setValue (eh_throw, 0, "i32");
+
+	var res = invoke_method (send_message, this_arg, args_mem, eh_throw);


send_message should be method (it's only working as send_message because that's the only method that gets used in this test file)

SteveSandersonMS · 2017-11-03T17:25:09Z

sdks/wasm/test.js

+	if (Module.getValue (eh_throw, "i32") != 0) {
+		Module.Runtime.stackRestore(stack);
+		var msg = conv_string (res);
+		throw new SharpException (msg); //the convention is that invoke_method ToString () any outgoing exception


It's much better if this is just throw new Error(msg) instead of using SharpException, because SharpException causes the error not to appear correctly in the browser debug console.

There might be some way of having a custom Error subclass that appears properly in the console, but I'm not certain what it is.

SteveSandersonMS · 2017-11-03T17:29:32Z

sdks/wasm/library_mono.js

+
+	request_gc_cycle: function () {
+		++MONO.pump_count;
+		if (Module.ENVIRONMENT_IS_WEB) {


I don't think this is correct. In mono.js, ENVIRONMENT_IS_WEB is a local variable, and is not exposed as a property of Module, so this check always evaluates as false and GC never runs. I think you need something like the following instead:

if (Module['ENVIRONMENT'] === 'WEB' || Module['ENVIRONMENT'] === 'WORKER')

... which not only fixes the WEB case but also allows GC in the WORKER case.

kumpera · 2017-11-07T17:46:16Z

Addressed @SteveSandersonMS issues.

lewurm

amazing stuff 👍

juepiezhongren · 2017-11-10T09:32:08Z

So, is xamarin.wasm getting close?

kumpera · 2017-11-10T18:33:53Z

@juepiezhongren yes, you can try it today if you adventure yourself on building it from source.

Mike-E-angelo · 2017-11-21T07:41:22Z

Wow excellent work here @kumpera. Thank you for your time and your contributions!

juepiezhongren · 2017-11-21T08:05:27Z

@Mike-EEE have u seen the perspective future that x.forms is to fulfill your ubUI?

Mike-E-angelo · 2017-11-21T08:15:21Z

Not yet, @juepiezhongren ... not officially at least. From what I understand, the future is somewhere between Xamarin.Forms, Noesis, and Avalonia. Once mono supports (or rather releases support for :)) WebAssembly, each one of these models will be able to run everywhere. I myself am partial to Noesis/Avalonia models, but there is a market for a XF-type model, too. So everyone is (or will be) covered. 😄

juepiezhongren · 2017-11-21T08:19:21Z

Ava is still at baby stage, what is Noesis, please give a url, por favor@Mike-EEE

Mike-E-angelo · 2017-11-21T08:23:08Z

They are a commercial solution but hold true to WPF. :)

http://www.noesisengine.com/

juepiezhongren · 2017-11-21T08:25:08Z

@Mike-EEE What i prefer most is the architecture for xf, with native binding like x.ios, x.android.... and with Ub solution. So, i hope competitor like ava and noesis could reuse this architecture, to take advantage of native bindings.

Ub is always not covering everything, things like react native is only to make things more and more complicated and is never to be rootly solved.

juepiezhongren · 2017-11-21T08:35:46Z

@Mike-EEE noesis's web page is cool

Mike-E-angelo · 2017-11-21T08:42:59Z

Like I said @juepiezhongren everyone should be covered, one way or another. You can tell this space is gaining momentum again and there are a lot of creative minds that are starting to explore and contribute. Far cry from a year or so ago, huh! 😆

[sdk] Add wasm interpreter support. Commit migrated from mono/mono@a62a7e7

kumpera added 2 commits November 1, 2017 14:15

[wasm] Add wasm-interp target to build the wasm interpreter based run…

55cae50

…time.

[sdk] Use single : in android target that doesn't get appended to.

80a2087

kumpera requested review from luhenry and marek-safar as code owners November 1, 2017 21:17

dnfclas added the cla-already-signed label Nov 1, 2017

luhenry suggested changes Nov 2, 2017

View reviewed changes

kumpera added 5 commits November 2, 2017 15:22

[sdk] Fix wasm build.

6f229c1

[wasm] Workaround for emcc 1.37.22 that miscompiles the inline assembly.

675b190

[wasm] Update port to work with master.

db00ae8

[wasm] Build the wasm profile is it was configured in.

a0687c1

[wasm] Add test runner that executes the mini test suite.

d1349d2

kumpera requested review from akoeplinger, BrzVlad, lewurm and vargaz as code owners November 2, 2017 23:00

[sdks] Address reviewer suggestion.

01e7674

SteveSandersonMS reviewed Nov 3, 2017

View reviewed changes

luhenry previously approved these changes Nov 6, 2017

View reviewed changes

[wasm] Fix test driver and mono's JS support library.

5ed0fab

kumpera dismissed luhenry’s stale review via 5ed0fab November 6, 2017 23:47

lewurm approved these changes Nov 7, 2017

View reviewed changes

luhenry approved these changes Nov 7, 2017

View reviewed changes

kumpera merged commit a62a7e7 into mono:master Nov 7, 2017

Mike-E-angelo mentioned this pull request Nov 22, 2017

Discussion: just a thought microsoft/xaml-standard#222

Open

4 tasks

picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022

Merge pull request mono/mono#5924 from kumpera/wasm-sdk-integration

6c48dad

[sdk] Add wasm interpreter support. Commit migrated from mono/mono@a62a7e7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[sdk] Add wasm interpreter support. #5924

[sdk] Add wasm interpreter support. #5924

kumpera commented Nov 1, 2017 •

edited

Loading

luhenry Nov 2, 2017

kumpera Nov 2, 2017

luhenry Nov 2, 2017

luhenry Nov 2, 2017

kumpera Nov 2, 2017

luhenry Nov 2, 2017

kumpera Nov 2, 2017

kumpera commented Nov 2, 2017

kumpera commented Nov 2, 2017

SteveSandersonMS Nov 3, 2017

SteveSandersonMS Nov 3, 2017

SteveSandersonMS Nov 3, 2017

kumpera commented Nov 7, 2017

lewurm left a comment

juepiezhongren commented Nov 10, 2017 •

edited

Loading

kumpera commented Nov 10, 2017

Mike-E-angelo commented Nov 21, 2017

juepiezhongren commented Nov 21, 2017

Mike-E-angelo commented Nov 21, 2017

juepiezhongren commented Nov 21, 2017

Mike-E-angelo commented Nov 21, 2017

juepiezhongren commented Nov 21, 2017 •

edited

Loading

juepiezhongren commented Nov 21, 2017

Mike-E-angelo commented Nov 21, 2017

[sdk] Add wasm interpreter support. #5924

[sdk] Add wasm interpreter support. #5924

Conversation

kumpera commented Nov 1, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kumpera commented Nov 2, 2017

kumpera commented Nov 2, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kumpera commented Nov 7, 2017

lewurm left a comment

Choose a reason for hiding this comment

juepiezhongren commented Nov 10, 2017 • edited Loading

kumpera commented Nov 10, 2017

Mike-E-angelo commented Nov 21, 2017

juepiezhongren commented Nov 21, 2017

Mike-E-angelo commented Nov 21, 2017

juepiezhongren commented Nov 21, 2017

Mike-E-angelo commented Nov 21, 2017

juepiezhongren commented Nov 21, 2017 • edited Loading

juepiezhongren commented Nov 21, 2017

Mike-E-angelo commented Nov 21, 2017

kumpera commented Nov 1, 2017 •

edited

Loading

juepiezhongren commented Nov 10, 2017 •

edited

Loading

juepiezhongren commented Nov 21, 2017 •

edited

Loading