New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jit] Fix using conv.u with string. #6020

Merged
merged 1 commit into from Nov 16, 2017

Conversation

Projects
None yet
5 participants
@kumpera
Member

kumpera commented Nov 15, 2017

No description provided.

@kumpera kumpera requested a review from vargaz as a code owner Nov 15, 2017

@vargaz

vargaz approved these changes Nov 15, 2017

@marek-safar marek-safar merged commit bec9f13 into mono:2017-10 Nov 16, 2017

13 of 17 checks passed

Linux AArch64 Interpreter Build finished. 345 tests run, 0 skipped, 0 failed.
Details
Linux ARMv7 hard float Build finished. 46949 tests run, 1404 skipped, 0 failed.
Details
Linux ARMv7 hard float Interpreter Build finished. 339 tests run, 0 skipped, 0 failed.
Details
Linux x64 Interpreter Build finished. 348 tests run, 0 skipped, 0 failed.
Details
API Diff No public API changes found.
Details
Linux AArch64 Build finished. 46979 tests run, 1409 skipped, 0 failed.
Details
Linux ARMv5 soft float Build finished. 46949 tests run, 1404 skipped, 0 failed.
Details
Linux i386 Build finished. 46982 tests run, 1401 skipped, 0 failed.
Details
Linux x64 Build finished. 46982 tests run, 1403 skipped, 0 failed.
Details
Linux x64 FullAOT Build finished. 20780 tests run, 529 skipped, 0 failed.
Details
Linux x64 mcs Build finished.
Details
OS X i386 Build finished. 46145 tests run, 1285 skipped, 0 failed.
Details
OS X x64 Build finished. 46145 tests run, 1287 skipped, 0 failed.
Details
Test Result Viewer Click to view aggregated test results (Xamarin internal).
Details
Windows i386 Build finished. 42148 tests run, 1112 skipped, 0 failed.
Details
Windows x64 Build finished. 42170 tests run, 1114 skipped, 0 failed.
Details
license/cla All CLA requirements met.
Details

knocte added a commit to knocte/gwallet that referenced this pull request Sep 8, 2018

Backend/JsonRpcSharp: new System.IO.Pipelines-based TCP client
Even though this one is still synchronous, it's a better foundation
for upcoming modifications (async, cancellation) than the old client
which had many quirks and was probably very slow. We don't shelve
the old client, though (we rename it to LegacyTcpClient), because
older versions of Mono have a runtime bug that is exposed when using
the new TCP client. It's not a big deal though, to have this version
used in the Ubuntu(Linux) client, because the upcoming improvements
for the new client are mainly targetted at mobile platforms, which
have more restrictions (and hence we need better cancellation story).

The Mono bug existing in v.4.6.2 manifests itself this way:
* Assertion at local-propagation.c:330, condition `ins->opcode > MONO_CEE_LAST' not met

Which looks to be the same as:
https://bugzilla.xamarin.com/show_bug.cgi?id=60625

Which seems to be fixed by:
mono/mono#6020

Which was backported to 5.4:
mono/mono#6242

( https://github.com/mono/mono/blob/d15-5-2017-06/configure.ac )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment