New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jit] Fix using conv.u with string. #6242

Merged
merged 1 commit into from Dec 14, 2017

Conversation

Projects
None yet
4 participants
@vargaz
Member

vargaz commented Dec 14, 2017

No description provided.

@marek-safar

This comment has been minimized.

Show comment
Hide comment
@marek-safar

marek-safar Dec 14, 2017

Member

What's the motivation for the backport?

Member

marek-safar commented Dec 14, 2017

What's the motivation for the backport?

@marek-safar marek-safar self-requested a review Dec 14, 2017

@marek-safar

This comment has been minimized.

Show comment
Hide comment
@marek-safar
Member

marek-safar commented Dec 14, 2017

@marek-safar marek-safar merged commit b293f45 into mono:d15-5-2017-06 Dec 14, 2017

7 of 18 checks passed

Linux AArch64 Build finished. 46473 tests run, 1358 skipped, 0 failed.
Details
Linux AArch64 Interpreter Build finished. 343 tests run, 0 skipped, 0 failed.
Details
Linux x64 Acceptance Tests Build finished. 1638 tests run, 5 skipped, 0 failed.
Details
Linux x64 FullAOT Build finished. 20896 tests run, 528 skipped, 1 failed.
Details
Linux x64 Interpreter Build finished. 346 tests run, 0 skipped, 1 failed.
Details
Linux x64 mcs Build finished.
Details
OS X i386 Build finished. 45321 tests run, 1233 skipped, 1 failed.
Details
Windows x64 Build finished. 40278 tests run, 1064 skipped, 0 failed.
Details
Linux ARMv5 soft float Build triggered. sha1 is merged.
Details
Linux ARMv7 hard float Build triggered. sha1 is merged.
Details
Linux ARMv7 hard float Interpreter Build triggered. sha1 is merged.
Details
API Diff No public API changes found.
Details
Linux i386 Build finished. 46565 tests run, 1350 skipped, 0 failed.
Details
Linux x64 Build finished. 46565 tests run, 1352 skipped, 0 failed.
Details
OS X x64 Build finished. 45321 tests run, 1235 skipped, 0 failed.
Details
Test Result Viewer Click to view aggregated test results (Xamarin internal).
Details
Windows i386 Build finished. 40345 tests run, 1062 skipped, 0 failed.
Details
license/cla All CLA requirements met.
Details

spouliot added a commit to spouliot/xamarin-macios that referenced this pull request Dec 14, 2017

spouliot added a commit to xamarin/xamarin-macios that referenced this pull request Dec 14, 2017

spouliot added a commit to xamarin/xamarin-macios that referenced this pull request Dec 18, 2017

Merge d15-5 into xcode9.2 (for SR3) (#3111)
* Updated reference to mono/mono@950ea65 (#2975)

* [macos] Fix AVCaptureDepthDataOutput on HS and 10.13 typo (#2977)

* Bump mono to get the conv.u/roslyn fix. Fixes #60625 (#3100)

mono/mono#6242
@mellinoe

This comment has been minimized.

Show comment
Hide comment
@mellinoe

mellinoe Jan 5, 2018

What is the next stable release that will include this? I'm hitting this in a ton of places in my library when running on mono.

mellinoe commented Jan 5, 2018

What is the next stable release that will include this? I'm hitting this in a ton of places in my library when running on mono.

@marek-safar

This comment has been minimized.

Show comment
Hide comment
@marek-safar

marek-safar Jan 5, 2018

Member

It's already included in Mono 5.8

Member

marek-safar commented Jan 5, 2018

It's already included in Mono 5.8

knocte added a commit to knocte/gwallet that referenced this pull request Sep 8, 2018

Backend/JsonRpcSharp: new System.IO.Pipelines-based TCP client
Even though this one is still synchronous, it's a better foundation
for upcoming modifications (async, cancellation) than the old client
which had many quirks and was probably very slow. We don't shelve
the old client, though (we rename it to LegacyTcpClient), because
older versions of Mono have a runtime bug that is exposed when using
the new TCP client. It's not a big deal though, to have this version
used in the Ubuntu(Linux) client, because the upcoming improvements
for the new client are mainly targetted at mobile platforms, which
have more restrictions (and hence we need better cancellation story).

The Mono bug existing in v.4.6.2 manifests itself this way:
* Assertion at local-propagation.c:330, condition `ins->opcode > MONO_CEE_LAST' not met

Which looks to be the same as:
https://bugzilla.xamarin.com/show_bug.cgi?id=60625

Which seems to be fixed by:
mono/mono#6020

Which was backported to 5.4:
mono/mono#6242

( https://github.com/mono/mono/blob/d15-5-2017-06/configure.ac )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment