New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git stash comment not displayed in Stash Manager dialog #4723

Closed
mrward opened this Issue May 4, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@mrward
Member

mrward commented May 4, 2018

Creating a new project and a local git repository with one commit, you can create stashes with comments but the comments are not shown in the Stash Manager dialog.

stashmanager

When running git stash list from the command line I see:

stash@{0}: On master: Added file
stash@{1}: On master: Class renamed

A quick debug of the Stash Manager dialog it seems we are using the Stash.FriendlyName which just has the stash number stash@{0}. The Stash.Message contains the comment: On master: Added file\n\n. So we could append these together.

VS bug #611146

@mrward mrward added the vs-sync label May 4, 2018

mrward added a commit that referenced this issue May 5, 2018

[Git] Show stash message in Stash Manager dialog
The Stash Manager dialog now shows the same information that the
`git stash list` command line shows. Previously just the stash
number "stash@{0}" was shown for each stash making it difficult to
know what the stash was for. Now the stash message is shown which
includes the branch name.

stash@{0}: On master:
stash@{1}: On master: Added new file
stash@{2}: On master: Change MyClass name

Fixes issue #4723 - Git stash comment not displayed in Stash Manager
dialog

mrward added a commit that referenced this issue May 6, 2018

[Git] Show stash message in Stash Manager dialog
The Stash Manager dialog now shows the same information that the
`git stash list` command line shows. Previously just the stash
number "stash@{0}" was shown for each stash making it difficult to
know what the stash was for. Now the stash message is shown which
includes the branch name.

stash@{0}: On master:
stash@{1}: On master: Added new file
stash@{2}: On master: Change MyClass name

Fixes issue #4723 - Git stash comment not displayed in Stash Manager
dialog
@xamarin-release-manager

This comment has been minimized.

Contributor

xamarin-release-manager commented May 6, 2018

Fixed in version 7.6.0.712 (master)

Author: Matt Ward
Commit: 394c35b (mono/monodevelop)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment