New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle line comment menu no longer exists #4822

Closed
mrward opened this Issue May 16, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@mrward
Member

mrward commented May 16, 2018

VS Mac 7.6.0.818 (master)

Right clicking a selection of code in the text editor and the Toggle line comment menu item is not available. So it is not currently possible to comment out a section of code without typing in the comments yourself.

VS bug #617345

@mkrueger

This comment has been minimized.

Contributor

mkrueger commented May 17, 2018

It's caused by the syntax highlighting.

GetScopeStackAsync is not implemented.

@slluis slluis closed this in f7b338b May 25, 2018

@xamarin-release-manager

This comment has been minimized.

Contributor

xamarin-release-manager commented May 25, 2018

Fixed in version 7.6.0.947 (master)

Pull Request #4842 merged by: Lluis Sanchez
Author: mono
Commit: f7b338b (mono/monodevelop)

@mrward

This comment has been minimized.

Member

mrward commented Jun 14, 2018

If you select all the text in the text document the Toggle Line Comment menu does not appear which was been found already by Ashley.

Also if you select text upwards that does not seem to show the Toggle Line Comment but selecting the text downwards for the same selection works fine.

togglelinecomment

The text editor path bar seems just show 'No selection' in each case when Toggle Line Comment is not available. Although this is not always the case - you can select the text upwards but not the entire line and the menu is not available.

This is with VS Mac 7.6.0.1600 (master wrench build).

DavidKarlas added a commit that referenced this issue Jun 19, 2018

Fix #4822: Fixing code comment command for all cases
Problem was that in case of start/end of line where Roslyn didn’t report any specific highlighting we used defaultScope, problem with that was that after switch from RoslynClassifier to TagBased one I used Foreground which didn’t stack on top of “sources.cs”. So now `defaultScopeStack` is set correctly, and to better match with RoslynClassifier I also re-introduced userScope.
Also includes unit tests

DavidKarlas added a commit that referenced this issue Jun 21, 2018

Merge pull request #5102 from mono/fix4822
Fix #4822: Fixing code comment command for all cases

monojenkins added a commit that referenced this issue Jun 21, 2018

Fix #4822: Fixing code comment command for all cases Problem was that…
… in case of start/end of line where Roslyn didn’t report any specific highlighting we used defaultScope, problem with that was that after switch from RoslynClassifier to TagBased one I used Foreground which didn’t stack on top of “sources.cs”. So now `defaultScopeStack` is set correctly, and to better match with RoslynClassifier I also re-introduced userScope. Also includes unit tests
@xamarin-release-manager

This comment has been minimized.

Contributor

xamarin-release-manager commented Jun 21, 2018

Fixed in version 7.7.0.302 (master)

Pull Request #5102 merged by: David Karlaš
Author: mono
Commit: 895d2ae (mono/monodevelop)

slluis added a commit that referenced this issue Jun 21, 2018

Merge pull request #5127 from mono/backport-pr-5102-to-release-7.6
[release-7.6] Fix #4822: Fixing code comment command for all cases
@xamarin-release-manager

This comment has been minimized.

Contributor

xamarin-release-manager commented Jun 21, 2018

Fixed in version 7.6.0.1794 (release-7.6)

Pull Request #5127 merged by: Lluis Sanchez
Author: mono
Commit: 0069905 (mono/monodevelop)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment