Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in referenced assembly resolving #1166

Closed
wants to merge 2 commits into from

Conversation

@tomkcook
Copy link
Contributor

tomkcook commented Dec 4, 2015

The old implementation of this method attempted to resolve all libraries referenced by the template, even ones that had already been loaded by the runtime, and would sometimes return the wrong assembly (it would essentially always return whatever was last in the list).

This implementation should only load assemblies that can't be found through some other mechanism.

@slluis

This comment has been minimized.

Copy link
Member

slluis commented Dec 4, 2015

@mrward

This comment has been minimized.

Copy link
Member

mrward commented Dec 4, 2015

It looks like the change now means the assemblyFiles list is no longer used. This list is taken from the TemplateSettings and also includes the host's StandardAssemblyReferences. So with this change these assemblies would not be used when resolving.

Probably need to review the problem Tom is having in more detail:

http://lists.ximian.com/pipermail/monodevelop-list/2015-December/016420.html
https://github.com/tomkcook/T4CSTest

@tomkcook

This comment has been minimized.

Copy link
Contributor Author

tomkcook commented Dec 4, 2015

Okay; I'm going to open a new pull request to try to fix this properly, as I didn't realize my fork was several thousand commits behind when I started this one and it makes building the repository a pain.

@tomkcook

This comment has been minimized.

Copy link
Contributor Author

tomkcook commented Dec 4, 2015

See #1168.

@tomkcook tomkcook closed this Dec 4, 2015
@tomkcook tomkcook deleted the tomkcook:assembly-loading-fix branch Dec 4, 2015
@mhutch mhutch self-assigned this Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.