Only hash the buffer if the read was successful. Should improve perfo…

…rmance slightly for cases where the data does not exist. svn path=/trunk/bitsharp/; revision=156065
alanmcgovern · Apr 25, 2010 · 346ae16 · 346ae16
1 parent 47d2872
commit 346ae16
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/MonoTorrent/MonoTorrent.Client/Managers/DiskManager.cs b/src/MonoTorrent/MonoTorrent.Client/Managers/DiskManager.cs
@@ -346,13 +346,18 @@ internal void BeginGetHash(TorrentManager manager, int pieceIndex, MainLoopResul
             DiskIOCallback readCallback = null;
             readCallback = delegate(bool successful) {
 
-                hasher.TransformBlock(hashBuffer, 0, count, hashBuffer, 0);
+                if (successful)
+                    hasher.TransformBlock(hashBuffer, 0, count, hashBuffer, 0);
                 offset += count;
 
                 if (!successful || offset == endOffset)
                 {
-                    hasher.TransformFinalBlock(hashBuffer, 0, 0);
-                    object hash = successful ? hasher.Hash : null;
+                    object hash = null;
+                    if (successful)
+                    {
+                        hasher.TransformFinalBlock(hashBuffer, 0, 0);
+                        hash = hasher.Hash;
+                    }
                     ((IDisposable)hasher).Dispose();
                     ClientEngine.BufferManager.FreeBuffer(ref hashBuffer);
                     ClientEngine.MainLoop.Queue(delegate {