Skip to content
Permalink
Browse files

Merge pull request #25 from xoofx/fix_gyp_msvs_config_bug

Fix a bug where skia binaries are built with asserts even in Release, 15Mo instead of 5Mo DLL
  • Loading branch information...
mattleibow committed Oct 10, 2016
2 parents b11930c + 3a1c21f commit a85cb36675651b4858957ff2ad6540a80b3cefa7
Showing with 3 additions and 3 deletions.
  1. +1 −1 gyp/common.gypi
  2. +2 −2 gyp/common_conditions.gypi
@@ -101,7 +101,7 @@
'configurations': {
'Debug': { 'defines': [ 'SK_DEBUG=1' ] },
'Release': { 'defines': [ 'NDEBUG' ] },
'Release_Developer': {
'ReleaseDeveloper': {
'inherit_from': ['Release'],
'defines': [ 'SK_DEBUG=1' ],
'conditions': [
@@ -178,8 +178,8 @@
},
},
},
'Release_Developer_x64': {
'inherit_from': ['Release_Developer'],
'ReleaseDeveloper_x64': {
'inherit_from': ['ReleaseDeveloper'],
'msvs_settings': {
'VCCLCompilerTool': {
# Don't specify /arch. SSE2 is implied by 64bit and specifying it warns.

0 comments on commit a85cb36

Please sign in to comment.
You can’t perform that action at this time.