[TreeView] [Gtk] [WPF] OnRowCollapsing and OnRowCollapsed implemented #348

Merged
merged 2 commits into from Aug 3, 2014

Conversation

Projects
None yet
2 participants
Contributor

residuum commented Jun 23, 2014

Fixes issue #347

Contributor

residuum commented Jun 25, 2014

As I do not have a Mac, so I cannot try this change and therefore did not submit this as well.

After reading the documentation and Xwt.Mac/TreeViewBackend.cs, these needs to be added in the inner class TreeDelegate in that file after line 53:

        public override void ItemDidCollapse(NSNotification notification)
        {
            Backend.EventSink.OnRowCollapsed (((TreeItem)notification.UserInfo["NSObject"]).Position);
        }

        public override void ItemWillCollaps (NSNotification notification)
        {
            Backend.EventSink.OnRowCollapsing (((TreeItem)notification.UserInfo["NSObject"]).Position);
        }

@slluis slluis commented on an outdated diff Jun 28, 2014

Xwt/Xwt/TreeView.cs
@@ -282,7 +293,7 @@ public void UnselectAll ()
{
Backend.UnselectAll ();
}
-
@slluis

slluis Jun 28, 2014

Owner

Please don't include formatting changes.

residuum added some commits Jul 2, 2014

@residuum residuum TreeView collapse events:
- events Collapsing and Collapsed
- implementation in GTK and WPF
- samples
9829857
@residuum residuum Formatting 87d4505
Contributor

residuum commented Jul 15, 2014

I redid all the changes in new commits, so that not formatting changes are included in the pull request.

@slluis slluis added a commit that referenced this pull request Aug 3, 2014

@slluis slluis Merge pull request #348 from residuum/master
[TreeView] [Gtk] [WPF] OnRowCollapsing and OnRowCollapsed implemented
b54931e

@slluis slluis merged commit b54931e into mono:master Aug 3, 2014

Owner

slluis commented Aug 3, 2014

I added the Mac overrides and works fine. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment