Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please merge the branch freebsd-support #244

Closed
yurivict opened this issue Feb 23, 2019 · 5 comments
Closed

Please merge the branch freebsd-support #244

yurivict opened this issue Feb 23, 2019 · 5 comments

Comments

@yurivict
Copy link
Contributor

I can't update the port now because master changes are incompatible with the branch.
The PR was mergeable into master when I submitted it.

@monocasual
Copy link
Collaborator

I think you can merge it "graphically" - i.e. via GitHub interface on the freebsd-support branch. Can you confirm this?

@yurivict
Copy link
Contributor Author

There are conflicts now. Such merges should be done by the upstream maintainer, and should be merge with the master branch.
Otherwise, there is not much value in the OS-specific branch if it isn't updated/needs constant attention.
It should be merged into master.

@luzpaz
Copy link
Contributor

luzpaz commented May 16, 2019

I think @yurivict has a relevant argument that can apply to any package maintainer

@monocasual
Copy link
Collaborator

freebsd-support branch updated and ready for the merge 👍 Please let me know if there's something missing!

@yurivict
Copy link
Contributor Author

I verified, this branch builds fine. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants