bfin emulator bugs, new modules, assorted DSP inc softclip svf #266
Conversation
|
hot damn. fantastic. i'm going to test the old modules about before merging, though i certainly don't forsee any issues having these changes on the dev branch. |
|
note to self: don't forget to add the old svf wrapping rq functionality back in & add a dsyn param to flick this feature on/off for that module. |
|
ehh, i don't think that's really necessary. i was being a bit facetious, surely better to have RQ parameter work as expected in all cases. |
|
I really like the idea that this 'bug' is also a feature! (kinda like the frequency wrapping 'bug' on DX7 I read about somewhere) It's 5 minutes work to make that change - no regressions for the sake of 'correctness'! Look here: |
|
added ricks_tricks to lines/dsyn makefiles, so they compile. sounds fine! |
|
btw maybe worth pointing out that |
|
Maybe I'll try firing waves up in linux emulator - I would bet anyone five bucks (canadian) it will just work after removing any ifdefs from old portaudio wrapper... |
|
the main problems IMO are kinda hardware-specific, i'd guess:
|
|
Explain more about the tuning values getting quantized in an unfortunate manner! Maybe open an issue? I had a minor epiphany how to do really long slews with the fract arithmetic primitives - maybe this technique helps: |
|
yechh, it's more icky than i thought. opened: |
Nothing that should be controversial in here, apart from the changes to svf code. Those could potentially affect @catfact's original modules and I admit haven't actually tested lines/waves/dsyn since making the changes but I believe old svf code was just not quite right. I'll try and get some testing done tomorrow evening. Maybe also ask for help with this on the forum...
This pull-request addresses bugs in bfin emu (see #245)
I'm claiming svf changes address these three issues:
#147
#145
#101
not actually bothering to over-sample the svf in monosynth module, ~6kHz upper limit is something I'll live with, seeing as it prob also makes this code run faster... Original oversampled version should still work exactly as before, though the code was reordered a bit to make the built-in mixer optional...
oh and there are three new modules - all works in progress but hey...