Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for msc and timer changes in libavr32 #24

Merged
merged 2 commits into from May 17, 2017
Merged

Conversation

@samdoshi
Copy link
Collaborator

@samdoshi samdoshi commented May 8, 2017

Please merge monome/libavr32#26 first

@samdoshi samdoshi changed the title update for msc changes in libavr32 update for msc and timer changes in libavr32 May 17, 2017
@tehn tehn merged commit 9b3257e into monome:master May 17, 2017
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Copy link
Member

@ngwese ngwese left a comment

I have some concerns about the change to dac_update_now.

The reason the interrupts are being disabled is that the dac update timer function is not re-entrant. The arp/midi code uses dac_update_now to force a dac change outside of the normal timer callback based slewing in order to minimize the latency between trigger and cv output changes for a note.

It would probably be better to replace the original interrupt masking with timer pause/resume instead of eliminating it entirely.

@samdoshi
Copy link
Collaborator Author

@samdoshi samdoshi commented May 17, 2017

There is no change in dac_update_now, I've just deleted some commented out lines. Or am I getting confused by something?

@ngwese
Copy link
Member

@ngwese ngwese commented May 17, 2017

Ack. You are correct, I didn't realize they were commented out. Now I'm curious if that means the potential race condition I was thinking about is present (I should know given that the code came from me...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants