(meadowphysics) fix tigger behaviour in 1 CV/TR #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that meadowphysics doesn't trigger when the voice mode is set to 1 CV/TR.
In
mp_note_on(), it looks like this is due toif(mp_clock_count)never passing due tomp_clock_countbeing initialized to 0 inclock_mp(). Since it never passes,mp_clock_countis never incremented and a voice is never allocated.The solution is to properly check the value of
mp_clock_count, just like the other voice allocation modes. (It could just as easily bemp_clock_count == 0, but I thought this was clearer.)(I've also included some whitespace changes here that I'd be happy to remove if you don't want them.)