Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycles Mode: When reaching config mode 3, rotate back to 1 #36

Merged
merged 1 commit into from Dec 31, 2018

Conversation

@weskoop
Copy link
Contributor

@weskoop weskoop commented Dec 29, 2018

Aligns with other modes' config screens

…ith other modes' config screens
@scanner-darkly
Copy link
Member

@scanner-darkly scanner-darkly commented Dec 30, 2018

was the functionality for the left button in cycles changed at some point? the doc on the website shows friction as the only function for the left button.

if i’m reading this correctly with this change the final else will never be reached which means it won’t track long presses.

@weskoop
Copy link
Contributor Author

@weskoop weskoop commented Dec 30, 2018

It's also used for cycling config modes (mode 1-3) while holding the RIGHT button.

Holding the RIGHT button sets mode=1, releasing RIGHT sets mode=0 again and the ELSE us run when not in config mode.

@scanner-darkly
Copy link
Member

@scanner-darkly scanner-darkly commented Dec 30, 2018

ah yeah makes sense. looks like this is definitely not in the official documentation unless i'm missing something

@weskoop
Copy link
Contributor Author

@weskoop weskoop commented Dec 31, 2018

@tehn
Copy link
Member

@tehn tehn commented Dec 31, 2018

this seems like a good improvement, thanks! if there is missing documentation can you put in an issue at https://github.com/monome/docs ?

@tehn tehn merged commit 05601e0 into monome:master Dec 31, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants