Update flash_tools extractor script for ansible 3.0.0 schema #80
Conversation
|
This looks good, thanks for putting it together. If this was sufficient to carry over your presets that's good enough testing for me I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I haven't done super extensive testing, but these changes appear to produce identical output to the on-device export for 3.0.0.
This PR also fixes the type of kria's
note_div_syncin the on-device serialization. It was harmlessly(?) being recorded as a number instead of bool, which parses fine (I think?) but wasn't consistent with the canonical type and the extractor output.I'm not sure if changing the default version strings to 3.0.0 everywhere is the right choice if the primary use case for this tool is still upgrading older preset files to the latest version.