Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible (via ii) channels are 0-based #197

Closed
mimetaur opened this issue Oct 5, 2019 · 3 comments
Closed

Ansible (via ii) channels are 0-based #197

mimetaur opened this issue Oct 5, 2019 · 3 comments
Milestone

Comments

@mimetaur
Copy link

@mimetaur mimetaur commented Oct 5, 2019

I noticed this today when I connected my new Crow (via Norns) and Ansible. It took me a while to debug why nothing was working, until I happened to notice the channel two light flashing.

Seems to me everything in Lua should stay 1-based, even if it just means making an offset by 1 in the Ansible definition on the Crow side.

@tehn
Copy link
Member

@tehn tehn commented Oct 6, 2019

thanks for catching this. will fix--- it's a bug in the ansible.lua ii definition

@trentgill trentgill added this to the 1.0.1 milestone Oct 8, 2019
@ngwese
Copy link
Member

@ngwese ngwese commented Oct 13, 2019

Ah yes, and I've confirmed just now - this off by one issue was mentioned in #198 as well. That ticket is looking at enhancements to the ii definition system so I'll keep this issue in mind.

@trentgill
Copy link
Collaborator

@trentgill trentgill commented Nov 19, 2019

fixed in #224

@trentgill trentgill closed this Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants