Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIDI implentation #120

Merged
merged 10 commits into from May 23, 2019
Merged

MIDI implentation #120

merged 10 commits into from May 23, 2019

Conversation

@trentgill
Copy link
Collaborator

@trentgill trentgill commented May 22, 2019

MIDI is working. working fine w op1 via weird usb midi converter. issues with korg monologue where a few clock messages work before it stops responding (the rest o system is fine). reactivating midi reenables it for a handful more messages. i will pursue further but monologue is out of battery and i dont have adaptor currently.

syntax for use is identical to norns, see README. uses the Midi.to_msg() function which is lifted straight from norns. for 'satellite' use, you just leave the default callback and it sends a lua function called midi() with each byte as an argument. this emulates the low layer of norns so you can plug it directly to to_msg.

syntax for activation is via the input library! this felt logical and was sam's intuition when writing example scripts. the input[n].mode param sets the functionality of the input jack, and midi is just that! deactivating uart happens whenever a non-midi mode is selected.

fixes #12

@trentgill trentgill requested a review from tehn May 22, 2019
@tehn
tehn approved these changes May 23, 2019
Copy link
Member

@tehn tehn left a comment

this is totally super rad!!!

@trentgill trentgill merged commit 9e2d6ac into master May 23, 2019
@trentgill trentgill deleted the midi-plumbing branch May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants