increase First gate threshold to 1V #216
Merged
Conversation
|
thanks for spotting this! |
|
Let's not change First.lua, but change the default in input.lua. I want users to be able to use the default parameters as much as possible, so feels better to change the defaults to more widely acceptable values. |
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Seems from measurement that Maths EOR/EOC gate outputs, and probably some other common modules, have a sloppy low of about 0.7V, causing First not to trigger. Not sure if maybe the default threshold (0.5V) in input.lua should be changed as well. This was giving at least one person trouble, thought I saw another post about this too but am not finding it now.